Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 09:52:18 +0000
Message-ID: <86lenvmmnh.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Samuel Holland <samuel@sholland.org>
Cc:     Tiezhu Yang <yangtiezhu@loongson.cn>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] irqchip: LoongArch: Select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
In-Reply-To: <cf953917-efe4-8254-f468-3baf7e596483@sholland.org>
References: <1666841949-5244-1-git-send-email-yangtiezhu@loongson.cn>
        <87v8n1ubbj.wl-maz@kernel.org>
        <cf953917-efe4-8254-f468-3baf7e596483@sholland.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sat, 26 Nov 2022 23:49:10 +0000,
Samuel Holland <samuel@sholland.org> wrote:
> 
> On 11/26/22 06:53, Marc Zyngier wrote:
> > On Thu, 27 Oct 2022 04:39:09 +0100,
> > Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> >>
> >> An IRQ's effective affinity can only be different from its configured
> >> affinity if there are multiple CPUs. Make it clear that this option is
> >> only meaningful when SMP is enabled.
> >>
> >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> >> ---
> >>
> >> v2: rebased on 6.1-rc2
> >>
> >>  drivers/irqchip/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> >> index 7ef9f5e..8461915 100644
> >> --- a/drivers/irqchip/Kconfig
> >> +++ b/drivers/irqchip/Kconfig
> >> @@ -575,7 +575,7 @@ config IRQ_LOONGARCH_CPU
> >>  	bool
> >>  	select GENERIC_IRQ_CHIP
> >>  	select IRQ_DOMAIN
> >> -	select GENERIC_IRQ_EFFECTIVE_AFF_MASK
> >> +	select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP
> >>  	select LOONGSON_LIOINTC
> >>  	select LOONGSON_EIOINTC
> >>  	select LOONGSON_PCH_PIC
> > 
> > We already have this:
> > 
> > # Supports effective affinity mask
> > config GENERIC_IRQ_EFFECTIVE_AFF_MASK
> >        depends on SMP
> >        bool
> > 
> > Do we really need to express this for every interrupt controller?
> 
> Unfortunately yes, because "select" does not respect dependencies. So
> the "depends on SMP" line does not enforce anything; it only serves to
> provide a warning at configure time that the build will break.

I understand that. My question was more "how can we avoid doing that
for each and every irqchip".

So far, the only things I can think of are either an intermediate
config symbol that performs the "if SMP" by itself, or spraying checks
for CONFIG_SMP all over the shop. None of which are appealing.

	M.

-- 
Without deviation from the norm, progress is not possible.