Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 12:59:28 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Jianglei Nie <niejianglei2021@163.com>
Cc:     ojeda@kernel.org, geert+renesas@glider.be,
        linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] auxdisplay: hd44780: Fix potential memory leak in
 hd44780_remove()
Message-ID: <Y4SUkGYK5Y6Uo3Bv@smile.fi.intel.com>
References: <20221128084421.8626-1-niejianglei2021@163.com>
 <Y4SRUwKFGJfwNZ2U@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y4SRUwKFGJfwNZ2U@smile.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Nov 28, 2022 at 12:45:39PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 28, 2022 at 04:44:21PM +0800, Jianglei Nie wrote:

...

> Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")
> 
> What you found has nothing to do with the issue. Issue has been introduced
> later on.

Side note (mostly for Miguel): That series by Lars was indeed problematic.
And I see now that he didn't get the parameter to the charlcd_alloc(). Now
we have problem that your patch solves and dangling parameter in the struct
charlcd_priv. So, I will restore charlcd_alloc() before his series (after
this patch has been applied, because of the backport needs) for a new
kernel development cycle.

-- 
With Best Regards,
Andy Shevchenko