Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <19ef6b09-678c-cf9d-7f91-684e6d00e6a9@marcan.st>
Date:   Mon, 28 Nov 2022 20:35:29 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] soc: apple: rtkit: Stop casting function pointer
 signatures
Content-Language: en-US
To:     Sven Peter <sven@svenpeter.dev>, Arnd Bergmann <arnd@arndb.de>
Cc:     Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
References: <20221104154153.79373-1-sven@svenpeter.dev>
From:   Hector Martin <marcan@marcan.st>
In-Reply-To: <20221104154153.79373-1-sven@svenpeter.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 05/11/2022 00.41, Sven Peter wrote:
> Fixes: 9bd1d9a0d8bb ("soc: apple: Add RTKit IPC library")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Sven Peter <sven@svenpeter.dev>
> ---
>  drivers/soc/apple/rtkit.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/soc/apple/rtkit.c b/drivers/soc/apple/rtkit.c
> index ecc1a818b23d..fa3cda831d2b 100644
> --- a/drivers/soc/apple/rtkit.c
> +++ b/drivers/soc/apple/rtkit.c
> @@ -922,8 +922,10 @@ int apple_rtkit_wake(struct apple_rtkit *rtk)
>  }
>  EXPORT_SYMBOL_GPL(apple_rtkit_wake);
>  
> -static void apple_rtkit_free(struct apple_rtkit *rtk)
> +static void apple_rtkit_free(void *data)
>  {
> +	struct apple_rtkit *rtk = data;
> +
>  	mbox_free_channel(rtk->mbox_chan);
>  	destroy_workqueue(rtk->wq);
>  
> @@ -946,8 +948,7 @@ struct apple_rtkit *devm_apple_rtkit_init(struct device *dev, void *cookie,
>  	if (IS_ERR(rtk))
>  		return rtk;
>  
> -	ret = devm_add_action_or_reset(dev, (void (*)(void *))apple_rtkit_free,
> -				       rtk);
> +	ret = devm_add_action_or_reset(dev, apple_rtkit_free, rtk);
>  	if (ret)
>  		return ERR_PTR(ret);
>  

Applied to asahi-soc/soc, thanks!

- Hector