Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp14690087rwb; Mon, 28 Nov 2022 04:05:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf5vzDxSQCnOTq3S2cxjntB9dHLQPmlhZDEo0bJnwruHv8BIcwLRL/TVEwPieH0zf5qiTBCQ X-Received: by 2002:a17:907:7e86:b0:7af:bc9:5e8d with SMTP id qb6-20020a1709077e8600b007af0bc95e8dmr44043944ejc.3.1669637113259; Mon, 28 Nov 2022 04:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669637113; cv=none; d=google.com; s=arc-20160816; b=Bmsb3Bs5/bAMMxpsBqzv2r0HqYf/ycCD/ULO6byEfElKF3lKd2P/MVEJ3GR9GHaJAF WPWSK/Dbw/gNW5Aoj3T6xLWGYB/5YaqyuXzZM3d6mP/G+rYuxx3fIuJwImXl02AzuGJu OxvlMuABQU70pif/ST632ajDBh3KWu1bg/VaF0YleDG266aQyToXiLR0Kj1o5Gda1a/+ Wk3txJ4WHHANtPj1C978RKISDMOQpQpu8N0MRv6EBTu/r6LdJJPZhGURQOpBld0T2OLZ WzzICC1DwSddR52moMGuQHXie4nx4zHDLkZrTHptfY8VVlFVL/zumoUW+TCP4Im5DF7w yyRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=+KlP2eHyJmoGOpTygtwLYPIoXnCTIyPzdyNnxsG9omA=; b=PkAMkpfcQx8fZAJGME7Lh4RYErKbgQCFc5TAG7Tdz2Y96k3ctvxxdqMmhVZanCB10e AG1j1TEL2jWf1aBLyASAzTLDTU189/+ner0xaonFvMelB+1sL8ALGi8u8kHhNfryiCKM by33a0DQPxVyRs+lf87VnF7i8HxZ4Y6OxeO+W8Ms5ElYFku5XPpSRDQrfUSC3zh52Ob7 PHU4znO0F3u5XYM3uD7Spi/L/FesJNCbtL9FUij0HuhIqbOD9/hi0fxaKIfTLgifGDCR iY1NKtFqQfT6AC088zpq/yvDEaURVlexbfSvd0WJBufzqrcwFT44xW60qJhHRycXjIC7 cyRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw8-20020a1709066a0800b00787bacce740si9581003ejc.537.2022.11.28.04.04.51; Mon, 28 Nov 2022 04:05:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231726AbiK1MCE (ORCPT + 84 others); Mon, 28 Nov 2022 07:02:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbiK1MAS (ORCPT ); Mon, 28 Nov 2022 07:00:18 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7218118B31 for ; Mon, 28 Nov 2022 04:00:17 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozcnr-0003n1-NO; Mon, 28 Nov 2022 13:00:03 +0100 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ozcnp-000o8M-AM; Mon, 28 Nov 2022 13:00:02 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ozcnn-00GzdB-Op; Mon, 28 Nov 2022 12:59:59 +0100 From: Oleksij Rempel To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Arun.Ramadoss@microchip.com Subject: [PATCH v1 05/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: do not extract ghost entry from empty table Date: Mon, 28 Nov 2022 12:59:37 +0100 Message-Id: <20221128115958.4049431-6-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221128115958.4049431-1-o.rempel@pengutronix.de> References: <20221128115958.4049431-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If the dynamic MAC table is empty, we will still extract one outdated entry. Fix it by using correct bit offset. Signed-off-by: Oleksij Rempel --- drivers/net/dsa/microchip/ksz_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index 7c28dc1edaa1..afb846c18b57 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -399,7 +399,7 @@ static const u32 ksz8863_masks[] = { [STATIC_MAC_TABLE_OVERRIDE] = BIT(20), [STATIC_MAC_TABLE_FWD_PORTS] = GENMASK(18, 16), [DYNAMIC_MAC_TABLE_ENTRIES_H] = GENMASK(1, 0), - [DYNAMIC_MAC_TABLE_MAC_EMPTY] = BIT(7), + [DYNAMIC_MAC_TABLE_MAC_EMPTY] = BIT(2), [DYNAMIC_MAC_TABLE_NOT_READY] = BIT(7), [DYNAMIC_MAC_TABLE_ENTRIES] = GENMASK(31, 24), [DYNAMIC_MAC_TABLE_FID] = GENMASK(19, 16), -- 2.30.2