Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a55e73f7-4daf-6892-34dc-61c6f6581d8e@wolfvision.net>
Date:   Mon, 28 Nov 2022 13:18:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v3 1/3] iio: add struct declarations for iio types
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jakob Hauser <jahau@rocketmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Michael Riesch <michael.riesch@wolfvision.net>
References: <20221125083526.2422900-1-gerald.loacker@wolfvision.net>
 <20221125083526.2422900-2-gerald.loacker@wolfvision.net>
 <Y4CcspD1xkmhmWbh@smile.fi.intel.com> <Y4CgiMd4XQMV4KFV@smile.fi.intel.com>
From:   Gerald Loacker <gerald.loacker@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <Y4CgiMd4XQMV4KFV@smile.fi.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bVFEeXZMREF4ZzdIZnAzNUo2OWdyOGU3c3FOL3YvbmtXZnlrZEp1SVNWUnlV?=
 =?utf-8?B?dEFjOXZZcDc0SndtTytZN1AvRCtJQzdHK0xJdFl3Z2pjL0YyWXkzVjB2dTh4?=
 =?utf-8?B?clIyNU5vZ3F6dk1Ga29VMHU0QXhlSjhDOVh5NXpKaEVqQnQwaGEzSFEycVNw?=
 =?utf-8?B?ZUQ4MkhCY0F0R0hRR25TK2MxWnpUUmFCR3NLSGNRMFRRUEJOSHczS3gyYkgx?=
 =?utf-8?B?VFVpK2ZkQTY4MzZYZEpDSnlkVGthNWx5d0ozRjZ2bldvZTN0aEtuRFdwMStT?=
 =?utf-8?B?c1VzeHh0UUZOdXFaVFYvY0VSR0RMWnJlTXI0a3ZwZ1hwQUwrOENzOGFHREtL?=
 =?utf-8?B?TkY1T1J5eXlOTlBsWk83RXpOcDNldHA2OWdUYTZFcUNEcmtKRnZzTDZLSEdu?=
 =?utf-8?B?ZjhnV2VIY2NjOWpnamdHN3BwN0Rhd2w3bk1reFpZbktUelJjOEdhMmtsMnQ2?=
 =?utf-8?B?UHVHckZKam91NkhLdTZld2x6WFl1eUVJdWFiUFdlZmoycWlsMzhjekt3b2FG?=
 =?utf-8?B?ekR0ay82V3BFR2FISEFOZ0cvaC8weGdFc3NrOW1XclJpL0ptR0hLdXlNOExt?=
 =?utf-8?B?K0tTd203M2JLUUxJcmZweXZqcDBwdjVrTFNFdTBiR0cwa3dMUXZ3L2ZlOEZO?=
 =?utf-8?B?ZnVCWk5LclowSk9aRk5pK0d5b0JHVExBUGVEcEE4ZjJkZTJVd0lKdVZVS0x4?=
 =?utf-8?B?SWZNYWF0M0tqbE1hWm8wbTZPQlg4LzNOcHBtWHptcmowUktGZjRmOGYzcWli?=
 =?utf-8?B?TTFjR1BoQnZJcVRkNldDMUVzS2JQbHpmOUZhNEFFTlJaenpTQU5aWlJpUFpG?=
 =?utf-8?B?djJlUjZXYzIvQ2UvZlpOYmtPcTZxZ1h3M2gwSmRxZjJUYi8rSy9IRzlNOGlh?=
 =?utf-8?B?K2hJdnNpeWNlMVM4QUYyRzQ3MlpMUlRrcVFzYjA0S3dOMldxbVFOMzczT1lk?=
 =?utf-8?B?RHdraEhseEtnc3FqakdISWpLMFRmQjZDQWRyYmMvajFUS1d4ZHpvWXpiQlRu?=
 =?utf-8?B?KzFmOUZ6MUtxL0NNYVAxTG1PdmU0bEF6K251THVwMk1tSDFKa1ZlKzROWnkw?=
 =?utf-8?B?TkUycVl5NWdOTTZ4RGkveW5lVjZGWXBPT09pc2M2aUFrZzBNeGFHV3cyMzIz?=
 =?utf-8?B?UUdQN1IrM3RhYS9EWXE5ZlNsSEtYNDBVQzM2SGswR2ZyNjMwUmxIN3dPRWUw?=
 =?utf-8?B?MG1hVDQwbWF2RXZEVHZTVjQyWEoxbzhCNmVLZEVHRmIxcEpvbkpjUVBFS0Z6?=
 =?utf-8?B?TnpvZFE2Z1R5bXlyRVVTcWgrQjV4SzVENzdDSzI3TDZKRXNXT3pHQklpOGFL?=
 =?utf-8?B?TjhsTWRIUWxtVjkxVFhHMHY3YzlTNC85aE4zWEQ3aWpxaTk3bFpudTlpQWFW?=
 =?utf-8?B?MVVmQWNSbFBpcmordHhtNzRWbUZ0eXVOZnBZU29DUWRwZGJRdUZJVG5tK3ll?=
 =?utf-8?B?V0c0ZEs5YVJyUzZFUStPVUw1dDJXU3JQWnF4U09NQnJySFpUWTJMOGl4bllC?=
 =?utf-8?B?WWNISXI0Qis5b1ArQjRMY0tXeTF5VXV2ajVuZmpYQ1lXbXh3eU1ObFI1bFVq?=
 =?utf-8?B?VUFtbTRwOWYwdDVYY3prUFBMUkM3cWYzOFRsMk1MNW5GQ1JwSis5TzdRNFVk?=
 =?utf-8?B?dmRMcUZDdkZQZm1KVXdTMEkrT2gyekl4WWI2aHEzYmZaUUF1UGk5Vjlhc0FH?=
 =?utf-8?B?MUNnYzBvWGZ4UitkRVVFZDVabDlDTTRPWCtFaDdqS0EveVdiQlpkdGxNUkRq?=
 =?utf-8?B?YVpyRkVKaWVERW44bzJudmRjRjFqSXN3dDBQSFdKSVN0dHcyMU9mdUZUSVdt?=
 =?utf-8?B?NWE0UHY5R2FRRHVjUDR6dEsxMEtQN3B5SzFCVklYS21Ed0ZDZzJmbHF5TEtl?=
 =?utf-8?B?a3VrRU9hYVFqc0lYbzl5ZEl4Z2dIZVpNUjF4UWFOZVZZYmN1V3lEczNNVGIv?=
 =?utf-8?B?N2NjL2swaUxaaDh0V2I3K09BenFoRko4V1IzR0FlRnFBVTU3VzdZeUF5RUlM?=
 =?utf-8?B?cXVrSkowNFlFem9UU2NaSnBsakxLbUlmMmpyQ0l1Vk4yTTY5UmY2cVloVEo5?=
 =?utf-8?B?UHp6cGFxSUlVdWlBcDNXR0IycXZsOXZmNUVjYytyL0hZMHhDYjI5KzNQeWl1?=
 =?utf-8?B?RUFndGxsMkliMEFkTmxCMGVqRE5JanpodWdyMnZ6MC9TTXQ1SENVcWN6S0J0?=
 =?utf-8?B?b3c9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 07f3e9de-9d4c-4de6-8a0c-08dad13a9b95
X-MS-Exchange-CrossTenant-AuthSource: VI1PR08MB4544.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 12:18:07.6642
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WQy68KG/M3PgRsOxIY44J9ri8pAhShiXs63qdSLwIxnVTkyXw5uZ7h2+P2JY9VPAXIVrARc40O4Ebbx6tneg2INigvs9zxdzJhxnqSmyZ7Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR08MB10064
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 25.11.2022 um 12:01 schrieb Andy Shevchenko:
> On Fri, Nov 25, 2022 at 12:45:06PM +0200, Andy Shevchenko wrote:
>> On Fri, Nov 25, 2022 at 09:35:24AM +0100, Gerald Loacker wrote:
> 
> ...
> 
>>> +struct iio_val_int_plus_micro {
>>> +	int val_int;
>>> +	int val_micro;
>>> +};
> 
> Thinking more about naming, why not drop val_ completely?
> 
> 	int integer;
> 	int micro;
> 
> ?
> 

Yes, this sounds good to me. I think of adding only

	typedef struct {
		int integer;
		int micro;
	} iio_val_int_plus_micro;

for now, and one can add similar structures when needed, like

	typedef struct {
		int integer;
		int nano;
	} iio_val_int_plus_nano;

or
	
	typedef iio_val_int_plus_micro iio_val_int_plus_micro_db;

If you think it's better to add them all, I can do that, of course.

>>> +struct iio_val_int_plus_nano {
>>> +	int val_int;
>>> +	int val_nano;
>>> +};
>>> +
>>> +struct iio_val_int_plus_micro_db {
>>> +	int val_int;
>>
>> 	int val_int_db; ?
>>
>>> +	int val_micro_db;
>>> +};
>>
>> Actually why can't we simply do
>>
>> typedef iio_val_int_plus_micro_db iio_val_int_plus_micro;
>>
>> ?
>