Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 09:43:35 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Hector Martin <marcan@marcan.st>,
        Sven Peter <sven@svenpeter.dev>,
        Rob Clark <robdclark@gmail.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Yong Wu <yong.wu@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Heiko Stuebner <heiko@sntech.de>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Chunyan Zhang <zhang.lyra@gmail.com>,
        Chen-Yu Tsai <wens@csie.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 02/20] iommu/apple-dart: Remove detach_dev callback
Message-ID: <Y4S7B5caPxWYB1XI@nvidia.com>
References: <20221128064648.1934720-1-baolu.lu@linux.intel.com>
 <20221128064648.1934720-3-baolu.lu@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221128064648.1934720-3-baolu.lu@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rhsKVPxkcYfzvuYNVHHTazG/T+P90NIyAjzGLs2TaaT8siMgUKrGsITkRf2P?=
 =?us-ascii?Q?QdBuXKTfthHjD8oINv+KfOvpGiWtaLG03nXwKE28RCuxtfMpnnlbXyPoUsPN?=
 =?us-ascii?Q?0VV8GNSJ3ngPkajZ2dcF6YdRHikxcUHKtsSnL+0SIxk8jUmxfY7l+pP7+yu2?=
 =?us-ascii?Q?quIs5+923mmn5pxB1+ISvc0a6QJ69rlj0KcZ4yMfLeEe0Bh+66QzRl//Pq4h?=
 =?us-ascii?Q?PqxkEWBpok6f3GJXOvgmpR+Kly2EyjKBXhpCsaR2ot+h/iDZ4OGaT3tsP7Jl?=
 =?us-ascii?Q?FH2R/Lwx+2aTfeFI/S6peemKS+MESc+7KFpdEDYJZSaumWyyxOGjkrKbVAOW?=
 =?us-ascii?Q?ZxPnKThr+GEWNoQYk0C0SSBbXxcadbbWgdADxi6uR8MBsbd06icc+nNPrx8A?=
 =?us-ascii?Q?AsDzmaKH/Rm6pSMRQsCK4YynPhGC30GjLQ0/YfGgiKOjv1gbbVsttFxZkljG?=
 =?us-ascii?Q?oXnAXIcPiS2+WQHlsQtsNFZ4fxHpIQ0GqfcqTDfNIH3w96+2AJbhDlIP1UL6?=
 =?us-ascii?Q?ROYgVHe7zH3xzTsOQ28jCW4tBoAPDZGfRWK6yIRWe2iD4JDHha74e7DGOmn4?=
 =?us-ascii?Q?v2qYcKUGoAZyZCD89ui7bS80GF/id7iQcvOPeHxGBGCETOQUSEWcWid48e7Y?=
 =?us-ascii?Q?LVWPcx3TWmkPlbWl4xiaorJbXu4rJA+iL/O7vHAFdjqQRGSe1GXfybVXQbba?=
 =?us-ascii?Q?B9QtftQeAVeMBkQ2JEm42QXHfhVtkIGwHAfDQBlzWOa0gmHU2KUw3T61xhb/?=
 =?us-ascii?Q?rPQC+MrqwcG2/UgE9VYS4a5Ep231l2P5VySmMEqiXf5O3VTDaIWVQAhzACfB?=
 =?us-ascii?Q?JfpYp3hxk65zlNftku/csqKEIOX750W1LfMpfFZF5TVfZgg58G7x+huVM5tS?=
 =?us-ascii?Q?hntZ5tRc8iCnqXBnHUDFhf4ml31zf1ZoZRq0PCzdi4mGdSqmnp8y5nymh0+V?=
 =?us-ascii?Q?S5wbSGDkKgrVOBaUCsQBi+jjzD8Sqe3KcFK+moKTiTm0y76gK1eCIJ/ULydY?=
 =?us-ascii?Q?oMHohCnoRGgisEPsDNA9ZHYP+tpgpAwC2PP1RTIk9g+5uFo+y8ckQamBfGNf?=
 =?us-ascii?Q?nR0PHEHSehVmMV4naHWW+9YlAicfvLHETEsFx4xPZFQyFjrXxKlt2zXsTOmB?=
 =?us-ascii?Q?e+OYdePemHnZjUw895tSkmyskpz2uSyUZh6KorB3zdHyQZs82mNhLrqfHszW?=
 =?us-ascii?Q?oEpiWt6qXWCS5QxCl9wfO7K9frADn/35mWXplbsUlUUexrHWQ21v56nOch+4?=
 =?us-ascii?Q?CxdUs1y57P5zPPp3Ankp96dQjHOGvsQQ4zUEGkV8PaXU3qr0/ySajQjU/8gT?=
 =?us-ascii?Q?2OyVG7mzL9jjrcOccBuGzG1pXgpr46bTGsLg5nTAjna3/xlCGn6RvOyPv5L+?=
 =?us-ascii?Q?dnXHeQ5IGlx2tsSgC2BtoBn5SVxx8zMw0Of9Lo/MweKpNNuLkJjcMDWKhgBJ?=
 =?us-ascii?Q?sAZ5ubz2f6rhFLAt2Oo//s8sCfhYCtrWb+0zHNXw/WldzWvbTUT6+0nft3vs?=
 =?us-ascii?Q?j+FMulxNlvFkjC9nvk7RwFNMjWg+aJe9eJs5cTUHPjfJKwGc8cPjIwXCTZVq?=
 =?us-ascii?Q?LeG/iTPn7BzKR3WFahE=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cce75374-f593-4990-49f1-08dad1468c86
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 13:43:36.2966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TH5vl+jrxjg8/zjgTO8zNhwu+cNNT5RWamYa6yadw4Ocj1kiiR5WiMm185nLYZUR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6882
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 28, 2022 at 02:46:30PM +0800, Lu Baolu wrote:
> The IOMMU driver supports default domain, so the detach_dev op will never
> be called. Remove it to avoid dead code.
> 
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/iommu/apple-dart.c | 17 -----------------
>  1 file changed, 17 deletions(-)

I suspect this is doing the blocking domain behavior..

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason