Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 09:39:01 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Longfang Liu <liulongfang@huawei.com>
Cc:     alex.williamson@redhat.com, shameerali.kolothum.thodi@huawei.com,
        john.garry@huawei.com, cohuck@redhat.com,
        linux-kernel@vger.kernel.org, linuxarm@openeuler.org
Subject: Re: [PATCH v3 1/5] vfio/migration: Add debugfs to live migration
 driver
Message-ID: <Y4S59c2dWqdrdUlg@nvidia.com>
References: <20221128031200.11017-1-liulongfang@huawei.com>
 <20221128031200.11017-2-liulongfang@huawei.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221128031200.11017-2-liulongfang@huawei.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C3/uTHlcrABLT61c37VJqJLLJub8qSSYVF+LRMLO7pECtiPa0U2Jkf7do+6A?=
 =?us-ascii?Q?tmyZWtZhygSWpIreKb+gblpFElTjJSoxmz5dJeNGZKgx25hY4rhBYnmfsQjt?=
 =?us-ascii?Q?q7P+/78fy50ta5G2TiekEob9eJ9kGwjjps7XQY8kkudPoEFSpxpZMfts5/5e?=
 =?us-ascii?Q?plaZhMTFlOX9otrCADMF0zp/hPF0FgB8i9dlm/Ed1wS1wbWs4VtlgBg08EPc?=
 =?us-ascii?Q?6mOu5Hwjg24fyO3K2Wo5nt0oXoo3kaw+vhqccyC+VJqXfm2d+rBoARuocuFX?=
 =?us-ascii?Q?1clMhKbN77Y5mLF3r0II89bjI+dwsr2JnqxbZ97qsP9nmt7qmvMnegipR6yF?=
 =?us-ascii?Q?+ej0jrylN7zDJKbm25jCTBln+g5IhXE5Q52ue5BzyuVQQPymfOzL8cmb0aQo?=
 =?us-ascii?Q?GKoGU5XEXUb41gduAbrFjLug9GF/DVz+4oJv34v88MvMAXxoCKQReKmEUSQb?=
 =?us-ascii?Q?lvKnsq2HMtUd7V/C4KiEBkQpC5hL9iMQVkmg3oQ3rpQLPNZOxFKdBa5ygN+K?=
 =?us-ascii?Q?geRz820907KoSX0w39eAZrO73JGP+p2ugICANXBssc0uhdcA0748BRNcjQ1Q?=
 =?us-ascii?Q?2WtX28M8Z6Ci7kcQOj9j8UhSmYMaGAlSgJU0bt6SzAnTBz73D7swxonfdJ4x?=
 =?us-ascii?Q?qHHE7f8pKznZ5zTeQJ4tcx4SDf+30ofnlIXUXXrZ3LEkewfYI0ZfzfVirk5h?=
 =?us-ascii?Q?zYDh1vWXFoNHXVYqbB+7cPVN9aiovxvm4Tkk36QzskVr8jjeZPQMfe4JmKs4?=
 =?us-ascii?Q?+Valqh5qvG3e8l5QWU0eUFHOTa9avESUK+sXHB9rDCLWvz9C+gw277Ta537y?=
 =?us-ascii?Q?k4CO07A2ektCRWE2ANApL60dfTNdiN9V1a3UsFFcNAfJusMakqY5+rsnYCKM?=
 =?us-ascii?Q?RJAJXHABmm4OJmt3lqNl9QGH2Iafh4ci0y4DefAY0EYfNGsaBISzJkz46+y9?=
 =?us-ascii?Q?KhZeADddNCumxpGo877dwXkBUtgisg3RFPpojntoLGOmCLuA4MPS1Zh3u5SD?=
 =?us-ascii?Q?17X3zvKJCi1wGVXi3Wt+Jw299gvEHl40Pkb93uZrjzbwYkD2Xh2PlZRSTJ45?=
 =?us-ascii?Q?CfqMcEGyITVZH60p8nZcBNP9MjXnGrRQRKyg/vP59gsP9EdAUZV38weq6kiA?=
 =?us-ascii?Q?y8fEJsRK1pGL5hPREatXJLCtezEoXKhl57leRUWzDpaoo4x4ETwBi9d+ibof?=
 =?us-ascii?Q?ohbJuyZ797dLLYPt+TQd8JDGw+3fSx/uxV3g/hM4ChI7OOtK/qy/2DBySXvf?=
 =?us-ascii?Q?4LWqOizmgVa3rM/iUIwx+UXrbTAh2C1E+8ihEh0li2K5nPvENS0cgwEqBt8V?=
 =?us-ascii?Q?foAhNT0GljPuSy+OZDZn+gWDr1sEHv7zl5fcvT3mxzI/fQcWoChACecCTPg0?=
 =?us-ascii?Q?UyiHNKW1hiYHoR0NHsQaFaVHxbRFzzkczvczoHHn4kpE1o3cD13Y+G8jYLR+?=
 =?us-ascii?Q?YeApq5qHQG4ZnNC8oT8FgDHeR18/1mqmdhbqls/xn0mE9tP8+Rn5PgVCaKbz?=
 =?us-ascii?Q?HPNSIVfrPxgc4TSxB3+sTmn067jXoEjL8jLtUyA0ZhQ8/ufFRspbX+TPLuDq?=
 =?us-ascii?Q?/hgT8UTnYUwocr8YQ6U=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f51c273-7986-4a48-0c1e-08dad145e937
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 13:39:02.2943
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +rb82RLMIo0WqL5HKqC4+/QU2DsBF8AO/fM4UtVelvgSzCmfQgvCdxJ3FDV5H1Au
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5708
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 28, 2022 at 11:11:56AM +0800, Longfang Liu wrote:

> @@ -119,6 +132,9 @@ struct vfio_migration_ops {
>  				   enum vfio_device_mig_state *curr_state);
>  	int (*migration_get_data_size)(struct vfio_device *device,
>  				       unsigned long *stop_copy_length);
> +	int (*migration_get_data)(struct vfio_device *device, char *buffer);
> +	int (*migration_get_attr)(struct vfio_device *device, char *buffer);
> +	int (*migration_debug_operate)(struct vfio_device *device,
>  				   unsigned int cmd);

Please don't do wrappers like this, give the variant driver a chance
to create its own files natively under the debugfs directory

Jason