Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp14901197rwb; Mon, 28 Nov 2022 06:09:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Es5HHEdGnqI8DNCE0+Pd2k5OK7NKbeLnelrtJfQtTqDQN9COl+GFNQDowofZ8ImB7YeDb X-Received: by 2002:a02:cb96:0:b0:363:9f1c:e5 with SMTP id u22-20020a02cb96000000b003639f1c00e5mr16894097jap.187.1669644568320; Mon, 28 Nov 2022 06:09:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669644568; cv=none; d=google.com; s=arc-20160816; b=mVYi04Ur9+AF0Miw4NvtfuR9dRy5ahZxPNZszGzEIqTKjXT1FnOMsQ2xX4IB6rVTWs BFUhqWBj+mNlaVJYQfXxulay/BRps011WSlnrNf1k6dd2OfjYFsbpziaHe56nz5G7xz6 ODq3wHU15R5fUEArgXFR1/Kaj4AOyL//r0q0lvCkFHd+gdceOfQHn7UM3rCs6oJvk/nx r7h+j9j457ZexgirfECP5MmZ5LnbcTzK2sbsMzb93j0Rp4Jsrtsk+edaW6CXSJE+HFY7 TnrJPbnYK+7Nk1Utkc9kI7mqxwNI/1jsNCB4P4vXACH9O7b5OJKUooS7s7mVELALU93Z hAFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature; bh=ipsGjAePSRWQXHePTdUHAIDQwEp3fqNPEG6d13olGuU=; b=nvf8ljzNp6y/gWOolm+6uvUTWOKmsDZ0BnN5fuNNgW+dbQHVtcCiaBhXHp0bJExkIV HKT/zbuGFbP4zlSOJJ0pL5KEt59LXMCBcicSWy+4h6IsEl0Yx407FQAFi8scYaXxOYE3 yhlleFGUdMhSGS3L6MA+7dgHtyM77HcyYzUXL3m9BHD8iGqFzKUstld93GiK+RK/lpmh bjLQxsgRQdyrWu2cqCfD3CPlgVWuE4JiPOfedz+GxXE8C1MMH1pTodhiYH+ElN9Irj5c ylnQW+Q/YmEa4T1jA8XIsO93kqECqZgj9j7/xIwn8vVjr2z60+iYX8YVMq0jVDseoCdz mwhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Ez8FpgEM; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a1709063e5200b0077f92be81adsi8222743eji.212.2022.11.28.06.08.43; Mon, 28 Nov 2022 06:09:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Ez8FpgEM; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232210AbiK1NyT (ORCPT + 84 others); Mon, 28 Nov 2022 08:54:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232083AbiK1NyP (ORCPT ); Mon, 28 Nov 2022 08:54:15 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D415DCF for ; Mon, 28 Nov 2022 05:54:15 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C99761F891; Mon, 28 Nov 2022 13:54:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1669643653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ipsGjAePSRWQXHePTdUHAIDQwEp3fqNPEG6d13olGuU=; b=Ez8FpgEMmZydvO7wPLGZWGYJeNVle+MHyzILf5gQ/KAn6ar+vf1LMZ6H8fTBUo+hBSbV6/ zBXoOCFjU+nXZTeHVqfnQvNETiPG9Ok2joCO86Bet+8FAxrG9UzvmTGvRMV7wLlzz1phLc FrjhnE7EBqJ83YgSfgO86g7a14gXxDA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1669643653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ipsGjAePSRWQXHePTdUHAIDQwEp3fqNPEG6d13olGuU=; b=TxkGB6Dy1k+Sv/wrLAy+xPkU8vBC16BDJeNNLyUyvZG7AhKs+e369wlvpxNIXUPq150sIU g2Egsk7ln+M07XAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id AAA0F1326E; Mon, 28 Nov 2022 13:54:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EEtTKIW9hGNrFAAAMHmgww (envelope-from ); Mon, 28 Nov 2022 13:54:13 +0000 Date: Mon, 28 Nov 2022 14:54:13 +0100 Message-ID: <87k03fyyka.wl-tiwai@suse.de> From: Takashi Iwai To: Liu Shixin Cc: Jaroslav Kysela , Takashi Iwai , , Subject: Re: [PATCH] ALSA: asihpi: fix missing pci_disable_device() In-Reply-To: <20221126021429.3029562-1-liushixin2@huawei.com> References: <20221126021429.3029562-1-liushixin2@huawei.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Nov 2022 03:14:29 +0100, Liu Shixin wrote: > > pci_disable_device() need be called while module exiting, switch to use > pcim_enable(), pci_disable_device() will be called in pcim_release(). > > Fixes: 3285ea10e9b0 ("ALSA: asihpi - Interrelated HPI tidy up.") > Signed-off-by: Liu Shixin Thanks, applied now. Takashi