Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp14957836rwb; Mon, 28 Nov 2022 06:39:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf4G6ByWwFn/Awl2ppIIS12qkyLA+UVgWuxON4GzeLeVFKD3xTc8se/3iCstpVIdXMVdeRVL X-Received: by 2002:a17:907:9057:b0:7bf:2ce6:464 with SMTP id az23-20020a170907905700b007bf2ce60464mr6068086ejc.134.1669646379298; Mon, 28 Nov 2022 06:39:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669646379; cv=none; d=google.com; s=arc-20160816; b=dR/U+lKUZi90xM+e5cFhNgs9kBfrX95dHkDJSOBLFzuJunzsFpxitXsGx+sF0gf8bu 9zyKFEicIcTErqjw5wMbLvctlinOPWgwBKWnWXe6Bbfe6PLYZKndFTPe1dhL/TUr5IfP qtHIY2jXpiO+ConDLQQEVlF4rPTthjQf3uTY1erKtz1/WLrxo6WKmioi11J00ro/nnU9 QCYb7e/vBHmx5K10KpUMM6iP8I26rGWGbHTVqL6Zb/FNB0iJp/6dNtI36jsvh48TLWIw jp4cWSKNkKskvQO0237dx+r7qsurbGUrK+483xMh7AcDeWD5fObWQjf8DwmuZLzgw/R3 VFPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WWmFj/9cF+HmXZjr0kU3LqilZyGi9MnyIj7WZAVw4nI=; b=eWmAZQqTPPxIl0IUwbpFBnN4bhyEf4AI+1PqGfF4g8IsnEmalybriFfTX2xeFOxIqT /O/z4adRTXconHkDC2PjSqpSZEX5uOEGsDY5ghChrv/F+pOcPYL+AtGvnr2TQMz9Dcm9 iwSVM4vrmEzui1Y4FdNU2Yo269fPiklWapBYJ81hPwHmBaU1TLzt2UGh0Paf6HlhHqYq Zju/k078dLkY/khGWDEu0gwPqIlDB12xrRKhrKNpJnZYEEWSbzyRtMQnv2Y/95KSTkSR 4TxkvhhTyK6xrSmozLweOVIVSzwNkgV0aorAiP+MOJ8H9O9buPXizxbZeB3dEfzT13nH T0OQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="hZmVM/DS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id he39-20020a1709073da700b007309a570223si8964616ejc.609.2022.11.28.06.39.17; Mon, 28 Nov 2022 06:39:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="hZmVM/DS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231934AbiK1N3w (ORCPT + 84 others); Mon, 28 Nov 2022 08:29:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231932AbiK1N3o (ORCPT ); Mon, 28 Nov 2022 08:29:44 -0500 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57E391DDC2; Mon, 28 Nov 2022 05:29:41 -0800 (PST) Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASD9qCe027048; Mon, 28 Nov 2022 13:29:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=WWmFj/9cF+HmXZjr0kU3LqilZyGi9MnyIj7WZAVw4nI=; b=hZmVM/DSD6fq3juetUoprzIwblztUbyHiDeXbW6rjXyzRY8eAnIcvQBlqA9rU92CcSWl 33/dOYOmvuSsJHbq4rQXd0SsscseyErOuqoPWvmY6nskUv3mI8uCmd0vRlT0k4kM5MA2 a56IUKAj+5lSttBr/TUUZFhODR1kN837QEDYtLPjBLT1TvLlq1vdRUIkzL8i9PZEsNWc XLdXCk/Zu6TfYf+eISulwJVH6fB9qdzrAHYkIacAZbWblhNJHniSCUlM8K2hOZCVItZZ NpgQR9M0/FtReDU7422bOcgVvu2h05HDd3i7oYbNLElTTKOf2vkPVlFOt4ravpVHdYsr cg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m3c3f4exc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 13:29:34 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ASDTYSe023311 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 13:29:34 GMT Received: from sarannya-linux.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 28 Nov 2022 05:29:30 -0800 From: Sarannya S To: , , , , CC: , , , Sarannya S , Deepak Kumar Singh , Bjorn Andersson Subject: [PATCH V4 3/3] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Date: Mon, 28 Nov 2022 18:58:11 +0530 Message-ID: <1669642093-20399-3-git-send-email-quic_sarannya@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1669642093-20399-1-git-send-email-quic_sarannya@quicinc.com> References: <1669642093-20399-1-git-send-email-quic_sarannya@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: vzBiDt_5YgIzVYIxFUkjw_ZmqBH8LD3w X-Proofpoint-ORIG-GUID: vzBiDt_5YgIzVYIxFUkjw_ZmqBH8LD3w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_11,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280103 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Sarannya S --- drivers/rpmsg/rpmsg_char.c | 60 +++++++++++++++++++++++++++++++++++++++------- 1 file changed, 52 insertions(+), 8 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 3e0b8f3..d44c8a6 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -68,6 +69,8 @@ struct rpmsg_eptdev { struct sk_buff_head queue; wait_queue_head_t readq; + u32 remote_signals; + bool signals_pending; }; int rpmsg_chrdev_eptdev_destroy(struct device *dev, void *data) @@ -109,7 +112,22 @@ static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len, skb_queue_tail(&eptdev->queue, skb); spin_unlock(&eptdev->queue_lock); - /* wake up any blocking processes, waiting for new data */ + wake_up_interruptible(&eptdev->readq); + + return 0; +} + +static int rpmsg_ept_flow_cb(struct rpmsg_device *rpdev, void *priv, bool enable) +{ + struct rpmsg_eptdev *eptdev = priv; + + if (enable) + eptdev->remote_signals = TIOCM_DSR | TIOCM_CTS; + else + eptdev->remote_signals = 0; + + eptdev->signals_pending = true; + wake_up_interruptible(&eptdev->readq); return 0; @@ -146,6 +164,7 @@ static int rpmsg_eptdev_open(struct inode *inode, struct file *filp) return -EINVAL; } + ept->flow_cb = rpmsg_ept_flow_cb; eptdev->ept = ept; filp->private_data = eptdev; mutex_unlock(&eptdev->ept_lock); @@ -166,6 +185,7 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp) eptdev->ept = NULL; } mutex_unlock(&eptdev->ept_lock); + eptdev->signals_pending = false; /* Discard all SKBs */ skb_queue_purge(&eptdev->queue); @@ -279,6 +299,9 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait) if (!skb_queue_empty(&eptdev->queue)) mask |= EPOLLIN | EPOLLRDNORM; + if (eptdev->signals_pending) + mask |= EPOLLPRI; + mask |= rpmsg_poll(eptdev->ept, filp, wait); return mask; @@ -289,14 +312,35 @@ static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, { struct rpmsg_eptdev *eptdev = fp->private_data; - if (cmd != RPMSG_DESTROY_EPT_IOCTL) - return -EINVAL; - - /* Don't allow to destroy a default endpoint. */ - if (eptdev->default_ept) - return -EINVAL; + bool set; + u32 val; + int ret; + + switch (cmd) { + case TIOCMGET: + eptdev->signals_pending = false; + ret = put_user(eptdev->remote_signals, (int __user *)arg); + break; + case TIOCMSET: + ret = get_user(val, (int __user *)arg); + if (ret) + break; + set = (val & (TIOCM_DTR | TIOCM_RTS)) ? true : false; + ret = rpmsg_set_flow_control(eptdev->ept, set); + break; + case RPMSG_DESTROY_EPT_IOCTL: + /* Don't allow to destroy a default endpoint. */ + if (eptdev->default_ept) { + ret = -EINVAL; + break; + } + ret = rpmsg_chrdev_eptdev_destroy(&eptdev->dev, NULL); + break; + default: + ret = -EINVAL; + } - return rpmsg_chrdev_eptdev_destroy(&eptdev->dev, NULL); + return ret; } static const struct file_operations rpmsg_eptdev_fops = { -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project