Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220923100149.2647325-1-suagrfillet@gmail.com>
 <CAAYs2=hx49ahtY3pe1z241Vd1mRNZjc-oigubmKy0aGqg6T8ag@mail.gmail.com> <CAJF2gTRfWXZEbAjWQ0vPA8HWihkibPQ2Mb9hvYgQg+DdEFrZTA@mail.gmail.com>
In-Reply-To: <CAJF2gTRfWXZEbAjWQ0vPA8HWihkibPQ2Mb9hvYgQg+DdEFrZTA@mail.gmail.com>
From:   Song Shuai <suagrfillet@gmail.com>
Date:   Mon, 28 Nov 2022 22:12:02 +0800
Message-ID: <CAAYs2=j3Eak9vU6xbAw0zPuoh00rh8v5C2U3fePkokZFibWs2g@mail.gmail.com>
Subject: Re: [PATCH RESEND] riscv : select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY
To:     Guo Ren <guoren@kernel.org>
Cc:     paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, guoren@linux.alibaba.com,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Guo Ren <guoren@kernel.org> =E4=BA=8E2022=E5=B9=B411=E6=9C=8828=E6=97=A5=E5=
=91=A8=E4=B8=80 21:47=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, Nov 22, 2022 at 6:11 PM Song Shuai <suagrfillet@gmail.com> wrote:
> >
> > Song Shuai <suagrfillet@gmail.com> =E4=BA=8E2022=E5=B9=B49=E6=9C=8823=
=E6=97=A5=E5=91=A8=E4=BA=94 10:03=E5=86=99=E9=81=93=EF=BC=9A
> > >
> > > riscv now uses -fpatchable-function-entry with dynamic ftrace after
> > > the `afc76b8b8` commit, which means recordmcount shouldn't be called
> The ref commit format needs to be corrected. Others:
> Tested-by: Guo Ren <guoren@kernel.org>
>
Thanks for your test.
I'll correct this ref in the next version.
> > > to create the __mcount_loc section before the vmlinux linking.
> > >
> > > We should select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY to tell
> > > Makefile not to run recordmcount.
> > >
> > Hi,Guo:
> >
> > Can this patch squeeze into your v3 series ?
> They don't have a dependency, and it's unnecessary. A single patch is
> easy for the maintainer to pick up.
>
Got it.
> >
> > Thanks,
> > Song
> > > Signed-off-by: Song Shuai <suagrfillet@gmail.com>
> > > ---
> > >  arch/riscv/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > > index c22f58155948..25db8cea876a 100644
> > > --- a/arch/riscv/Kconfig
> > > +++ b/arch/riscv/Kconfig
> > > @@ -246,6 +246,7 @@ config ARCH_RV64I
> > >         select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-opti=
on,-fpatchable-function-entry=3D8)
> > >         select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
> > >         select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL
> > > +       select FTRACE_MCOUNT_USE_PATCHABLE_FUNCTION_ENTRY if DYNAMIC_=
FTRACE
> > >         select HAVE_FUNCTION_GRAPH_TRACER
> > >         select HAVE_FUNCTION_TRACER if !XIP_KERNEL
> > >         select SWIOTLB if MMU
> > > --
> > > 2.20.1
> > >
>
>
>
> --
> Best Regards
>  Guo Ren


--=20
Thanks,
Song