Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 15:41:37 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Thierry Reding <thierry.reding@gmail.com>, od@opendingux.net,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mips@vger.kernel.org
Subject: Re: [PATCH 3/5] pwm: jz4740: Force dependency on Device Tree
Message-ID: <20221128144137.aavwwb3oxz5hw4ae@pengutronix.de>
References: <20221024205213.327001-1-paul@crapouillou.net>
 <20221024205213.327001-4-paul@crapouillou.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mgihohoq2ffxir4a"
Content-Disposition: inline
In-Reply-To: <20221024205213.327001-4-paul@crapouillou.net>
Precedence: bulk


--mgihohoq2ffxir4a
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 24, 2022 at 09:52:11PM +0100, Paul Cercueil wrote:
> Ingenic SoCs all require CONFIG_OF, so there is no case where we want to
> use this driver without CONFIG_OF.
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>

> ---
>  drivers/pwm/Kconfig      |  2 +-
>  drivers/pwm/pwm-jz4740.c | 10 ++++------
>  2 files changed, 5 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
> index 60d13a949bc5..1fe420a45f91 100644
> --- a/drivers/pwm/Kconfig
> +++ b/drivers/pwm/Kconfig
> @@ -283,7 +283,7 @@ config PWM_IQS620A
>  config PWM_JZ4740
>  	tristate "Ingenic JZ47xx PWM support"
>  	depends on MIPS || COMPILE_TEST
> -	depends on COMMON_CLK
> +	depends on COMMON_CLK && OF

I think you don't even need to enforce OF here. For the compile-test
case having OF=3Dn should work fine.

Anyhow:

Acked-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--mgihohoq2ffxir4a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmOEyJ4ACgkQwfwUeK3K
7AlxPwf9Gz4JXf2XTZRSbBnXuGgyQt+OyfBEMbRTI/dWN6wERc/buzwXNno15Ue+
wxpdN6FcKgZaAyxJHVm+lLQkzGiVoU79BgZKiwtUjl9k4iPNqzhnd55k3e65JEy9
NMDRIzIEjmfJ1A9mTYRcnRMT5EnQvg/UCIAqBRENb6tskL5Bk8YdC2jQld1B7Se4
DZ1hBSK5Jg5ij7vjDH2Z8mCuMfejS98pTfr9yfMwQKrezKx1JONK/D727v+wBNWW
fdYFdHyOShfcVQNiBiDyGoYDP0aAZmTBlMMwDZEsgH8ELX39QIqdjNONBTJ6Sv+H
lt/skHCvuJW8lZnqYW9wLtjkt1id8w==
=j7d3
-----END PGP SIGNATURE-----

--mgihohoq2ffxir4a--