Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221126012558.34374-1-jiasheng@iscas.ac.cn> <Y4HH5Ch1ABrRzN5/@kadam>
In-Reply-To: <Y4HH5Ch1ABrRzN5/@kadam>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 28 Nov 2022 15:45:21 +0100
Message-ID: <CAPDyKFq+wYbRNtDmhMzU+5_LUXsqyw7O=-1BqhJN_j26HF++AQ@mail.gmail.com>
Subject: Re: [PATCH v2] memstick/ms_block: Add check for alloc_ordered_workqueue
To:     Dan Carpenter <error27@gmail.com>
Cc:     Jiasheng Jiang <jiasheng@iscas.ac.cn>, maximlevitsky@gmail.com,
        oakad@yahoo.com, christophe.jaillet@wanadoo.fr, axboe@kernel.dk,
        hare@suse.de, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, 26 Nov 2022 at 09:01, Dan Carpenter <error27@gmail.com> wrote:
>
> On Sat, Nov 26, 2022 at 09:25:58AM +0800, Jiasheng Jiang wrote:
> > As the alloc_ordered_workqueue may return NULL pointer,
> > it should be better to add check for the return
> > value.
> > Moreover, the msb->io_queue should be freed if error occurs later.
> >
> > Fixes: 0ab30494bc4f ("memstick: add support for legacy memorysticks")
> > Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> > ---
> > Changelog:
> >
> > v1 -> v2:
> >
> > 1. Assign error number to rc if alloc_ordered_workqueue fails.
> > 2. Free msb->io_queue if error occurs later.
> > ---
>
> My other question about this driver, not really directed to you but to
> anyone on the list is where the final destroy_workqueue(msb->io_queue)
> is when we unload the driver.

Good point, it's simply missing somewhere in the path of the
->remove() callback.

Kind regards
Uffe