Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 15:41:58 +0100
From:   Jean Delvare <jdelvare@suse.de>
To:     Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= <uwe@kleine-koenig.org>
Cc:     Angel Iglesias <ang.iglesiasg@gmail.com>,
        Lee Jones <lee.jones@linaro.org>,
        Grant Likely <grant.likely@linaro.org>,
        Wolfram Sang <wsa@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-i2c@vger.kernel.org, kernel@pengutronix.de,
        Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
        <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 487/606] misc: eeprom/eeprom: Convert to i2c's
 .probe_new()
Message-ID: <20221128154158.7a486ae9@endymion.delvare>
In-Reply-To: <20221118224540.619276-488-uwe@kleine-koenig.org>
References: <20221118224540.619276-1-uwe@kleine-koenig.org>
        <20221118224540.619276-488-uwe@kleine-koenig.org>
Organization: SUSE Linux
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, 18 Nov 2022 23:43:41 +0100, Uwe Kleine-K=C3=B6nig wrote:
> From: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
>=20
> The probe function doesn't make use of the i2c_device_id * parameter so it
> can be trivially converted.
>=20
> Signed-off-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/misc/eeprom/eeprom.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/misc/eeprom/eeprom.c b/drivers/misc/eeprom/eeprom.c
> index 8a841a75d893..32611100d5cd 100644
> --- a/drivers/misc/eeprom/eeprom.c
> +++ b/drivers/misc/eeprom/eeprom.c
> @@ -141,8 +141,7 @@ static int eeprom_detect(struct i2c_client *client, s=
truct i2c_board_info *info)
>  	return 0;
>  }
> =20
> -static int eeprom_probe(struct i2c_client *client,
> -			const struct i2c_device_id *id)
> +static int eeprom_probe(struct i2c_client *client)
>  {
>  	struct i2c_adapter *adapter =3D client->adapter;
>  	struct eeprom_data *data;
> @@ -197,7 +196,7 @@ static struct i2c_driver eeprom_driver =3D {
>  	.driver =3D {
>  		.name	=3D "eeprom",
>  	},
> -	.probe		=3D eeprom_probe,
> +	.probe_new	=3D eeprom_probe,
>  	.remove		=3D eeprom_remove,
>  	.id_table	=3D eeprom_id,
> =20

Reviewed-by: Jean Delvare <jdelvare@suse.de>

--=20
Jean Delvare
SUSE L3 Support