Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1a5e57be-ccff-f281-6e06-be5e59db1d05@gmail.com>
Date:   Mon, 28 Nov 2022 20:33:54 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v3 2/2] fscrypt: Add SM4 XTS/CTS symmetric algorithm
 support
Content-Language: en-US
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>,
        Eric Biggers <ebiggers@kernel.org>,
        "Theodore Y. Ts o" <tytso@mit.edu>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
        Ard Biesheuvel <ardb@kernel.org>,
        linux-fscrypt@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20221125121630.87793-1-tianjia.zhang@linux.alibaba.com>
 <20221125121630.87793-3-tianjia.zhang@linux.alibaba.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <20221125121630.87793-3-tianjia.zhang@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/25/22 19:16, Tianjia Zhang wrote:
> SM4 is a symmetric algorithm widely used in China, and is even mandatory
> in many scenarios. We need to provide these users with the ability to
> encrypt files or disks using SM4-XTS, and many other algorithms that use
> SM2/3/4 algorithms or their combined algorithm scenarios, these features
> are demanded by many users, this patch enables to use SM4-XTS mode to
> encrypt file content, and use SM4-CBC-CTS to encrypt filename.
> 

Similar reply as [1]. That is, better say:

```
Add support for XTS and CTS mode variant of SM4 algorithm, in similar
fashion to SM2 and SM3. The former is used to encrypt file contents, while
the latter (SM4-CBC-CTS) is used to encrypt filenames. 
```

Thanks.

[1]: https://lore.kernel.org/linux-doc/42624542-6ccb-26a5-db98-d7944972246e@gmail.com/

-- 
An old man doll... just what I always wanted! - Clara