Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b98429d8-6d18-cf0b-6ca0-d9d6472d21f9@redhat.com>
Date:   Mon, 28 Nov 2022 19:00:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     kirill.shutemov@linux.intel.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, jpoimboe@kernel.org,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
        tglx@linutronix.de, viro@zeniv.linux.org.uk, x86@kernel.org
References: <20221128091506.gp4l6klznqhigjxv@box.shutemov.name>
 <20221128101117.3614401-1-mailhol.vincent@wanadoo.fr>
 <20221128111112.dzavip4eqqgpyrai@box.shutemov.name>
 <CAMZ6RqJ0EgbLcz97ujqEzF1MBsH045W0Cu8mMuR0WCx_cTemCQ@mail.gmail.com>
 <20221128124513.76392c3d@gandalf.local.home>
From:   Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from
 asm-offsets.c
In-Reply-To: <20221128124513.76392c3d@gandalf.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/28/22 18:45, Steven Rostedt wrote:
> 
>>> If you are sure <asm/ftrace.h> is never included from asm-offsets.c,
>>> remove #ifndef COMPILE_OFFSETS too.
>> It is never included from asm-offsets.c but it is still used by
>> kvm-asm-offsets.c:
>> https://elixir.bootlin.com/linux/v6.1-rc7/source/arch/x86/kvm/kvm-asm-offsets.c#L7
> IIRC, the reason for adding that was because that logic was screwing up
> asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
> 
> This is one of those cases I wish I commented that code better :-/

I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.

Paolo