Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15338481rwb; Mon, 28 Nov 2022 10:22:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KuaS/MUj5DrelSrb9WjsP8RY3aHEgCjMLIrmoG+rzQ1lnCciEVjtVc9PDmox53dlaEE7n X-Received: by 2002:a63:195a:0:b0:477:c9d9:f8a0 with SMTP id 26-20020a63195a000000b00477c9d9f8a0mr20853285pgz.228.1669659741318; Mon, 28 Nov 2022 10:22:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669659741; cv=none; d=google.com; s=arc-20160816; b=bUV0kWNuFSM/Zmt9Exdc3RWii6qkyiwEocqQ7ARJeYgp/w+szduq7DK9WMKc3/Ju0s tuL4FRdloaiLIGNBUVrD18NhRZviK3HzqzQdJmUm1iEUTkGLAxVarX/hBWQag8ttjngA W6XEIWhx7aHbRBbtP+0tXGSHfiKrhaw63+jUXLyZiqCZyIIalULcazdQyh+/29N0mfVg sd3WK6lYXKblocsoVtJiDsK+wA+/g0bWIxgeRC3lRfp80oKtNeOzT+JkJbR16rEjq+67 tKTTB7EXBOFxEMGF3/JdUoMfBnjgOPkBxMjigcLzV+dXprKZYkJGJU0T9uYC4Sz+uR0h 1HsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=JoCrBoPXscO6bRuMr0tSk7fHW7Q5d2Ohn3FyUjcekBc=; b=nGeidW9Kgn2wCxTXIRkIxSefoIgdrqejQn7W4OrVDWAZ19OuB8i5dO+wkUiZmEgNkr eiDO/MhsdIJZxjNXcZwMweb2NhMBxOH6VrGU0JTk1T/wxbGYhMnvTcTjQIoS7MDzDS3d Y6f678tys5n4gdZWVrH5GzSdlyMw7e2ImWuNA406CHo0Hfp1aDFW7nrx1tBnMwGNYFJb Acly0z6A+71y0iJ+u1qmFZqHdlocMHtl6VhkonlyeLBg4Ezlt72wqRxQARkvsOKB+oNL g1kwNQFpUeeILMW6N6V3+1mVt4Gx9XhI8RVSpVEepLBx2o64jGWNxi3lMI+tnAR5Hea4 Wfbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iXeiGcdb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j2-20020a63fc02000000b00473c36e3b75si12049899pgi.608.2022.11.28.10.22.10; Mon, 28 Nov 2022 10:22:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=iXeiGcdb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234236AbiK1STr (ORCPT + 84 others); Mon, 28 Nov 2022 13:19:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232198AbiK1STF (ORCPT ); Mon, 28 Nov 2022 13:19:05 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BCB391CD; Mon, 28 Nov 2022 10:03:50 -0800 (PST) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2ASH73ts024224; Mon, 28 Nov 2022 18:03:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=qcppdkim1; bh=JoCrBoPXscO6bRuMr0tSk7fHW7Q5d2Ohn3FyUjcekBc=; b=iXeiGcdbFA5UhqGzrWWr2RDax6zoAnj4N2SAXsqhMiiaC6C5r8WM62oOpjXK0AQw5F6g NM9I72QhEbu6qSIm9nstcRNDMav2IwlXgaiHxxFfjAwOgO2ZH/CiDjC9/T8sMJ6JoEx5 pMNPSpayNj/AMk7CyuopODHUA+Sw8ge4VdTzuFmbM2IBm8U2vvUxBxhGJIEyNGSUQDIA LteSYEBfhc40M42n0h2g311n2MlwO8AolPl72HaOozmnVxHFy7GF6af+rz8a+hw4zDeV us8WvQ++Fo5V+5kPeAnVEsyxtxiTrFTXnH+Uo43Ui9V+Bf5YbOp4YSmbymTPz4T55CnO OQ== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3m513sg4r5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 18:03:41 +0000 Received: from nalasex01b.na.qualcomm.com (nalasex01b.na.qualcomm.com [10.47.209.197]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 2ASI3e5j032332 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 18:03:40 GMT Received: from sarannya-linux.qualcomm.com (10.80.80.8) by nalasex01b.na.qualcomm.com (10.47.209.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 28 Nov 2022 10:03:37 -0800 From: Sarannya S To: , , , , CC: , , , Sarannya S , Deepak Kumar Singh , Bjorn Andersson Subject: [PATCH V4 3/3] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Date: Mon, 28 Nov 2022 23:32:55 +0530 Message-ID: <1669658575-21993-4-git-send-email-quic_sarannya@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1669658575-21993-1-git-send-email-quic_sarannya@quicinc.com> References: <1669658575-21993-1-git-send-email-quic_sarannya@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01b.na.qualcomm.com (10.47.209.197) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: iqqRwg68e63pNdmL6NF7EbAyt92XVWbn X-Proofpoint-ORIG-GUID: iqqRwg68e63pNdmL6NF7EbAyt92XVWbn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-28_15,2022-11-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 mlxlogscore=999 clxscore=1015 phishscore=0 priorityscore=1501 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211280132 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add TICOMGET and TIOCMSET ioctl support for rpmsg char device nodes to get/set the low level transport signals. Signed-off-by: Chris Lew Signed-off-by: Deepak Kumar Singh Signed-off-by: Sarannya S --- drivers/rpmsg/rpmsg_char.c | 60 +++++++++++++++++++++++++++++++++++++++------- 1 file changed, 52 insertions(+), 8 deletions(-) diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c index 3e0b8f3..34822de 100644 --- a/drivers/rpmsg/rpmsg_char.c +++ b/drivers/rpmsg/rpmsg_char.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include @@ -68,6 +69,8 @@ struct rpmsg_eptdev { struct sk_buff_head queue; wait_queue_head_t readq; + u32 remote_signals; + bool signals_pending; }; int rpmsg_chrdev_eptdev_destroy(struct device *dev, void *data) @@ -109,7 +112,22 @@ static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len, skb_queue_tail(&eptdev->queue, skb); spin_unlock(&eptdev->queue_lock); - /* wake up any blocking processes, waiting for new data */ + wake_up_interruptible(&eptdev->readq); + + return 0; +} + +static int rpmsg_ept_flow_cb(struct rpmsg_device *rpdev, void *priv, bool enable) +{ + struct rpmsg_eptdev *eptdev = priv; + + if (enable) + eptdev->remote_signals = TIOCM_DSR | TIOCM_CTS; + else + eptdev->remote_signals = 0; + + eptdev->signals_pending = true; + wake_up_interruptible(&eptdev->readq); return 0; @@ -146,6 +164,7 @@ static int rpmsg_eptdev_open(struct inode *inode, struct file *filp) return -EINVAL; } + ept->flow_cb = rpmsg_ept_flow_cb; eptdev->ept = ept; filp->private_data = eptdev; mutex_unlock(&eptdev->ept_lock); @@ -166,6 +185,7 @@ static int rpmsg_eptdev_release(struct inode *inode, struct file *filp) eptdev->ept = NULL; } mutex_unlock(&eptdev->ept_lock); + eptdev->signals_pending = false; /* Discard all SKBs */ skb_queue_purge(&eptdev->queue); @@ -279,6 +299,9 @@ static __poll_t rpmsg_eptdev_poll(struct file *filp, poll_table *wait) if (!skb_queue_empty(&eptdev->queue)) mask |= EPOLLIN | EPOLLRDNORM; + if (eptdev->signals_pending) + mask |= EPOLLPRI; + mask |= rpmsg_poll(eptdev->ept, filp, wait); return mask; @@ -289,14 +312,35 @@ static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, { struct rpmsg_eptdev *eptdev = fp->private_data; - if (cmd != RPMSG_DESTROY_EPT_IOCTL) - return -EINVAL; - - /* Don't allow to destroy a default endpoint. */ - if (eptdev->default_ept) - return -EINVAL; + bool set; + u32 val; + int ret; + + switch (cmd) { + case TIOCMGET: + eptdev->signals_pending = false; + ret = put_user(eptdev->remote_signals, (int __user *)arg); + break; + case TIOCMSET: + ret = get_user(val, (int __user *)arg); + if (ret) + break; + set = (val & (TIOCM_DTR | TIOCM_RTS)) ? true : false; + ret = rpmsg_set_flow_control(eptdev->ept, set); + break; + case RPMSG_DESTROY_EPT_IOCTL: + /* Don't allow to destroy a default endpoint. */ + if (eptdev->default_ept) { + ret = -EINVAL; + break; + } + ret = rpmsg_chrdev_eptdev_destroy(&eptdev->dev, NULL); + break; + default: + ret = -EINVAL; + } - return rpmsg_chrdev_eptdev_destroy(&eptdev->dev, NULL); + return ret; } static const struct file_operations rpmsg_eptdev_fops = { -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project