Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15355329rwb; Mon, 28 Nov 2022 10:33:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf60060ImEZf3nz0VHTQ4ftu1Qls78mGAQYev5WCYVge28obGweiuiaXaQ/nI/cBqYFxiTL0 X-Received: by 2002:aa7:9243:0:b0:56d:dd2a:f6b6 with SMTP id 3-20020aa79243000000b0056ddd2af6b6mr34523840pfp.30.1669660429936; Mon, 28 Nov 2022 10:33:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669660429; cv=none; d=google.com; s=arc-20160816; b=OYjK5KqiYdIfa2+DoqbpZRnWCOg42ub3LP3g4bHOJIyjrZfN0Fi0o5FwZvquy2fSM9 Kf2MRQzhpda3T0HLKlDqfUb7Hc5EgEmN64+BFaOyaH5FjZIfCMEqNK/2ybujGNcBoeJR 3Dt7e/j2HAWQOJhRko3HTThNzeZOn0js0EUby7JaLbCVMDXBRHI62PbxlArkBz7+1d69 dPKeMALyBYRYWp2zcz+cbNH619lo6nwQ9u5LKWdYELJCBI9CCy17oweaWHWL1cCDXm3A 5lXJXCmXLfYAxnS7IC2eXeNoyd5wielQJjv1u4i4EzhrJStevSc6IE8YISq3AzIZ7Bao KU8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=HGzRHX9Rr+IAdxhJQ9krIOQcSNnQpFin1Dhi+Hgy/AA=; b=KNz2Y3wbuw/DRahETOS8RACt60pPMREYS1zdIgxc4o/qnzGTUfDTCY6dLe16H7Mh6/ S0A6BI9jqlLWbV79zCT7KKdKgwOpztvLI2+E89CbTv9nQYE+tg6dXP+KmXpeYqS8tOf8 OsZHFUhwP3LRuxgwkkPT/sQDaM3V8eSGsZzor9y1hhp2FpXlmEOla7hPdTMla6KN9Wm2 AA4Q5ER6T5daYhf8gm861+pIfcaMf8RgM7VCqX+EK1H1ScMLIJUZz9ox4ZXT4E5Uc+P/ 3KJ8w9I1WMcYzqbBNmZyC052G/DFbpAJFvPk1tRU6Eqx2gq23x2TQWd4Z2UWumGREulk F0rg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t14-20020a63eb0e000000b00477ad8ce6b7si12820333pgh.287.2022.11.28.10.33.36; Mon, 28 Nov 2022 10:33:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231925AbiK1SRX (ORCPT + 84 others); Mon, 28 Nov 2022 13:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234226AbiK1SQz (ORCPT ); Mon, 28 Nov 2022 13:16:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE09121812 for ; Mon, 28 Nov 2022 10:00:43 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9F425B80E81 for ; Mon, 28 Nov 2022 18:00:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE0F9C43151; Mon, 28 Nov 2022 18:00:40 +0000 (UTC) Date: Mon, 28 Nov 2022 13:00:38 -0500 From: Steven Rostedt To: Cc: , Subject: Re: [PATCH linux-next] ring_buffer: remove redundant ret variables Message-ID: <20221128130038.4e038f1b@gandalf.local.home> In-Reply-To: <202211282110006083500@zte.com.cn> References: <202211282110006083500@zte.com.cn> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Nov 2022 21:10:00 +0800 (CST) wrote: > From: zhang songyi > > Return values from ring_buffer_bytes_cpu(), ring_buffer_overrun_cpu(), > ring_buffer_commit_overrun_cpu(), ring_buffer_dropped_events_cpu() > directly instead of taking this in another redundant variable. > > Signed-off-by: zhang songyi > --- Fine, I may add this, as it looks like leftovers from 8aabee573dff ("ring-buffer: remove unneeded get_online_cpus"). But they make no real difference staying as is. -- Steve