Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <54f43e4d-5124-b2c8-c6d4-ce0bf4547eaf@redhat.com>
Date:   Mon, 28 Nov 2022 19:06:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH v3 3/3] mm/khugepaged: Invoke MMU notifiers in shmem/file
 collapse paths
Content-Language: en-US
To:     Jann Horn <jannh@google.com>
Cc:     security@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Yang Shi <shy828301@gmail.com>, Peter Xu <peterx@redhat.com>,
        John Hubbard <jhubbard@nvidia.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
References: <20221125213714.4115729-1-jannh@google.com>
 <20221125213714.4115729-3-jannh@google.com>
 <66cfc9ba-868c-9620-fbfc-38931c76ff50@redhat.com>
 <CAG48ez23WvRRX6LKgCe+sJMYWBKVa+U1fg7G1o0nOobHCEQBGg@mail.gmail.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <CAG48ez23WvRRX6LKgCe+sJMYWBKVa+U1fg7G1o0nOobHCEQBGg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.11.22 18:57, Jann Horn wrote:
> On Mon, Nov 28, 2022 at 6:37 PM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 25.11.22 22:37, Jann Horn wrote:
>>> Any codepath that zaps page table entries must invoke MMU notifiers to
>>> ensure that secondary MMUs (like KVM) don't keep accessing pages which
>>> aren't mapped anymore. Secondary MMUs don't hold their own references to
>>> pages that are mirrored over, so failing to notify them can lead to page
>>> use-after-free.
>>>
>>> I'm marking this as addressing an issue introduced in commit f3f0e1d2150b
>>> ("khugepaged: add support of collapse for tmpfs/shmem pages"), but most of
>>> the security impact of this only came in commit 27e1f8273113 ("khugepaged:
>>> enable collapse pmd for pte-mapped THP"), which actually omitted flushes
>>> for the removal of present PTEs, not just for the removal of empty page
>>> tables.
>>>
>>> Cc: stable@kernel.org
>>> Fixes: f3f0e1d2150b ("khugepaged: add support of collapse for tmpfs/shmem pages")
>>
>> I'm curious, do you have a working reproducer for this?
> 
> You're on the CC list of my bug report to security@kernel.org
> with title "khugepaged races with rmap-based zap, races with GUP-fast,
> and fails to call MMU notifiers". That has an attached reproducer
> thp_ro_no_notify_kvm.c that is able to read PAGE_POISON out of freed
> file THP pages through KVM.
> 

Ah, the mail from early October, thanks (drowning in mail).

You're amazingly skilled at writing reproducers.

-- 
Thanks,

David / dhildenb