Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15361103rwb; Mon, 28 Nov 2022 10:38:12 -0800 (PST) X-Google-Smtp-Source: AA0mqf7EH1A3PsKGmK+6Xs0WqepfSe/Y5dJqG8iYNg+8dhS1vT3PVL7BpbhuxAsJKWIzuio0Eacp X-Received: by 2002:a17:90a:4089:b0:216:c8ab:3f5b with SMTP id l9-20020a17090a408900b00216c8ab3f5bmr61401879pjg.157.1669660692101; Mon, 28 Nov 2022 10:38:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669660692; cv=none; d=google.com; s=arc-20160816; b=IfT+jAlFcbGds7P4lcNlZkDo4fboDs+PbU5s5/irQ7zo5bnK1sgVu7vk6fxn2E/89W h9CrohIgw6UV8d1tQ3Inup1L77WImfD94MEvaC7mSX0rlTiSrhjrbhg9b8S2KoLMorGx ufmCE2IeUJVXocJJWwe+pv3iSQSn94/8rlkvNH82/Dz5DjRZbr3N8bf14pdQj/YBC6YJ Sj8lM4MX+8kaljedLhruP0X1jQqO7qoTzGTLTMOh+1Ps7fk6dGD4HW/E7M3FTCKgPeL7 5j136A1KGA1P9iqKgD6Hy3qPI3m2inGeC5Lw+lzkg/7H7SKvPXfKieyjhjAzJFws9dnG joCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XcjfNsE/rIveffFVtpYUmOh3nTmRb1syYeB8uXGFD0A=; b=n3M/4iqHW2/rL4X1mDeV/xW+zngss1wEkSVqaIy4F9fZbmmUDuxYxsNmo0lZ9L0QLr JlJl1C2X+F72xChwvlpbOEVEbjUcc9mW7qi4e6Y4n/j9aUfgc6uwnrtvOSUSnW+dA3Sd yHiNjEinwELjOqiY6yhiNM9fddkBljjiba2q8Vy2eV0vbdFR7oPY0GfFZ3LBVCHHovvE 8vYNF8hTmPQB2/qFoFQZzty9TpEsqrqQxQVC/UehXAKhRXet9Evuldl1Zi8It65BOXUn I/24Q1QVr6Oc+IykYU3iGekdjawlH7jc4NxCvRoAhkWhoLfSvvgXYEl/9oh/CBSzE/sy wDjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WnJjcW7c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g25-20020a632019000000b004772bd7e38esi13044433pgg.868.2022.11.28.10.37.59; Mon, 28 Nov 2022 10:38:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WnJjcW7c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234109AbiK1SA7 (ORCPT + 84 others); Mon, 28 Nov 2022 13:00:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234070AbiK1SAd (ORCPT ); Mon, 28 Nov 2022 13:00:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 589B8E0EA; Mon, 28 Nov 2022 09:47:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F2503612F3; Mon, 28 Nov 2022 17:47:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA333C433D6; Mon, 28 Nov 2022 17:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1669657639; bh=1hkTev7NIENSu1g5GObZnRI6QKX9coXsgHP50hCr9cA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WnJjcW7cY1CYaWkk1lz8Z4Y2RREZBjwBremYGYBLCtbaj1en7CtPhYqJSd35I7djj Py0yDG4AV6uoBsYD4MVTAZcsPf7scv/XJrW4/GuVZmbvh2La5vP/60LH3K2e/gAFAw qB0vVpwzzuiS301QMo46lIr+RpzhkTxJHKxR8moY= Date: Mon, 28 Nov 2022 18:47:16 +0100 From: Greg Kroah-Hartman To: Lee Jones Cc: John Keeping , linux-usb@vger.kernel.org, Fabien Chouteau , Peter Korsgaard , Felipe Balbi , Andrzej Pietrasiewicz , linux-kernel@vger.kernel.org, Alan Stern Subject: Re: [PATCH 0/3] usb: gadget: f_hid: fix f_hidg lifetime vs cdev Message-ID: References: <20221122123523.3068034-1-john@metanate.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 02:04:13PM +0000, Lee Jones wrote: > On Tue, 22 Nov 2022, Lee Jones wrote: > > > On Tue, 22 Nov 2022, John Keeping wrote: > > > > > This series arises from the recent thread [1] on lifetime issues. > > > > > > The main point is the first patch, with the second being an unrelated > > > fix for an issue spotted while working on this. Both of these have > > > Fixes: tags for backporting to stable. > > > > > > The final patch tidies up some error handling to hopefully avoid patch 2 > > > issues in the future. > > > > > > [1] https://lore.kernel.org/r/20221117120813.1257583-1-lee@kernel.org > > > > > > John Keeping (3): > > > usb: gadget: f_hid: fix f_hidg lifetime vs cdev > > > usb: gadget: f_hid: fix refcount leak on error path > > > usb: gadget: f_hid: tidy error handling in hidg_alloc > > > > > > drivers/usb/gadget/function/f_hid.c | 60 ++++++++++++++++------------- > > > 1 file changed, 33 insertions(+), 27 deletions(-) > > > > For the set: > > > > Reviewed-by: Lee Jones > > Tested-by: Lee Jones > > Greg, is this still on your radar? Yes, let me catch up on pending patches...