Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de0c1d8a-42bb-4e29-4da0-7b0cfc9c2ffe@acm.org>
Date:   Mon, 28 Nov 2022 09:47:41 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v5 14/16] ufs: mcq: Add completion support of a cqe
Content-Language: en-US
To:     Manivannan Sadhasivam <mani@kernel.org>,
        Asutosh Das <quic_asutoshd@quicinc.com>
Cc:     quic_cang@quicinc.com, martin.petersen@oracle.com,
        linux-scsi@vger.kernel.org, quic_nguyenb@quicinc.com,
        quic_xiaosenh@quicinc.com, stanley.chu@mediatek.com,
        eddie.huang@mediatek.com, daejun7.park@samsung.com,
        avri.altman@wdc.com, beanhuo@micron.com,
        linux-arm-msm@vger.kernel.org,
        Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Jinyoung Choi <j-young.choi@samsung.com>,
        Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        Kiwoong Kim <kwmad.kim@samsung.com>,
        open list <linux-kernel@vger.kernel.org>
References: <cover.1669176158.git.quic_asutoshd@quicinc.com>
 <32219cb9b058d7329ad8234a8a287701af1a0e34.1669176158.git.quic_asutoshd@quicinc.com>
 <20221128170015.GM62721@thinkpad>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <20221128170015.GM62721@thinkpad>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/28/22 09:00, Manivannan Sadhasivam wrote:
> On Tue, Nov 22, 2022 at 08:10:27PM -0800, Asutosh Das wrote:
>> Add support for completing requests from Completion Queue.
>> Some host controllers support vendor specific registers
>> that provide a bitmap of all CQ's which have at least one
>> completed CQE. Add this support.
>> The MCQ specification doesn't provide the Task Tag or its
>> equivalent in the Completion Queue Entry.
>> So use an indirect method to find the Task Tag from the
>> Completion Queue Entry.
>>
>> Co-developed-by: Can Guo <quic_cang@quicinc.com>
>> Signed-off-by: Can Guo <quic_cang@quicinc.com>
>> Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
>> Reported-by: kernel test robot <lkp@intel.com>
> 
> What is this reported by for?

I think that tag should be left out. "Reported-by: kernel test robot" 
should only be used for patches that fix bugs reported by the kernel 
test robot. I assume that a fix has been folded in into this patch that 
was reported by the kernel test robot. If that is the case, the 
"Reported-by: kernel test robot" tag is inappropriate.

Bart.