Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 18:38:54 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regmap: cache: downgrade log level for no cache
 defaults message
Message-ID: <Y4UAPmbQsnqLMDVf@sirena.org.uk>
References: <20220921071054.3132504-1-alexander.stein@ew.tq-group.com>
 <Y4EX7DLt/Lvde/SJ@sirena.org.uk>
 <3208991.44csPzL39Z@steina-w>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uROZqsaJMWnwrz+5"
Content-Disposition: inline
In-Reply-To: <3208991.44csPzL39Z@steina-w>
Precedence: bulk


--uROZqsaJMWnwrz+5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 28, 2022 at 03:58:40PM +0100, Alexander Stein wrote:
> Am Freitag, 25. November 2022, 20:30:52 CET schrieb Mark Brown:

> > In this case if you can't use a rbtree cache I would recommend
> > bootstrapping by initially reading without a cache first to get the
> > default values, then replacing the regmap with one that uses the
> > defaults you just read.  You'll need some care over suspend/resume
> > though.

> The driver I'm working on clk-renesas-pcie.c only has 8 registers, so the=
re is=20
> no benefit to use a different cache than REGCACHE_FLAT.

There's a benefit when it comes to bootstrapping (though also a slight
performance cost, and non-atomicity).

> But I currently fail to see why this is only for non-sparse caches. This =
is=20
> printed even before the cache_ops init() is called.

We only go into hw_init() in the case where the map has specified
num_reg_defaults_raw, as you say you could trigger that for any cache
type but if you're using a sparse cache you're either going to provide
no defaults or provide defaults in the standard, sparse format rather
than the raw format so in practice it won't trigger.

> Before the call to regcache_hw_init() there is this comment:
> > /* Some devices such as PMICs don't have cache defaults,
> >  * we cope with this by reading back the HW registers and
> >  * crafting the cache defaults by hand.
> >  */

> This is exactly what I want to do: Read back HW registers and create a ca=
che.
> Actually regcache_hw_init() is exactly doing what you are suggesting:
> 1. reading HW registers into map->reg_defaults_raw
> 2.
>  a) copy them into map->reg_defaults
>  b) read HW register individually if 1. failed

The other thing with doing a readback to fill the cache is that it's a
potentially slow operation (depending on how big the cache is and the
bus in use) and also a potentially destructive one for things like clear
on read registers.  If regmaps are doing this deliberately (which does
seem valid) we probably want a clearer mechanism for specifying it - I
think an explicit flag would do the trick.

--uROZqsaJMWnwrz+5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOFAD0ACgkQJNaLcl1U
h9CCcAgAg9MYeYEhv3anXGxfBLh8IWj3lEDfBv8M+MAgyrrXXh3SqTRIlzeU/8HG
CS3RUPay8KUP6xxPpL931+se/c2bQQI2evl0TFAASAtf3iPHSgFeMeXmoBh/kN0m
aBM76554n2mppISIykgUdQd1FloLRDBxWjkX9dyazDw9tClga1dJFxFa+my7PRgF
CM9YQNEIVOaXHLVdO8t5WGXZ83mA5FKxn1eP8WzcBNyEEKrhmS8RD33PbQIOOIGa
DErlabr0SOJmURIBjUwYHrIY43gG9VgBR3oJhajJElhlHbzG+L6BAl8xcvQSnEjB
MlDdm8vetn+SeQR2kRhiPzS2ZtO0aA==
=8Qqz
-----END PGP SIGNATURE-----

--uROZqsaJMWnwrz+5--