Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15459202rwb; Mon, 28 Nov 2022 11:50:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf69WbwC6YUQQ4wazqH8Waqc1qj1ziv7paM6OHaWNdk4+nJd8qsFuF89FKXoOIbWdncNIdFW X-Received: by 2002:a17:906:b0cd:b0:78d:8c6b:397b with SMTP id bk13-20020a170906b0cd00b0078d8c6b397bmr31084486ejb.364.1669665023595; Mon, 28 Nov 2022 11:50:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669665023; cv=none; d=google.com; s=arc-20160816; b=E6bWUW+oGyiDmSb0g7cdYJBc0KAHlFeM2ItWUs6CN3J0/P2ful6m9em4Xxk9awegx6 XalkyeK6bvh5fOCnj9mM/kLYH69KIffFDg++vML90FlfGILT6ZCWy4ouzA3V+SKKQJMv 8/1Uz+hDkVVt0erbbNdZGLgcMNishkv5kFQd+PMEhOPSsGaaqrGNLP3npgUenRGw0UeL CJKMICFSbREY6Y6MNZwptFIeKd+Nls0AUqg7QCToZlzgrmA/K9E8XcQya35oZ2/5WoVo xdLKoa++aU65jNA78eiTUnDha05OFaPEs1tZKGrCXcrODpxjAga5gbc5aeKsXoB6keIR A0+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=vdiFLWGJlZNZEhU3chxdhx2hGdjjeSZKpnJnffDHCx4=; b=wL9CEYAB/BuF8drKIXISZm6KRcFhUT6T0SnDk6Y35JZKgYexhJiYl7rcUQflgFsXlg uMw+ioEbwOhLW32++GOjyY8Rea663vjgqxiUkvon/QOTZSZ0gQ3bQk2v8PQKjj5PFKzh NgtPn5TebIrPOEMDjlmngq9hyTv8fA81V52OIIFPFafZ6RCYAcErdHcoHna0EOlH3il9 ZJCAVhk24KrDYUmrJv4s7/iKQp8a0aOlUGDydvBdDI5hFUTHKAgtu4xPcd3tbW7SdjdN e7+BJr5aN12p3hYPvI7ZVrD4stto7ZNMNDimI+wqx4gelR98UcYZIX9HFYjdeFq9LiTP GzCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Q5XoN2Cj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a056402084b00b0046a84b922a2si1303579edz.499.2022.11.28.11.49.54; Mon, 28 Nov 2022 11:50:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=Q5XoN2Cj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232238AbiK1TIy (ORCPT + 85 others); Mon, 28 Nov 2022 14:08:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232932AbiK1TIw (ORCPT ); Mon, 28 Nov 2022 14:08:52 -0500 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EFE329C8C for ; Mon, 28 Nov 2022 11:08:50 -0800 (PST) Received: by mail-pj1-x102b.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so14975353pjc.3 for ; Mon, 28 Nov 2022 11:08:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vdiFLWGJlZNZEhU3chxdhx2hGdjjeSZKpnJnffDHCx4=; b=Q5XoN2CjIrbe+48L5bUfjZfu0U8JKd099j/FY7bwNTUH3aWmw9cAnqT8EgROl9fO4C qOJNJTIm54HvYo6ESRa+AGqTKFtczOfLgtde/tjYAQUNfe4U748t/psuR81Mo6eR6XDK sXlXiUBIXotQbcclPXQsaJq4Z9p3B5Dj4QF7c2XCk+w+z7/wrBnMz2rI26+IzJPJmuGO JKaYF8JhouN3XgWuhpIqqQ6dEd1oqnjkTbX4EWZ5r+qE4YJcamhZhJhQO252DrRpLJS/ +shfuyh0O9KPr6c/aUrEpA6d1zQ2Pt/J0pfypcEynvs9EKZn9rve8Xm4ZoTR7+fcJ4XX 7FTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vdiFLWGJlZNZEhU3chxdhx2hGdjjeSZKpnJnffDHCx4=; b=QMkHv1RYInqPXfqiO7GWvGovX3Z6LcvsepiejkrhU+0LiLrkmXhiRyytl1QclCGw/c 8Ns4h4stwbTpek1zsZya+ISAeypLxzXkSQMJaGpfeMETj7+X2GAHhLNRgOmCAOPY1dF2 hXaZoXBnZ5b6SlbFArcK+lo2hVBVJXfuAR2Q9ELNFyfZySY82zF4IkIWdDcWwBK7gCqf eEPLkhsu9rrKQafO0i7AHUB11pIXk4hMegEkC0d0bwi/ndptWGXnA8knUO7gk3TJ5cUv RlKMAJTEjmvmFSNmnQOymMFZV1eAw+7YhPGa6prVDF2cZt0DrQ4tc3m9Tl+MBOZ21zy4 rH7w== X-Gm-Message-State: ANoB5pnN2zPifDUyttaXKBAy7sUEFS6JjcCC/10OQ9BB0UJzxAjR2CHS oNz3K/h94cHsU9JTAQ86zPQf1Q== X-Received: by 2002:a17:902:f651:b0:187:190f:6aa7 with SMTP id m17-20020a170902f65100b00187190f6aa7mr35345914plg.131.1669662529792; Mon, 28 Nov 2022 11:08:49 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 6-20020a170902c14600b00187197c499asm9208642plj.164.2022.11.28.11.08.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 11:08:48 -0800 (PST) Message-ID: <0390c62d-11d9-5d89-ad88-db38526b74e6@kernel.dk> Date: Mon, 28 Nov 2022 12:08:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH-block] blk-cgroup: Use css_tryget() in blkcg_destroy_blkgs() Content-Language: en-US To: Andy Shevchenko Cc: Bart Van Assche , Waiman Long , Tejun Heo , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei , Andrew Morton , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Hillf Danton , Yi Zhang References: <20221128033057.1279383-1-longman@redhat.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/22 12:07 PM, Andy Shevchenko wrote: > On Mon, Nov 28, 2022 at 12:00:55PM -0700, Jens Axboe wrote: >> On 11/28/22 11:56 AM, Bart Van Assche wrote: >>> On 11/27/22 19:30, Waiman Long wrote: >>>> Fixes: 951d1e94801f ("blk-cgroup: Flush stats at blkgs destruction path") >>> >>> Has Jens' for-next branch perhaps been rebased? I see the following commit ID for that patch: >>> >>> dae590a6c96c ("blk-cgroup: Flush stats at blkgs destruction path") >> >> I don't know that sha is from, not from me. for-6.2/block has not been >> rebased, for-next gets rebased whenever I need to do so as linux-next is >> continually rebased anyway. But the sha for that commit would not change >> as a result. >> >> I don't even have that sha in my tree, so... > > $ git tag --contains dae590a6c96c > next-20221117 > next-20221118 > next-20221121 > next-20221122 > next-20221123 > next-20221124 > next-20221125 > next-20221128 That is the right sha, I'm talking about the fixes line in the patch you're replying to: Fixes: 951d1e94801f ("blk-cgroup: Flush stats at blkgs destruction path") which is certainly not from my tree. -- Jens Axboe