Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15459771rwb; Mon, 28 Nov 2022 11:50:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4gqfi9sZwyLeGb5/5d7AoAHwmIHkjesylz7cUQhs9W/b3m0CMWCxcfeFsMJW2E4uNNWClL X-Received: by 2002:a17:907:c081:b0:78b:5182:7ffa with SMTP id st1-20020a170907c08100b0078b51827ffamr34564772ejc.244.1669665052781; Mon, 28 Nov 2022 11:50:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669665052; cv=none; d=google.com; s=arc-20160816; b=WpkT3Y7w7+KAtECiYTXIJnT7ZzNaEihC1N9EtisutoBTugy3fGS05lqT1b7UR6fv81 a3zLsKonLxWhGBP5BMRGnp9jXStnTWrUUP8uZhppiphIrCNDlLRwHRg+OKxcsrVTiM/r e9qmoNbw8DW/tSZKOAvL5DlI6A9k1BEgLj8WZMPeJNJQyFOjMDP/0uNY+RLl6u0zyYS4 PTGjhAaPBm9hnl8P1R7DxRLHJQ5fkwDzo3gvZ+QqR91VYKXNg1fylreknTWU4ZfnvjAE FjMuDdGxVR3jveZEGtFIgEAxoBMn/gA6Ra8q4lxe+YEdq0vtWNn+Y5aDDvUl7jZKaxgx jSsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=srmd5cN/v/lNEDe7gBgSb59bXibOIrJWKMJkvNxSNVtyDbcwx14DvC4XlOVS7TDTKC 4OeA2w/nuFG7/aqEA9rLcIz4p1lCbHcVYaeGqnU7QUAhNLT1wi/4HG45zuHMTamaTrWk cSQMGxcJNqsnBFqJg9OvC6Hx2WD03+NpcH2UkkjFaMSHRp08xxTa9AQV8X45J9kBOfi8 GflOgHz4CfoNYz3vC2bCZHzsmZ2orUo3TuZ8pIpp5P21U4qgsm0h9zP6OQrMG8XzxhMa vyD9bsvN1VqsaK4zjkG+wasEkVqnmVgOFsJlSGg1CuWohz7zg0ZBxp2INLLjiR9URcaY f0/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=j4I86y6w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b11-20020a056402084b00b0046a84b922a2si1303579edz.499.2022.11.28.11.50.23; Mon, 28 Nov 2022 11:50:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20210112.gappssmtp.com header.s=20210112 header.b=j4I86y6w; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233191AbiK1T2f (ORCPT + 85 others); Mon, 28 Nov 2022 14:28:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232303AbiK1T2d (ORCPT ); Mon, 28 Nov 2022 14:28:33 -0500 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3D4126482 for ; Mon, 28 Nov 2022 11:28:32 -0800 (PST) Received: by mail-qt1-x830.google.com with SMTP id c15so7422147qtw.8 for ; Mon, 28 Nov 2022 11:28:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=j4I86y6wdhKn8Hv3cB1Ggw3Y3oZkLus35E2C4t/nVedgQZYs6BmhQQjn5ZvqNwDkR4 DhN0G81WwvwckgmQ3WuYV88zFUTjiqMfRcvdytnxZ5SIzQqYSxhRRVnhi4yq+ovF2n9O knl1EFAaO34BZsV7+cclB5D61z2P7xJ/BQBAVpy8d3NusKOmXtgzLVZIOt1/Hlbiygm9 IgVuVmTZMCkCi5nyG0vW5l38IUObFiWMsTGER4xwi04jJTi6v9UsFYgc5JgQQAzaEQ5J xaG4uM+JKZthiyA/OAxJbv1Z0qAQiC7/vc542rVWOjn3zoKQWCgjVFLfeCbXvUHT09nQ UEUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E4K7CdrO1bVG1lma0UHiRT4m0Q8nKmohqqgtpJrE588=; b=rIWRQfvipibfrD8I2UHZHTp8r5Gx+gs3bviVqqgBs2o1ZzLV26BFb7FA5z0di5J1qU xPnYBGka8F+Xkeh59Lff+wYlorZniZEHiSog7dmVk09QI8qH7ODoCM5FmaXv38Iv+Iip CnYVXTMzpg9aajgIrOYPhCSOvxeM2ttjJLY8dW8DpwaLD2WrERy4OL9zhJgIJicdfBEM NeS5BeNIfu8Nn6b+PShL6ADhzIFIG0sjLGAN5/ZXZSN5sRvt/aEu6en1tareOOzPt8/8 2i2624+eYbVyZGVpp53rLuF8oYsh/l6CLjM+nEjf8r7yeBEEoo30OYEkmZhJG3PBMV5s afEA== X-Gm-Message-State: ANoB5pn2MGfipZPgFRfc82HoMJ+EnnNalBzui8+RLOkX8Nr+m+lJK+GV JrC0ay31kwNTMMHrPJEZ6G3aqA== X-Received: by 2002:a05:622a:480e:b0:39c:e18e:758f with SMTP id fb14-20020a05622a480e00b0039ce18e758fmr31278458qtb.187.1669663712166; Mon, 28 Nov 2022 11:28:32 -0800 (PST) Received: from localhost (2603-7000-0c01-2716-9175-2920-760a-79fa.res6.spectrum.com. [2603:7000:c01:2716:9175:2920:760a:79fa]) by smtp.gmail.com with ESMTPSA id w18-20020a05620a445200b006fafc111b12sm9166183qkp.83.2022.11.28.11.28.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Nov 2022 11:28:31 -0800 (PST) Date: Mon, 28 Nov 2022 14:28:31 -0500 From: Johannes Weiner To: Nhat Pham Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com Subject: Re: [PATCH v7 6/6] zsmalloc: Implement writeback mechanism for zsmalloc Message-ID: References: <20221128191616.1261026-1-nphamcs@gmail.com> <20221128191616.1261026-7-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221128191616.1261026-7-nphamcs@gmail.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 11:16:15AM -0800, Nhat Pham wrote: > This commit adds the writeback mechanism for zsmalloc, analogous to the > zbud allocator. Zsmalloc will attempt to determine the coldest zspage > (i.e least recently used) in the pool, and attempt to write back all the > stored compressed objects via the pool's evict handler. > > Signed-off-by: Nhat Pham Ok, this now also has the get_first_page() and the cond_resched() that Sergey had asked for. Looks good to me. Acked-by: Johannes Weiner