Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15461516rwb; Mon, 28 Nov 2022 11:52:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7I23mo+XZj/wbIYbhgfM83I4HyJ79/9CUhMhVZ7R5g/WovSoX7dzT2Bm7gmWMjlaO9W8zB X-Received: by 2002:a17:906:a387:b0:7bc:2ad:7c1e with SMTP id k7-20020a170906a38700b007bc02ad7c1emr18141552ejz.588.1669665147586; Mon, 28 Nov 2022 11:52:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669665147; cv=none; d=google.com; s=arc-20160816; b=NRQhXDP4lxQt+fBTPJq/3EDAl1OuNBPrV1umEy8/AXrtEsEhPJFgmSNxKU4H+Ij85D FjyUhr84Dy/o2T8wZG3inMKkUWrr1byqrbwHOAf0pBVT/Qvoh6f77QLb0iaeI9v3jiuv riU/XIQl3uWevyZG8HvRFc68aLY74Ebe6YF5CJaEMpznfAaegUZLx5FPKEIyc5OGEExM tKJFiYDMB2m/XD+YL39DDlRyy3qZojIBGtKnWIWX9QE5Uko0PDvOTlCvRY7Jyyq6YcAG /mK3n+5EjAY2hEruBA7ydTl9oxvITOVD6ub6uwbxjRTvNLrQW0wAa6NP3hSNb/Khj5SO x1kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oUqI7Is8QbGOGvVDMlRQeGvLC1XZn2KgaG0jC2HCz54=; b=FqbgST7MWwzoh1yudagylMGk+yEaZH9H5u2pen/KeyNYXinBTikyWrJ5ewnyXQkAYP 7luQW/xdJJTYosZjkam9u6yv1WqP0vAwIaTzpEkuz0Ffy1U+jeqhULJ2Hnkau4II5Pnp fvQNAppmkGqhcyqW5I6mIEoNDG14oikvkPVX8TYKwqLzvqkpeEecwK7oEOF8Nf6VcRB9 VGc/RmIJKX5nOJLTSifkagOpK8tl79ExFKvxxnSWu6ZL3ilmvFEGnSurWG3jS5hgIlJE Z4SIByysoYX9WpVfGJyv5acpXdlgoqla9SNsJhlk4UCfdJfmyD1e4aSXb5Mfm7OuhGNZ OODg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BQ950FFp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc32-20020a1709078a2000b0078dcf17c084si10730861ejc.728.2022.11.28.11.52.06; Mon, 28 Nov 2022 11:52:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BQ950FFp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233173AbiK1TLp (ORCPT + 85 others); Mon, 28 Nov 2022 14:11:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233130AbiK1TLm (ORCPT ); Mon, 28 Nov 2022 14:11:42 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1118227937; Mon, 28 Nov 2022 11:11:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669662702; x=1701198702; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=nGzO+QrVInugh0e/lwUYUkj404LL7Ug3B9XyONtYbvY=; b=BQ950FFp2EksAiS9v62y3UPX1QZYebbBRjvvkL0OVByvk5WtgRPNhIZy en9IgztIzjaC80l5m1rfUUHhrwyj0Y5HuCM7zdDBfTPirkHFsl9BvbI1f YyO/SnBz3g2eb70AB02qXpraHM0UFks20SH4ed52HXP/6J5Y7VCxtPvH2 h7swF8vzFXJ4HaTSqsee6907vVnwTD9MOX7qL6U5czxZ6ORx6edKXuuHG TNKYWLZ78E0cMX1wfKLbahcsk3F3GjaKpERR6I++51LR07RnC9WGpfCvK Zs1/QGRIbcmw4v2h3rS/dfJF+kkqGjuY0QFDanM2gF3918O4pLyrCuP7e Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="295306145" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="295306145" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 11:11:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="706910256" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="706910256" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 28 Nov 2022 11:11:37 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1ozjXT-001MSe-12; Mon, 28 Nov 2022 21:11:35 +0200 Date: Mon, 28 Nov 2022 21:11:35 +0200 From: Andy Shevchenko To: Jens Axboe Cc: Bart Van Assche , Waiman Long , Tejun Heo , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Ming Lei , Andrew Morton , Michal =?iso-8859-1?Q?Koutn=FD?= , Hillf Danton , Yi Zhang Subject: Re: [PATCH-block] blk-cgroup: Use css_tryget() in blkcg_destroy_blkgs() Message-ID: References: <20221128033057.1279383-1-longman@redhat.com> <0390c62d-11d9-5d89-ad88-db38526b74e6@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0390c62d-11d9-5d89-ad88-db38526b74e6@kernel.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 12:08:47PM -0700, Jens Axboe wrote: > On 11/28/22 12:07 PM, Andy Shevchenko wrote: > > On Mon, Nov 28, 2022 at 12:00:55PM -0700, Jens Axboe wrote: > >> On 11/28/22 11:56 AM, Bart Van Assche wrote: > >>> On 11/27/22 19:30, Waiman Long wrote: > >>>> Fixes: 951d1e94801f ("blk-cgroup: Flush stats at blkgs destruction path") > >>> > >>> Has Jens' for-next branch perhaps been rebased? I see the following commit ID for that patch: > >>> > >>> dae590a6c96c ("blk-cgroup: Flush stats at blkgs destruction path") > >> > >> I don't know that sha is from, not from me. for-6.2/block has not been > >> rebased, for-next gets rebased whenever I need to do so as linux-next is > >> continually rebased anyway. But the sha for that commit would not change > >> as a result. > >> > >> I don't even have that sha in my tree, so... > > > > $ git tag --contains dae590a6c96c > > next-20221117 > > next-20221118 > > next-20221121 > > next-20221122 > > next-20221123 > > next-20221124 > > next-20221125 > > next-20221128 > > That is the right sha, I'm talking about the fixes line in the > patch you're replying to: > > Fixes: 951d1e94801f ("blk-cgroup: Flush stats at blkgs destruction path") > > which is certainly not from my tree. Ah, I see. That one is local / wrong. I don't see it either. -- With Best Regards, Andy Shevchenko