Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 14:10:56 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vincent MAILHOL <mailhol.vincent@wanadoo.fr>,
        kirill.shutemov@linux.intel.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com, jpoimboe@kernel.org,
        linux-kernel@vger.kernel.org, mingo@redhat.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, tglx@linutronix.de,
        viro@zeniv.linux.org.uk, x86@kernel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from
 asm-offsets.c
Message-ID: <20221128141056.29ccafd6@gandalf.local.home>
In-Reply-To: <Y4T4msSXCNnfPCMG@google.com>
References: <20221128091506.gp4l6klznqhigjxv@box.shutemov.name>
        <20221128101117.3614401-1-mailhol.vincent@wanadoo.fr>
        <20221128111112.dzavip4eqqgpyrai@box.shutemov.name>
        <CAMZ6RqJ0EgbLcz97ujqEzF1MBsH045W0Cu8mMuR0WCx_cTemCQ@mail.gmail.com>
        <20221128124513.76392c3d@gandalf.local.home>
        <b98429d8-6d18-cf0b-6ca0-d9d6472d21f9@redhat.com>
        <Y4T4msSXCNnfPCMG@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 28 Nov 2022 18:06:18 +0000
Sean Christopherson <seanjc@google.com> wrote:

> > > IIRC, the reason for adding that was because that logic was screwing up
> > > asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though.
> > > 
> > > This is one of those cases I wish I commented that code better :-/  
> > 
> > I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all.  
> 
> >From include/linux/kvm_host.h  
> 
>   #include <linux/ftrace.h>
> 
> Even if that didn't exist, saying that XYZ never includes a header is a dangerous
> business, it's all too easy to indirectly include headers in the kernel, now or
> in the future.

But going back to the original intent of COMPILE_OFFSETS. I believe it was
because some code that did not work with the auto generation of compiler
offsets and was a way to hide them.

I do not know if it is still an issue or not today.

-- Steve