Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202211290400.IuVDsFIm-lkp@intel.com> <CAHmME9oO=8hsc4zt_oBrRoGm3sMU03W7cP5PksfC-RFmZumGLQ@mail.gmail.com>
 <6358eb8f-a3ef-40ef-9d3a-842d9ff34709@app.fastmail.com>
In-Reply-To: <6358eb8f-a3ef-40ef-9d3a-842d9ff34709@app.fastmail.com>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Mon, 28 Nov 2022 22:12:04 +0100
Message-ID: <CAHmME9phWJFQvawqC7pN-2QNMeNTmakjQqi2e35EOH9=E=dsmg@mail.gmail.com>
Subject: Re: [ammarfaizi2-block:crng/random/vdso 20/22] include/uapi/asm-generic/unistd.h:890:34:
 error: 'sys_vgetrandom_alloc' undeclared here (not in a function); did you
 mean 'sys_getrandom'?
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Arnd,

On Mon, Nov 28, 2022 at 10:11 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Mon, Nov 28, 2022, at 22:03, Jason A. Donenfeld wrote:
> > Hi Arnd,
> >
> > Please see below. It would seem that I can't so easily get rid of that
> > #ifdef __ARCH_HAS afterall?
> ...
> >>          | ^~~~~~~~~
> >> >> include/uapi/asm-generic/unistd.h:890:34: error: 'sys_vgetrandom_alloc' undeclared here (not in a function); did you mean 'sys_getrandom'?
>
> No, this just means that some architectures require you to have the correct
> prototype for the system call in include/linux/syscalls.h, without an #ifdef.

Oh okay, thanks! I'll look into that.

Jason