Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Frank Li <Frank.Li@nxp.com>
Cc:     agross@kernel.org, ammarfaizi2@gnuweeb.org, andersson@kernel.org,
        andrew@lunn.ch, bhelgaas@google.com, festevam@gmail.com,
        gregkh@linuxfoundation.org, gregory.clement@bootlin.com,
        jgg@mellanox.com, kristo@kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com,
        lpieralisi@kernel.org, mark.rutland@arm.com, maz@kernel.org,
        nm@ti.com, okaya@kernel.org, robin.murphy@arm.com,
        s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com,
        shameerali.kolothum.thodi@huawei.com, shawnguo@kernel.org,
        ssantosh@kernel.org, vkoul@kernel.org, will@kernel.org,
        yuzenghui@huawei.com, imx@lists.linux.dev
Subject: Re: [patch V2 33/40] irqchip/imx-mu-msi: Switch to MSI parent
In-Reply-To: <20221128204710.2084706-1-Frank.Li@nxp.com>
References: <20221121140050.386216606@linutronix.de>
 <20221128204710.2084706-1-Frank.Li@nxp.com>
Date:   Mon, 28 Nov 2022 22:03:20 +0100
Message-ID: <87tu2ivlk7.ffs@tglx>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Frank!

On Mon, Nov 28 2022 at 15:47, Frank Li wrote:
> On Mon, Nov 21, 2022 at 03:40:09PM +0100, Thomas Gleixner wrote:
>>  	 * The device MSI domain can never have a set affinity callback it
>> --- a/drivers/irqchip/irq-imx-mu-msi.c
>> +++ b/drivers/irqchip/irq-imx-mu-msi.c
>> @@ -24,6 +24,8 @@
>>  #include <linux/pm_domain.h>
>>  #include <linux/spinlock.h>
>>  
>> +#include "irq-gic-msi-lib.h"
>> +
>
> I think irq-gic-msi-lib.h is not good name. Actually mu-msi is not arm gic.
> irq-gic-msi-lib do common work, which not related arm gic at all.

I realized that after a while too, but the main purpose of this series
was to establish that the core design holds up to handle the gazillions
of ARM variants out there and to solicit technical feedback from the
involved parties.

>>  static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev)
>>  {
>>  	struct fwnode_handle *fwnodes = dev_fwnode(dev);
>>  	struct irq_domain *parent;
>>  
>>  	/* Initialize MSI domain parent */
>> -	parent = irq_domain_create_linear(fwnodes,
>> -					    IMX_MU_CHANS,
>> -					    &imx_mu_msi_domain_ops,
>> -					    msi_data);
>> +	parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS, &imx_mu_msi_domain_ops, msi_data);
>
> coding style change should be in sperated patch.

Thanks for the thorough technical feedback!

       tglx