Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <202211290400.IuVDsFIm-lkp@intel.com>
In-Reply-To: <202211290400.IuVDsFIm-lkp@intel.com>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Mon, 28 Nov 2022 22:03:41 +0100
Message-ID: <CAHmME9oO=8hsc4zt_oBrRoGm3sMU03W7cP5PksfC-RFmZumGLQ@mail.gmail.com>
Subject: Re: [ammarfaizi2-block:crng/random/vdso 20/22] include/uapi/asm-generic/unistd.h:890:34:
 error: 'sys_vgetrandom_alloc' undeclared here (not in a function); did you
 mean 'sys_getrandom'?
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Arnd,

Please see below. It would seem that I can't so easily get rid of that
#ifdef __ARCH_HAS afterall?

Jason

On Mon, Nov 28, 2022 at 10:02 PM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://github.com/ammarfaizi2/linux-block crng/random/vdso
> head:   8fef976bbd3ca01f0a15981443cc820505b293ba
> commit: f4df2f0833b1fee3096da7fa8d060faeb9f8ba89 [20/22] random: add vgetrandom_alloc() syscall
> config: arc-defconfig
> compiler: arc-elf-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ammarfaizi2/linux-block/commit/f4df2f0833b1fee3096da7fa8d060faeb9f8ba89
>         git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
>         git fetch --no-tags ammarfaizi2-block crng/random/vdso
>         git checkout f4df2f0833b1fee3096da7fa8d060faeb9f8ba89
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>          |                                     ^~~~~~~~~
>    include/uapi/asm-generic/unistd.h:863:1: note: in expansion of macro '__SC_COMP'
>      863 | __SC_COMP(__NR_epoll_pwait2, sys_epoll_pwait2, compat_sys_epoll_pwait2)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:865:1: note: in expansion of macro '__SYSCALL'
>      865 | __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[442]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:865:1: note: in expansion of macro '__SYSCALL'
>      865 | __SYSCALL(__NR_mount_setattr, sys_mount_setattr)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:867:1: note: in expansion of macro '__SYSCALL'
>      867 | __SYSCALL(__NR_quotactl_fd, sys_quotactl_fd)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[443]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:867:1: note: in expansion of macro '__SYSCALL'
>      867 | __SYSCALL(__NR_quotactl_fd, sys_quotactl_fd)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:870:1: note: in expansion of macro '__SYSCALL'
>      870 | __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[444]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:870:1: note: in expansion of macro '__SYSCALL'
>      870 | __SYSCALL(__NR_landlock_create_ruleset, sys_landlock_create_ruleset)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:872:1: note: in expansion of macro '__SYSCALL'
>      872 | __SYSCALL(__NR_landlock_add_rule, sys_landlock_add_rule)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[445]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:872:1: note: in expansion of macro '__SYSCALL'
>      872 | __SYSCALL(__NR_landlock_add_rule, sys_landlock_add_rule)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:874:1: note: in expansion of macro '__SYSCALL'
>      874 | __SYSCALL(__NR_landlock_restrict_self, sys_landlock_restrict_self)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[446]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:874:1: note: in expansion of macro '__SYSCALL'
>      874 | __SYSCALL(__NR_landlock_restrict_self, sys_landlock_restrict_self)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:881:1: note: in expansion of macro '__SYSCALL'
>      881 | __SYSCALL(__NR_process_mrelease, sys_process_mrelease)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[448]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:881:1: note: in expansion of macro '__SYSCALL'
>      881 | __SYSCALL(__NR_process_mrelease, sys_process_mrelease)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:884:1: note: in expansion of macro '__SYSCALL'
>      884 | __SYSCALL(__NR_futex_waitv, sys_futex_waitv)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[449]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:884:1: note: in expansion of macro '__SYSCALL'
>      884 | __SYSCALL(__NR_futex_waitv, sys_futex_waitv)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:887:1: note: in expansion of macro '__SYSCALL'
>      887 | __SYSCALL(__NR_set_mempolicy_home_node, sys_set_mempolicy_home_node)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[450]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    include/uapi/asm-generic/unistd.h:887:1: note: in expansion of macro '__SYSCALL'
>      887 | __SYSCALL(__NR_set_mempolicy_home_node, sys_set_mempolicy_home_node)
>          | ^~~~~~~~~
> >> include/uapi/asm-generic/unistd.h:890:34: error: 'sys_vgetrandom_alloc' undeclared here (not in a function); did you mean 'sys_getrandom'?
>      890 | __SYSCALL(__NR_vgetrandom_alloc, sys_vgetrandom_alloc)
>          |                                  ^~~~~~~~~~~~~~~~~~~~
>    arch/arc/kernel/sys.c:13:37: note: in definition of macro '__SYSCALL'
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                     ^~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:44:1: note: in expansion of macro '__SYSCALL'
>       44 | __SYSCALL(__NR_cacheflush, sys_cacheflush)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[244]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:44:1: note: in expansion of macro '__SYSCALL'
>       44 | __SYSCALL(__NR_cacheflush, sys_cacheflush)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:45:1: note: in expansion of macro '__SYSCALL'
>       45 | __SYSCALL(__NR_arc_settls, sys_arc_settls)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[245]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:45:1: note: in expansion of macro '__SYSCALL'
>       45 | __SYSCALL(__NR_arc_settls, sys_arc_settls)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:46:1: note: in expansion of macro '__SYSCALL'
>       46 | __SYSCALL(__NR_arc_gettls, sys_arc_gettls)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[246]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:46:1: note: in expansion of macro '__SYSCALL'
>       46 | __SYSCALL(__NR_arc_gettls, sys_arc_gettls)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:47:1: note: in expansion of macro '__SYSCALL'
>       47 | __SYSCALL(__NR_arc_usr_cmpxchg, sys_arc_usr_cmpxchg)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[248]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:47:1: note: in expansion of macro '__SYSCALL'
>       47 | __SYSCALL(__NR_arc_usr_cmpxchg, sys_arc_usr_cmpxchg)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: warning: initialized field overwritten [-Woverride-init]
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
>       48 | __SYSCALL(__NR_sysfs, sys_sysfs)
>          | ^~~~~~~~~
>    arch/arc/kernel/sys.c:13:36: note: (near initialization for 'sys_call_table[247]')
>       13 | #define __SYSCALL(nr, call) [nr] = (call),
>          |                                    ^
>    arch/arc/include/uapi/asm/unistd.h:48:1: note: in expansion of macro '__SYSCALL'
>       48 | __SYSCALL(__NR_sysfs, sys_sysfs)
>          | ^~~~~~~~~
>
>
> vim +890 include/uapi/asm-generic/unistd.h
>
>    888
>    889  #define __NR_vgetrandom_alloc 451
>  > 890  __SYSCALL(__NR_vgetrandom_alloc, sys_vgetrandom_alloc)
>    891
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp