Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
From:   Sam James <sam@gentoo.org>
Mime-Version: 1.0 (1.0)
Subject: Re: [BUG] Add missing <linux/string.h> include for strcmp.
Date:   Mon, 28 Nov 2022 21:27:04 +0000
Message-Id: <06233B0E-53AC-4499-ABF0-8CD8B718278B@gentoo.org>
References: <20221128132507.98fab35cba20ce3f81810fcc@linux-foundation.org>
Cc:     "H. Nikolaus Schaller" <hns@goldelico.com>,
        linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>
In-Reply-To: <20221128132507.98fab35cba20ce3f81810fcc@linux-foundation.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Precedence: bulk


> On 28 Nov 2022, at 21:25, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> ﻿On Mon, 28 Nov 2022 18:15:55 +0100 "H. Nikolaus Schaller" <hns@goldelico.com> wrote:
> 
>> starting with v6.1-rc7 I can't build my tree any more:
>> 
>>  HOSTCC  scripts/mod/modpost.o - due to target missing
>> In file included from include/linux/string.h:5,
>>                 from scripts/mod/../../include/linux/license.h:5,
>>                 from scripts/mod/modpost.c:24:
>> include/linux/compiler.h:246:10: fatal error: asm/rwonce.h: No such file or directory
>>  246 | #include <asm/rwonce.h>
>>      |          ^~~~~~~~~~~~~~
>> compilation terminated.
>> 
>> Bisect did show your patch as the first bad one:
>> 
>> commit 50c697215a8c "Add missing <linux/string.h> include for strcmp."
>> 
>> Reverting it makes compile succeed.
> 
> Thanks.  I queued a reversion patch.

Thanks, I can't look into it properly right now so this is the best course of action. I'll test cross and the like then submit a fixed one in a few days.