Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 13:39:30 -0800
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Bart Van Assche <bvanassche@acm.org>
Cc:     rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-team@meta.com, rostedt@goodmis.org,
        Uladzislau Rezki <urezki@gmail.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 rcu 12/16] scsi/scsi_error: Use call_rcu_flush()
 instead of call_rcu()
Message-ID: <20221128213930.GK4001@paulmck-ThinkPad-P17-Gen-1>
Reply-To: paulmck@kernel.org
References: <20221122010408.GA3799268@paulmck-ThinkPad-P17-Gen-1>
 <20221122010421.3799681-12-paulmck@kernel.org>
 <3dbfae56-918f-d850-11b4-5c98e3baae05@acm.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3dbfae56-918f-d850-11b4-5c98e3baae05@acm.org>
Precedence: bulk

On Fri, Nov 25, 2022 at 04:11:26PM -0800, Bart Van Assche wrote:
> On 11/21/22 17:04, Paul E. McKenney wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 6995c89792300..634672e67c81f 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd)
> >   	 * Ensure that all tasks observe the host state change before the
> >   	 * host_failed change.
> >   	 */
> > -	call_rcu(&scmd->rcu, scsi_eh_inc_host_failed);
> > +	call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed);
> >   }
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Thank you both, I will apply these on the next rebase.

							Thanx, Paul