Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221128221152.1.Ia805c688ee968fbbec7b93dc10742876fdef8024@changeid>
In-Reply-To: <20221128221152.1.Ia805c688ee968fbbec7b93dc10742876fdef8024@changeid>
From:   Doug Anderson <dianders@chromium.org>
Date:   Mon, 28 Nov 2022 14:37:24 -0800
Message-ID: <CAD=FV=Wi3Oy9kdFfP6WE1wbtSrGxsr_VC8KZQAyTMgW-uMTOWA@mail.gmail.com>
Subject: Re: [PATCH 1/2] ASoC: qcom: lpass-sc7180: Drop unnecessary
 initialization in _resume()
To:     Matthias Kaehlcke <mka@chromium.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Banajit Goswami <bgoswami@quicinc.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
        linux-kernel@vger.kernel.org, Judy Hsiao <judyhsiao@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Mon, Nov 28, 2022 at 2:12 PM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> The initialization of the variable 'ret' in sc7180_lpass_dev_resume()
> is unnecessary, as it is always assigned a few lines below. Drop the
> initialization.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
>
>  sound/soc/qcom/lpass-sc7180.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Not that this needs review, but FWIW:

Reviewed-by: Douglas Anderson <dianders@chromium.org>