Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp15712517rwb; Mon, 28 Nov 2022 15:17:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf6QHrRDe6PBqdIAxzMfHvS7QuWc19zH2bszdshv1gGmcM/BJozNQGH+boshVxsznYnUF7es X-Received: by 2002:a17:906:4b04:b0:7b9:a75b:faf9 with SMTP id y4-20020a1709064b0400b007b9a75bfaf9mr25451954eju.473.1669677433740; Mon, 28 Nov 2022 15:17:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669677433; cv=none; d=google.com; s=arc-20160816; b=fyZsrfFiA7eeDIZGxqyzhH2Asmbp/GbsDF57bpT0hT8GLDGKk2EK0A3duEV1yFreVB UFmUT9tdQIK/I3E8B9P8BLAXj2EvIkyLduPWzdQerLDE1z4qbj5ElL3AqRBoxUzji82B QWMFMzQbptm3C/twsuDvJBvt4HsW3R98Dx8t/SfW7HMeL1oUoL5OoUhQyNSiTZJxtiKe 0UCLoOUm58FaZguveXOuCoX87AvdQKA7UI14apMxPWK293DbHj3GlUucT0y1hZ4EZOcm kIedqgc4p4bK6I6MyskNw6uP/F6kiJ01RgL2GWkcCNQ8DIRFbBo21Xb2LTdLZVuoZCRX LvQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=sWUrUUc1i1B0y6fOobN/opfX/XbYxKutYUAMsuhM+38=; b=q9Zd9hDK2PC2oEasrZC2savJr+KaQsI9OHBs0QFT+b+dB3viu+b55Hird+jSt4vdU1 FlwD/0+7b8wQzZ+1+7O89uq89hdBnIUvEnulPj3NSlcRrEsAme1COBp0OHe0gvzkWgjo 9BQ7HDYAY2/Hh0QVSFf5hr3t9V8aYR9v5Cjigk+OmVkAChtt7FMQoP66O1V1E8h5YE52 WJQnGsm6fJ9/LAusr5Jq5sWOdcpEIttCEFBmn45WHy6cwEUvhM7kRdiv4EHqjd8CrB67 4z9Bjg67xuypTCuIUQV5uLv7TDb8LcbZD6kHamn4mPUvMwsrs3qBDnyUXGCpmFBRscH/ mAUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EoqthV20; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e7-20020a170906c00700b0078034101c0esi10124786ejz.978.2022.11.28.15.16.48; Mon, 28 Nov 2022 15:17:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=EoqthV20; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233980AbiK1W3K (ORCPT + 83 others); Mon, 28 Nov 2022 17:29:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232683AbiK1W3I (ORCPT ); Mon, 28 Nov 2022 17:29:08 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFF5B24B; Mon, 28 Nov 2022 14:29:07 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CB78614AE; Mon, 28 Nov 2022 22:29:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7452CC433D6; Mon, 28 Nov 2022 22:29:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669674546; bh=xcQxXnrPCAnUx0UIMRQ0AyINld9piSgUJcX2QXwJ60M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EoqthV20Y+l4UTWI1AZtrRV93JG3GOnbQKy2tYKNI12ewckkMKp+2P/Cm8MeGeH2G ROHIqS+lMvigJpRr/gPxtQ+kfdmGpcXXNEJE3M6LqhodE2bsF6noOk+AR9iryZxG5c bxcitNTGsr2z8yoXyxBv6+1ovCAqAJnk14s/wucUjVtH0uc1+2Y3K8CykaUib6YVjH 7Oizk9UGfSwou8kEYjTYF4C+8JG3PZ4f/QUl6s1iRQOD6Vpy0vHhjHUtJE5i4NRj1z nzhI473FyyEKF+jOfUg4uLh3FLJAOxGolaSIs4uBDJeCT3+r4dNFI90DvNGCnekYK4 ci98NqGWiIQuw== Date: Mon, 28 Nov 2022 14:29:05 -0800 From: Jakub Kicinski To: Vincent Mailhol Cc: linux-can@vger.kernel.org, Marc Kleine-Budde , linux-kernel@vger.kernel.org, Greg Kroah-Hartman , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Saeed Mahameed , Andrew Lunn , Jiri Pirko , Lukas Magel Subject: Re: [PATCH v4 5/6] can: etas_es58x: report the firmware version through ethtool Message-ID: <20221128142857.07cb5d88@kicinski-fedora-PC1C0HJN> In-Reply-To: <20221126162211.93322-6-mailhol.vincent@wanadoo.fr> References: <20221104073659.414147-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-1-mailhol.vincent@wanadoo.fr> <20221126162211.93322-6-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 27 Nov 2022 01:22:10 +0900 Vincent Mailhol wrote: > Implement ethtool_ops::get_drvinfo() in order to report the firmware > version. > > Firmware version 0.0.0 has a special meaning and just means that we > could not parse the product information string. In such case, do > nothing (i.e. leave the .fw_version string empty). devlink_compat_running_version() does not work?