Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ba44ad1-675f-92c2-0e13-6bf9c4f8e598@intel.com>
Date:   Mon, 28 Nov 2022 15:49:33 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v1 net 2/2] vmxnet3: use correct intrConf reference when
 using extended queues
Content-Language: en-US
To:     Ronak Doshi <doshir@vmware.com>, <netdev@vger.kernel.org>
CC:     VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Guolin Yang <gyang@vmware.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20221128193205.3820-1-doshir@vmware.com>
 <20221128193205.3820-3-doshir@vmware.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20221128193205.3820-3-doshir@vmware.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnF2VkhQcEMzTTVpdGtzd0ltcU84QUFUNXhoYjBPbGZmMDg4WU02RFFKaGFk?=
 =?utf-8?B?ZWE4bmtoVWk4UGhYZWs4UGZEbk5PcXlGcGVacWtrVEJBM1IzZ0lxSTgxWXI3?=
 =?utf-8?B?V3YrNHB3OFFpakNCU2FrY1R5VElLRVZvTkEzMmdkVVhXd1k2Q3ZpQnBva2dq?=
 =?utf-8?B?VklBNFVTZXZYVzlzM0F1b2NHMDBNb0p3WHdncWZRSE1Objczb0dCY0VaMUY0?=
 =?utf-8?B?UGo4Tm55UnZuZWNHMTdWdCtWZ0NUSk92R01YTFFNa3lTNWF5cFNPL0ordjZK?=
 =?utf-8?B?WVJjZnRIZmpNWTVmdEVZdndkNUlhYjFkQjg1WUhDUkxtcmI2eWFEOXlRb3py?=
 =?utf-8?B?dElOMDlXUGFFS2ZLVWRKVFZGRmI1M2Z0STY0WHBkSWQvckNwRllCbDExcmJj?=
 =?utf-8?B?akRzZUJ3MFpza2I1bUlXQ1ptaVZ6WUU3Y1p4NldtYTk2YUtZL1hrZDBDd21P?=
 =?utf-8?B?MS91ZnBlY3BVTGpuOFN0S1hUTGZIV1hZeG1jMjJUT05zdVZvMSt6VWh6YUE5?=
 =?utf-8?B?SjZEaWxHZC9KRjVsV1Q5eUJHV24yQ2JOWnR6ek5VNXZYT0ZSVCtwUWExZUlo?=
 =?utf-8?B?SEpNcWNYVTBJd3RmR3BNR1FXTHJ2UkRTWDF4YW5rdFR3VzBOS3NRaVJib1Jw?=
 =?utf-8?B?WFhFSktSOUoxeVZVekgxaElYcnBrMG44cWV1N2kyTGlUMHI2c0lWdEJsS3M4?=
 =?utf-8?B?dzJnM1IrNlkwSklmSFVuMTdxRFdxMUpQWmNpM3MxY3IzQm9vRENkeGpFMVBO?=
 =?utf-8?B?ckRiRXlUZU5YamlsZDBkZ1AycnZxRGRhSnRESmt2SUdRRCt0dDZOMFVoOTRh?=
 =?utf-8?B?a2l0cDhtREdrL1BzdXhEdFJqVWNHMVFXNzk4ZytwWERMckdFMVJYUWFJSjFn?=
 =?utf-8?B?MGhUemhDVEsrL29pM24rUG9WZTdQRUJtS3lsTjV0L1g4ekxFQVN6bmZiV0VC?=
 =?utf-8?B?c1F5TUtXcWFMV0trZGFqaWE1V1RWcytXNUg5ZDZQMDVvYzlrRHAranZnZTFH?=
 =?utf-8?B?R1FYT3lCYWNteXB0Wm5HeCtYWnFScERzWG4xeWt4NUxTamlFcE5WMVVBRTN2?=
 =?utf-8?B?aGtLSmlLSlFWQmxoT05nQit4WXVJQkQ4c0hjYU1QMmxLZXRjRXV2L0VWMTZM?=
 =?utf-8?B?YXNpZzRLNSswRFlSYUkrckVCZS9DU2pRT3UwRFc2SFRJQ3R4aFRFLzBDZVFk?=
 =?utf-8?B?eUJDd1NvYmpFZmVVcC9RU2t6QXVOdjErdWtHMHFBQTIxbitxOFJkN0p3ZnZM?=
 =?utf-8?B?djBDdUhabElaS3orRHRJTkljWUNKeDFQNG9XMklHY1JPRDV6dWN4WkpTcnZ6?=
 =?utf-8?B?ZGFhMng1TEZtSXFTd203Zm9pUmdPY1JXVEFRNWJ6RXpCTm1nK0p3Zit0WVVW?=
 =?utf-8?B?UVp3MkE3eThQeTl0RWwxbjc2alRFN243QWdGYUx5dFZseGZpcWJmcnlBY3c3?=
 =?utf-8?B?ZkVPR1UvSmk1WFphQ1VTR0R4UU1lS3U5WmZzdE0yUXAxcmFmdkhBTUlwQnh6?=
 =?utf-8?B?OXdvaEVGKzlvWVVUS1JQNEhvY1dGNUZxWDkxcmR0OEtFdTNLN08zbUhSWmNK?=
 =?utf-8?B?N2o2amJCc0ZTaUNLRUxEMmk0RzZwSDVBbm9UVG1OeDJBMDBHWjhaTmcwQzV2?=
 =?utf-8?B?dlc3Y3N3M1FHUVllUGZvTmoyZ2EvVUZoRHlxd3JQNjUyU1ZtNXBQNEpBeGJx?=
 =?utf-8?B?b254bGppd2FJUk0yOEtlSGpPTDB5VkpXQ1JjM005ZXlFVmh1QjNiMFd3QmZP?=
 =?utf-8?B?YmI5NmFGaXErRmczWHNzeGNjaFdONjcxd3FJTkxnTWZVR21NM1NKMUMrYXV0?=
 =?utf-8?B?bnFGaVZ3cHU3dFlINWdpMFZmK0VoYTJ6eFY2Tnh1bjFTK01ueTFiSzlvQSt3?=
 =?utf-8?B?UTBQdlVpSDZUaXJqekRoTy9Ob3hOTWVxM04vSjdUYkNremJrZ2FUQ01adVhv?=
 =?utf-8?B?aFB1NUdveHRYeG8rcmRjclQwNTVUajRsdmppZUp4S3ZpQXJNSHB3VjJ1Ylg2?=
 =?utf-8?B?T0duQ1RhS2E3NHFsbmVMRUxIeitCeGErU2xUK2hpZWUrZnNWeHZOaDdwUkEx?=
 =?utf-8?B?UkVkUGVwQ214RHV5aHhqbk5yNFBRZVdRaXZaTDd5SVVWL05HaUJjVUpyUG1p?=
 =?utf-8?B?YWFRUlFDWVB2ckdKZ2hLejNpQlNrVkxFRDZEcGFyWHpqdVUwNVR4dXliTE9j?=
 =?utf-8?B?SkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 64e20be4-3ffe-437d-c65b-08dad19b3422
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2022 23:49:35.2582
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RqaOPUa/dOWV68JUKifoSbRKxgzhLAHbbA2Y4psXwuw3+LL4BolVChqTYvGc7UUJncEDQAt2EYp9AlGEpYCVZ8S2EJIykBgqHDgx4OEnrlQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5014
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/28/2022 11:32 AM, Ronak Doshi wrote:
> 'Commit 39f9895a00f4 ("vmxnet3: add support for 32 Tx/Rx queues")'
> added support for 32Tx/Rx queues. As a part of this patch, intrConf
> structure was extended to incorporate increased queues.
> 

Nit: no need to quote around the commit reference here.

I don't personally think its worth a re-roll to fix that, but good to be 
aware of in future submission.

The patch itself makes sense.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

> This patch fixes the issue where incorrect reference is being used.
> 
> Fixes: 39f9895a00f4 ("vmxnet3: add support for 32 Tx/Rx queues")
> Signed-off-by: Ronak Doshi <doshir@vmware.com>
> Acked-by: Guolin Yang <gyang@vmware.com>
> ---
>   drivers/net/vmxnet3/vmxnet3_drv.c | 16 ++++++++++++++--
>   1 file changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 611e8a85de17..39a7e90d4254 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -75,8 +75,14 @@ vmxnet3_enable_all_intrs(struct vmxnet3_adapter *adapter)
>   
>   	for (i = 0; i < adapter->intr.num_intrs; i++)
>   		vmxnet3_enable_intr(adapter, i);
> -	adapter->shared->devRead.intrConf.intrCtrl &=
> +	if (!VMXNET3_VERSION_GE_6(adapter) ||
> +	    !adapter->queuesExtEnabled) {
> +		adapter->shared->devRead.intrConf.intrCtrl &=
>   					cpu_to_le32(~VMXNET3_IC_DISABLE_ALL);
> +	} else {
> +		adapter->shared->devReadExt.intrConfExt.intrCtrl &=
> +					cpu_to_le32(~VMXNET3_IC_DISABLE_ALL);
> +	}
>   }
>   
>   
> @@ -85,8 +91,14 @@ vmxnet3_disable_all_intrs(struct vmxnet3_adapter *adapter)
>   {
>   	int i;
>   
> -	adapter->shared->devRead.intrConf.intrCtrl |=
> +	if (!VMXNET3_VERSION_GE_6(adapter) ||
> +	    !adapter->queuesExtEnabled) {
> +		adapter->shared->devRead.intrConf.intrCtrl |=
>   					cpu_to_le32(VMXNET3_IC_DISABLE_ALL);
> +	} else {
> +		adapter->shared->devReadExt.intrConfExt.intrCtrl |=
> +					cpu_to_le32(VMXNET3_IC_DISABLE_ALL);
> +	}
>   	for (i = 0; i < adapter->intr.num_intrs; i++)
>   		vmxnet3_disable_intr(adapter, i);
>   }