Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp43492rwb; Mon, 28 Nov 2022 16:55:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf4OfRoWtT4soczM/CJW0sLXx36JPK8+i3PRskqWEWxBYwXP4D47GYQfdxFyt9LnVi+rVgVP X-Received: by 2002:a17:906:3596:b0:7bc:6070:23e0 with SMTP id o22-20020a170906359600b007bc607023e0mr17572595ejb.465.1669683353077; Mon, 28 Nov 2022 16:55:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669683353; cv=none; d=google.com; s=arc-20160816; b=pX/y0VHCeM/v8erBZJQo5Il6Ywuk5HlEiXC6PCwqHpYLhvb5fmFP4XoLibMIxLz1DW MRuT6WyOO1bJSA76xGyiNm4DvAx6KiTcG4jQzyWYTZT8sRbYqrCgKHETS3JcwhE+i14m VoXi8rk5Yd+RA8wofzZywiwoleaNNgb5cD0/uiC/vZZXlSvS7K0fEoykQb2KCFWMo2mk NzMrzAGU3yXLIwDXkQ7NVC6cUg0c/uK4Ewomgtk+EmVeHz1qapZZZpXnwhLNA5t2KdfT xIU0Nu/BenvZ6VlcgOWgBRgk9R/8Dqmm4pOXejhInvgLEQyM8Xf8Jt1oaD+gxu2Saieh 8Rzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=V57uSH08PE25Wlk/c9BqDLzezSRu5me2pfIVdTCTkjo=; b=SHuzELQZeVajZDF7edqsELeXTOf4Re1s1i1pa7k98jcUwrVq12DATKb7NJ/sF9r1Tz +Ko/uPSYwYrDftWIQiBnTlnpK5sOAnpziA6DphcrGPB81bys/0gD5UCeT/2ZLRw8ONd7 iXSzCqzRkUjCKUDS2ffzE2l33fHTVP6N7TieQTW9OgEXC3pLFzPMH5gVd5LRl/mnjTBp 9JfyjQIeuhAInW1EZg+KawTdLpHNYB7xszdXaqEuQ6K8NmyCkHt79oUx1syJ8nbJWkJI Sp8eLzwnG1CGp/Y3qpp3NWmOZnOR1bZ/pQquPEfAs+grBOSGzzoZ32X/CYF1MVJBDpzZ DM1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=D+q65hKG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id us11-20020a170906bfcb00b00780a3097d20si8364619ejb.180.2022.11.28.16.55.31; Mon, 28 Nov 2022 16:55:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gateworks-com.20210112.gappssmtp.com header.s=20210112 header.b=D+q65hKG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234781AbiK2AU6 (ORCPT + 84 others); Mon, 28 Nov 2022 19:20:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234821AbiK2AU4 (ORCPT ); Mon, 28 Nov 2022 19:20:56 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 243F43123A for ; Mon, 28 Nov 2022 16:20:55 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id q17-20020a17090aa01100b002194cba32e9so840050pjp.1 for ; Mon, 28 Nov 2022 16:20:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gateworks-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=V57uSH08PE25Wlk/c9BqDLzezSRu5me2pfIVdTCTkjo=; b=D+q65hKGOvqVhsHWElVacfBJqkewFRwiZlCYL8dHK3aSw5hsmyl6gdmXYyOLzLA7NP 733rRyNp2nxO0dg9OJeTkJlreUeJNkkbrzHNUoUi+Xod1Eiao4uQpgqOgup8ZnhJMInG Ahiz5yXLH1Xw0C9kZpGrdjyi3ImzROsej0IAOw1mR7HpNPABsMVJizvjy2V8wu1H53Ay AMqtjJpNsySlkUt/1X3mrFRn0+sKg5I3upsiFgoHk1o5f5eBcs496YKvAEjY98vWHi5f JT8axftRuPlPQZQH2mwKcq+5uFkD/QuJb9V6JiprfjtWCne/F/KJ0/zjaPXVgI6cE8MD //0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V57uSH08PE25Wlk/c9BqDLzezSRu5me2pfIVdTCTkjo=; b=hCRwvITg/MLxLEjhUFQKUejnLdyuJDSSM2ZrojjaDzkYIwRk0AP8CcvN2Jlc81BHpD iYaUDaTR2+zNadkDjvaoZ0jBPrStcTBpZG3+eiuoK48G2VcSeN202aCWheF038AYHK0n LNwYsxYiOSql5nO7pDQM93V1v6eyIaHc/W6IZAhAYj36ag8dU97gqvABxn8Cc2TJ/E7G ncTDfEZpeT8lxNmVKmIccJ7c1d17ffgf+rzL31XYVg0xJNix4gv3gm7svLvaSn9ENdpb kPsaj/g6BLE+kqjEFi2DeM8dKUxyHoVFvcLUHaZ5SxjYnO711BEZWDnH1Cx8HtLODRPI s0uQ== X-Gm-Message-State: ANoB5pm7lFiKi9ESPbl1k1xtMl3LuupTB7zVxKjcoQlB9HavL4ljKcPY 9qPjgZsKfj8xHqx8jbvMddegVQurXgUYSm0NjIET/Q== X-Received: by 2002:a17:90b:1095:b0:219:237c:7986 with SMTP id gj21-20020a17090b109500b00219237c7986mr12292720pjb.220.1669681254627; Mon, 28 Nov 2022 16:20:54 -0800 (PST) MIME-Version: 1.0 References: <20221114210740.3332937-1-sean.anderson@seco.com> <20221115223732.ctvzjbpeaxulnm5l@skbuf> <3771f5be-3deb-06f9-d0a0-c3139d098bf0@seco.com> <20221115230207.2e77pifwruzkexbr@skbuf> <219dc20d-fd2b-16cc-8b96-efdec5f783c9@seco.com> In-Reply-To: From: Tim Harvey Date: Mon, 28 Nov 2022 16:20:42 -0800 Message-ID: Subject: Re: [PATCH] phy: aquantia: Configure SERDES mode by default To: Andrew Lunn Cc: Sean Anderson , Vladimir Oltean , Heiner Kallweit , Russell King , netdev@vger.kernel.org, Eric Dumazet , "David S . Miller" , linux-kernel@vger.kernel.org, Paolo Abeni , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 17, 2022 at 4:03 PM Andrew Lunn wrote: > > > Well, part of my goal in sending out this patch is to get some feedback > > on the right thing to do here. As I see it, there are three ways of > > configuring this phy: > > > > - Always rate adapt to whatever the initial phy interface mode is > > - Switch phy interfaces depending on the link speed > > - Do whatever the firmware sets up > > My understanding of the aQuantia firmware is that it is split into two > parts. The first is the actual firmware that runs on the PHY. The > second is provisioning, which seems to be a bunch of instructions to > put value X in register Y. It seems like aQuantia, now Marvell, give > different provisioning to different customers. > > What this means is, you cannot really trust any register contains what > you want, that your devices does the same as somebody elses' device in > its reset state. > > So i would say, "Do whatever the firmware sets up" is the worst > choice. Assume nothing, set every register which is important to the > correct value. > > Andrew Andrew, Sorry for the late reply! That's exactly what the firmware is doing. According to a Marvell FAE they add 'provisioning' of registers to the firmware to ease their support effort. That didn't at all ease things for me because I was pointed to the wrong firmware by another FAE which led to all of this. In my case my device-tree is setting the interface to xfi (10g) yet the firmware has provisioned the link for xfi/2 (5g) - a warning would have probably helped us all understand the issue but again I was just pointed to the wrong firmware without an explanation of how their firmware works. Tim