Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6dc8ce0d-6587-5f39-d8cc-e4626ebfaf41@intel.com>
Date:   Mon, 28 Nov 2022 17:18:40 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH 1/3] firmware_loader: remove #include
 <generated/utsrelease.h>
Content-Language: en-US
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        <linuxppc-dev@lists.ozlabs.org>
CC:     Masahiro Yamada <masahiroy@kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Nicholas Piggin <npiggin@gmail.com>
References: <20221126051002.123199-1-linux@weissschuh.net>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20221126051002.123199-1-linux@weissschuh.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFVnMUZBS0hwOGVzMk9PRU5wTGVNbnVnbm1TM0Y4M3VvdExnWXRwK3ZOdUxL?=
 =?utf-8?B?K2hGcXNFNUZZRDUrRWFjeWNJVnNMZlRlcEpzYnU4Q2pWd2JGdW5xQm9VbG9n?=
 =?utf-8?B?NGxhMDZtMnl2UXhKYk93UGY5ME9NZUxNaVQvUGV6bFRiSnlRYXJXa1JVaXJE?=
 =?utf-8?B?WjdFQ2tLUHZrWUp4OEpvQ3JkL2QyZzdzOTZSVDZjbGFMbXVqbDdTNWhUQUFv?=
 =?utf-8?B?Y2wweUlkUityUEd6ZEdLQ2JEcVNjUTNMWU0vOE0xVGtCekg5OVVLWFNHMFVQ?=
 =?utf-8?B?S1JGVzFDT3NoemlCN05qaW9scGlKR0g2VE01NEtFU0VZYlB5YTE5TERjbFd3?=
 =?utf-8?B?clBFR0VFb2ZRbTJZU1RIbUF2NEFXZ2pzbHRxOW9BeVhDL0hRRkVVN1F3d2hs?=
 =?utf-8?B?U1ljK0gxQVpQdktnbHR5amxiZjhtcGNZeTVOcldhRnZUQkUvWXJ2M24yM2lY?=
 =?utf-8?B?RHg1dzk3VjJHYkhZTXRQQ1MxdXRPbE1PWnlJRUd4cUNyaStrVSsrcEJZR0pm?=
 =?utf-8?B?VHlVY2MrMlZSUG1LS1BXMGdFRTZqTVJsQUk2N2R5Vi9OUkxEc1VZRms4Rk5u?=
 =?utf-8?B?bk8vSFJSYlpzc2Rxc0NCa3hENGRjUUVjRWhaVXJDa1FHUm12dXUvQXpJS0Yw?=
 =?utf-8?B?R3B2NzhmRjlhUmZPeFp6WUFZL0w3NVZ3N0VRU21UcHZvUTFTcHUzdVV1b0VP?=
 =?utf-8?B?UncrNU5KQVRySC9HRWhPNjlEakZHYlM0dTVYT2hQcjI5d0M5bEdEdi9mbm1q?=
 =?utf-8?B?bWkvWGxzWHJtSS9SRnVkOVN2TThFYmw4WHF3SmhPd3VHaXRvMEY4WTlVc2JZ?=
 =?utf-8?B?Y1phbkwrQ3ptc2JWK0FOWnNJakdCb3NaK2NrTk9seSsrcHYxYWZhVHMwMFRs?=
 =?utf-8?B?VWVDZjl3Y1dZYWJ5RS93aWQ0SGNnVmE0TWJHRCt1cm0walVaZmh4VDdJejJC?=
 =?utf-8?B?bWxVdFBZdGVqWCtPMDY2Z2NyN1laQzdHZWhDdkk2OGhvN3ZvUFZVNytrQXU2?=
 =?utf-8?B?K1JodXU0VWJqQ3hzRk95SXo2am1BTkIzTjZUSU1WcHhZbzVkMFlLcDlJVXZV?=
 =?utf-8?B?SmkycmRORE91QW8rVy9lTjJQMVpTNjJMc1dkQ3NZaE4wbnJhdEZzeUZJN0R2?=
 =?utf-8?B?TFRlbFp0NVlnT05PYmMwa0tFRTlxRHk5NlQwajRwak9vRkE2aFdkT1FyTnpp?=
 =?utf-8?B?SS8zeUF5cUxWRlRJV0FSYlUrZ0NMOEpTWTFuejl5cFBacUV4UWpMUVNPa0Zx?=
 =?utf-8?B?NHFGOFlVZENFanY3Z1hHdXdrdHpQR0pldTJFVGl3d29QQUJ6WUhWQi8xT0JR?=
 =?utf-8?B?UDN5SlBpdVNDV3dwa3loUjYvVGVUMVk3R0FVUEp5dzVIVnF5cVlTOGg4cmZ5?=
 =?utf-8?B?Tzc4TWwyRXhQZnJpNStJU0NEWWNnNTZRTUJMc1JXK0xYNVJ3ekhXNkdnK1RB?=
 =?utf-8?B?N21CcWpkTXFXTFl4U2dnWm1HajJYbFZ3bXk4S2ZNdGZ4T3VIZmtLYWlDZC9t?=
 =?utf-8?B?N09tREkyQ25abzdHVC9IYkxIeU8wMlpSSzFKa2VnREFoN25zaUFsajZudmRv?=
 =?utf-8?B?RVg5cEpzUVZaWjhEMWRYY0JlZVBEYlp2NG5oK2hMcDFXdmg3eDFuWXI3TjNJ?=
 =?utf-8?B?bkxybitQUWxLbnMwcjVYcUNJSytmRi83ZFFaSUd6a2RHTm5SeDdSWkxQODRj?=
 =?utf-8?B?alpvanozazcrM2JCdHFQd3RydTZJRGFYYy9xaDl1TktISmdoV2VBaU10dDNo?=
 =?utf-8?B?dkJtQmR6T1JtQzVsd240U1pBZ0ZwMGhnY0w2TTRZV254VzMrMmhkdXJWTUsr?=
 =?utf-8?B?VXRVZlpFWkVxRGRuTk93TjQ5QmJzNER4ZHJPNVRRYTFGUlc3WHU5d1IvV1N4?=
 =?utf-8?B?SkZNMXAyT09lK1pYOThkb2lXZk1FSG56WUlaMlhUKzBjWCs4RlgvTzRyNjNB?=
 =?utf-8?B?M2hlNU83WmFmbkYrRWVreWw0RmJBNTM4am50QnlTQkVFU01kMkJFN0prR21M?=
 =?utf-8?B?L0s0NUxPcFNibEJMUEFxU0tST1MrYXE3cWRtL3Zjd2lJM1B0cTc3N2dkWnB6?=
 =?utf-8?B?S2l5YmF3eXF2cVZ2ajBLRHJFUWM3OXdNUjNPdXEwUEtLNXlPL05YbXgyOFFJ?=
 =?utf-8?B?WGtEWUZ0S09OU2tBZ1BiZjlFS0JZbHc3Z2o4Y1h5ZG8rUjFYRktUZnYzdWlO?=
 =?utf-8?B?cFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 42d9669a-7e84-458d-6067-08dad1a7a7b8
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 01:18:43.3093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gvmpef/0ICPjYL+dzuPVLsBvoObjGZu0Yt7ICrb6ym2eDtEVOnBS1A+KtWQCMklFOfgaYF31XmORsdb8q+enacEn7rd86sRUz4QalXAbu3g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7894
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/25/22 21:09, Thomas Weißschuh wrote:
> utsrelease.h is potentially generated on each build.
> By removing this unused include we can get rid of some spurious
> recompilations.
Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>  drivers/base/firmware_loader/firmware.h | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/firmware_loader/firmware.h b/drivers/base/firmware_loader/firmware.h
> index fe77e91c38a2..bf549d6500d7 100644
> --- a/drivers/base/firmware_loader/firmware.h
> +++ b/drivers/base/firmware_loader/firmware.h
> @@ -9,8 +9,6 @@
>  #include <linux/list.h>
>  #include <linux/completion.h>
>  
> -#include <generated/utsrelease.h>
> -
>  /**
>   * enum fw_opt - options to control firmware loading behaviour
>   *
>
> base-commit: 0b1dcc2cf55ae6523c6fbd0d741b3ac28c9f4536