Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp109413rwb; Mon, 28 Nov 2022 17:45:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf6nCpGNpR4YVZyTeiR1f9HHjeKEzUWZf/jbwGBS64InJ32KDh63yv18WnGFCu8MDrZkDAT2 X-Received: by 2002:a17:90a:710b:b0:218:725:c820 with SMTP id h11-20020a17090a710b00b002180725c820mr57543576pjk.170.1669686354932; Mon, 28 Nov 2022 17:45:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669686354; cv=none; d=google.com; s=arc-20160816; b=Pmh4930aXLKSwaBiCjt5GlLx1GIsVmvp+mE292QVtc+x+y5ENCRM7Qhq+1J0G1aGja zdFU7FBUQZIK5tns+YXTcFCp1kyyIXA8xFOLkUATJ0JgYRdiviv8MYTE+BvBVypFpth6 dZf8bNiL/BJbw4ngSQT/EeXLYerv5i2j5vTtOewEENt0QLtNQnmhTmfsDzCskZS6vdRG OJDTBFayCq2Ocd9M1MGvMNhFxj8y4VcTplNKVdOEZ1PBJAE7tdk4a+m1aePJTkWx4pPX 8OK7p/s07dEtCzSGE11XMX9BMv9UpMxf41hmO5AbT7bbpKTpw31JaHqnAaZ4iDlu+R7Q A48g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=2WljVq8KNtlyND7hwSOZLCyiVKARAfWgBIBuD1N1DxM=; b=kc8lcBYbQcwJfDrOy9Ls9jsQQRNZwqMA67Nho34rzQlWSP/ylXO3m9Y9V5qBeLi0wE WfUJHLgLuyTKLWtjufAcjuZqHAzzzfAd/3BxBF+TD7SayXUXsnewVen2fqtmsPl2Zpj0 Jdc6LvmkkYpWsTQuy77HEDsToiuIi3Bfo0SvAiNKADxXNjWsieA754zEUEjZ3G4PUD2V FhQ4pyZoiKkxcnyAmwND5MHL5tm1TUkQMcukCV/szTeo4ojXngGU3w33KL0AmoH6h+7W AsVN5A7z4aZYRsYpQDdembJQdRJjT1cI21CpQMKvzdCVv8OpEjEx1fTCDOW1W8Vy00bp q+xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ikhNrKX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z7-20020a170903018700b00186940d7eaasi15489945plg.31.2022.11.28.17.45.44; Mon, 28 Nov 2022 17:45:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ikhNrKX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234915AbiK2BgD (ORCPT + 83 others); Mon, 28 Nov 2022 20:36:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233573AbiK2BgB (ORCPT ); Mon, 28 Nov 2022 20:36:01 -0500 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7CE43847 for ; Mon, 28 Nov 2022 17:36:00 -0800 (PST) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-3876f88d320so124542277b3.6 for ; Mon, 28 Nov 2022 17:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2WljVq8KNtlyND7hwSOZLCyiVKARAfWgBIBuD1N1DxM=; b=ikhNrKX9h3XrA0yg7nsy2qv3ZOAz2W9rFhIgzt1Q/QFn7Gh/VCcXZ2r2B9mqFVe4HJ EFxXL022jxpMKGgLbNFDolILWvQ9nugsb12noykri0zK0zIrv26pEzIQh4Jsq4P0pIPo FuhsEgIEE88Y6RO5Rc5l/NtkgIFfPDOQE4GdkNLoks1AIJHhP+owC5hjkLXOKFsm5MmA g9dDLAa6zx3px4o7/OjVkkOLtjC/voVzIkFvfg+GFME6j1cEn5BvdEYMbym+hHw8Z2/B cSSTznBEosg83VXjn1tjO6+knFBUHibIqTD78BnsprIPXqLUlrDoJpivYc+kK/vcu3AP yMnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2WljVq8KNtlyND7hwSOZLCyiVKARAfWgBIBuD1N1DxM=; b=P3etZOJ0b6pwXzZZq3xkQJdO9T7F9Xu7zDUg3+Xe5cy2OEEfwAHwRoBaRi0DaeHczI g1G5vR3qgP2SzSH+xHJT5iJ8PQ15w93+I3XvEZrtywBlfD5qgL+GkZBRy25Sc/SBplvI gemqw7wZeMySm6OFFY7uWY8G+BG51MaqXa0CNdYCJyKnKXN3Y7aMzCNRvnM4CBSXkIYE 1k9yf57ps8WIWa8jBIgHEmwJRBBl/kMkUxSpfR8mWsNqlhQ11PfbqRrfzyQQOMqozkmP JUlM9YdCSOKz1ShdF/2ENlk3TZQGEKpDiQzF9C4bVDtQPA4guIO8Hs6RARhAnH74e19Y 7img== X-Gm-Message-State: ANoB5pkUwAQKGlDLBnXYxV8rOkHsXYy4E1z3opEn/kGfgMDEUVH4bIBk hbaOiKudDTt/0tjfV29WoTAZk3RQ8PnyMDzDWa9Tcf258ggIsw== X-Received: by 2002:a0d:d103:0:b0:370:4c23:eacc with SMTP id t3-20020a0dd103000000b003704c23eaccmr52461243ywd.127.1669685759351; Mon, 28 Nov 2022 17:35:59 -0800 (PST) MIME-Version: 1.0 References: <20221129000047.697089-1-elder@linaro.org> In-Reply-To: <20221129000047.697089-1-elder@linaro.org> From: Dmitry Baryshkov Date: Tue, 29 Nov 2022 03:35:48 +0200 Message-ID: Subject: Re: [PATCH] clk: qcom: rpmh: add support for SM6350 rpmh IPA clock To: Alex Elder Cc: sboyd@kernel.org, mturquette@baylibre.com, andersson@kernel.org, konrad.dybcio@linaro.org, agross@kernel.org, Luca Weiss , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Nov 2022 at 02:00, Alex Elder wrote: > > From: Luca Weiss > > The IPA core clock is required for SM6350. Define it. > > Signed-off-by: Luca Weiss > --- > drivers/clk/qcom/clk-rpmh.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/qcom/clk-rpmh.c b/drivers/clk/qcom/clk-rpmh.c > index 0471bab824642..6a5887aae21a4 100644 > --- a/drivers/clk/qcom/clk-rpmh.c > +++ b/drivers/clk/qcom/clk-rpmh.c > @@ -603,6 +603,7 @@ static const struct clk_rpmh_desc clk_rpmh_sc7280 = { > DEFINE_CLK_RPMH_VRM(sm6350, ln_bb_clk2, ln_bb_clk2_ao, "lnbclkg2", 4); > DEFINE_CLK_RPMH_VRM(sm6350, ln_bb_clk3, ln_bb_clk3_ao, "lnbclkg3", 4); > DEFINE_CLK_RPMH_ARC(sm6350, qlink, qlink_ao, "qphy.lvl", 0x1, 4); > +DEFINE_CLK_RPMH_BCM(sm6350, ipa, "IP0"); > > static struct clk_hw *sm6350_rpmh_clocks[] = { > [RPMH_CXO_CLK] = &sc7280_bi_tcxo.hw, > @@ -613,6 +614,7 @@ static struct clk_hw *sm6350_rpmh_clocks[] = { > [RPMH_LN_BB_CLK3_A] = &sm6350_ln_bb_clk3_ao.hw, > [RPMH_QLINK_CLK] = &sm6350_qlink.hw, > [RPMH_QLINK_CLK_A] = &sm6350_qlink_ao.hw, > + [RPMH_IPA_CLK] = &sm6350_ipa.hw, This can use sdm845_ipa.hw instead of defining new clocks. > }; > > static const struct clk_rpmh_desc clk_rpmh_sm6350 = { > -- > 2.34.1 > -- With best wishes Dmitry