Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bdb1a752-ed47-1f9f-8a71-7b85e80bd547@intel.com>
Date:   Mon, 28 Nov 2022 17:26:23 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH] fpga: stratix10-soc: Fix return value check in
 s10_ops_write_init()
Content-Language: en-US
To:     Zheng Yongjun <zhengyongjun3@huawei.com>, <mdf@kernel.org>,
        <hao.wu@intel.com>, <yilun.xu@intel.com>,
        <linux-fpga@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <trix@redhat.com>
References: <20221126071430.19540-1-zhengyongjun3@huawei.com>
From:   Russ Weight <russell.h.weight@intel.com>
In-Reply-To: <20221126071430.19540-1-zhengyongjun3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2pLRmN5S1BaUGRrS1p2dit1akc1UGZXQk1SQnBsckY1YjBrMG9RZk9HTEc5?=
 =?utf-8?B?ZXJWZWpIcVlVWFBKb0NPaTUxcEhVbENXbTZCVnBxSlNSbm02cWMrajdCd1hD?=
 =?utf-8?B?MDNpdmN6N3ZKTnNuNDRkT3NZYXMveWhKWkF3VGpMM3RCc3A2Y01JUlA3Nkhv?=
 =?utf-8?B?NmxzRUxIb0hrbnFFNm9tczZ3RUZuOUcyVFdWdGU2WitmL3RNR09YUC9zSHZt?=
 =?utf-8?B?T2J2eUdDbXhDckF6MVlSTm41QUJ3c3BIRmd3QVkybjNMK1oybitTUEpyMDdr?=
 =?utf-8?B?THlKZmMrYmhVbUpxS3dqNHVYMnU5c29KV2Z0TlBXeERkMTFzZGFacjRUNE1o?=
 =?utf-8?B?ODhEUUpRdy95eFlOUy9BOXhNZ09RRmsrZzBoYjNPMTBPNnZiU1BCRjZiRVVS?=
 =?utf-8?B?cWZkSXd2VzlzMm13ZzFmOGh5SE1BbUVubDRxODhrK2NLZW45S041U1VNbnpI?=
 =?utf-8?B?UVUxR3JJYS9LT2V0Y3ZLcVBGbzdMYmZuWFo5eUhRTGdlZUszUUVLUk9OSjJw?=
 =?utf-8?B?UkdOcG5BWFUrNkJMdVF6NWR5RTM3bXhySDZOWlZVRzQ3V1dkWGgyU3lJc1Q4?=
 =?utf-8?B?WER4dldCMjJpSzhOdndzMkhociszY05xU1ZGeXVLdW1Kekx0SWNVL3ZqRk5B?=
 =?utf-8?B?clBGdng4NTU1YmJFWkJyYkZudE9RZEJnSmlUZndsN1dReEtBbkIyT05jc2ds?=
 =?utf-8?B?U2crSVFVWTlBaFBLSDhxbFV2K2c3TlEvY1B6WlBKcnBYWDdOTmlkbzMyU29s?=
 =?utf-8?B?Sy9KSzNMQmVPM0NCRTFEek5NS0g4eUh1ZmJPbnF3K1hGOWw4Zm84TVlWWkJL?=
 =?utf-8?B?QXF5NFQwSTdrRklUU3NlVm1yUDU2dVlmMU5TNDB2S3FGTCtIMnk4QmFXN09N?=
 =?utf-8?B?V3p0WXo3SGt2YThlMWNhNUg3amw0MWFvZXZDMVZaTlNCNkREcXA4N0g5eFd1?=
 =?utf-8?B?YWd3WXBJSUY4WG5LRW9OMEt5V09Uc0xjc2dvM0RHTjZZaDRVR1k1eGxjYitj?=
 =?utf-8?B?czl4Z0NrbU10d3p6djdaNStLY05PWFRyVm5zSXU2WlF3YkJLS2VNNzQxSmlk?=
 =?utf-8?B?dE1IaXFXNjB2YVUvbFFtZm1yeFF2TE1NOVZacjh3VFZDUDJEVnh2emhDdW95?=
 =?utf-8?B?dkRkcmFrYUtUVVRLekhBamVnSXNxRzQ4NnRONUVnVU5MbEExYUVXcUNMQ2p6?=
 =?utf-8?B?eE5tZXNMVklESlc3ZVdDNEFoUmZXT25VTFQ1KzBBR0x4UzJUMlRGbSsxaXVv?=
 =?utf-8?B?eXRrYmdnaWFwakZiMEIwdjBmOFpUTFpEU1lsREpxZmZab2pTd1hoOEg2ZWJq?=
 =?utf-8?B?TncxTDlXNkdxV25UT1h6TnNjdGRucW9xMGdKL1ZabFBQUVZhWE5SeWRia1ZZ?=
 =?utf-8?B?Wkd2dHF5Tk9sZFFsd0dxbCsvWVBadjNUQllGd05FWmpGMUo3QWpyUnNJMDBl?=
 =?utf-8?B?RWxsVFZtd2xJSEVxT0Z6K2xsWk4xdURESXhqNkZlN1UxNVoyb2txUEduaGtj?=
 =?utf-8?B?R2IvSlJPbmdVV0RValRRREk0bVprN2trSHFnc2J6NlhqV2lLUDF0ZE1EU1BL?=
 =?utf-8?B?RUxoTzBEOUYzTU0xTlQzMDQzWTR3OHUwQ3RmY3dQeHgxdmlRMXZCTFRIKy9F?=
 =?utf-8?B?QTl4cG93QUlON3IxMFRhRk16alZFRExkR1ZwVzdKb2laV0dFWnlzd1hnS05a?=
 =?utf-8?B?VGdIMnAwbXRib2lrQ0NSYmlqVmMrc01Mc2lzT05rNmQ4TW83b0pSQUl4OURO?=
 =?utf-8?B?THZNNjRJb3VoQ2JWY2E4R2FRZ2FKazB4K242NmRpN1U4b01xaGtkT3czZmIv?=
 =?utf-8?B?SnlkVXlMbzk5c3I2M0txaU5SVmJyS0JUWll6dGs3MjRwVVB3Uk1qak5RMU8v?=
 =?utf-8?B?L1FNMDVLU25oNWJWU3hCeE9xWGNnak4xRTUyZUlXSGR6bytpb2hRT2Z5Rm00?=
 =?utf-8?B?N21oRjh4VVV4SGR4RlJtV2t6Wm94WjRSSzRzMTdKMmdBS3RoV2NZWitmaHNH?=
 =?utf-8?B?MGxEQWFKQnBEYUtMRnF2akJZeHBJTTk0blRIa29rbGVubk5JR3ppTU1XRUNW?=
 =?utf-8?B?Z0tjWm85cnJyY0FYM0NYWUp1SXk1QVJ1cjJNUCs4U01OTVdQMlJHOWpyZWxi?=
 =?utf-8?B?QmhvcmJoaDVxeU05Zk1oRkZ0LzAvNlR4VlgwV1B3RWNydkxSQUwxR1UxZmNw?=
 =?utf-8?B?emc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e9643cb-eff2-4b04-4342-08dad1a8bb7e
X-MS-Exchange-CrossTenant-AuthSource: DM5PR11MB1899.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 01:26:25.8702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l2eRmV8RC4DKM9xRR7XamWG0wxwViyMSdYOGhQPcZ9vtoiTaE64IKqkCR4Hpy9dmKDfvYicTlJG4C/61jErUtkRHla2vDM8UaDfCIA/Kr2M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7894
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/25/22 23:14, Zheng Yongjun wrote:
> In case of error, the function stratix10_svc_allocate_memory()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
>
> Fixes: e7eef1d7633a ("fpga: add intel stratix10 soc fpga manager driver")

Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  drivers/fpga/stratix10-soc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 357cea58ec98..f7f01982a512 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -213,9 +213,9 @@ static int s10_ops_write_init(struct fpga_manager *mgr,
>  	/* Allocate buffers from the service layer's pool. */
>  	for (i = 0; i < NUM_SVC_BUFS; i++) {
>  		kbuf = stratix10_svc_allocate_memory(priv->chan, SVC_BUF_SIZE);
> -		if (!kbuf) {
> +		if (IS_ERR(kbuf)) {
>  			s10_free_buffers(mgr);
> -			ret = -ENOMEM;
> +			ret = PTR_ERR(kbuf);
>  			goto init_done;
>  		}
>
> --
> 2.17.1
>