Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <632848a1-d363-7a20-8dd3-fae6645fc28d@huawei.com>
Date:   Tue, 29 Nov 2022 09:30:27 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v3 1/2] RDMA/hfi1: Fix error return code in
 parse_platform_config()
To:     Leon Romanovsky <leon@kernel.org>
CC:     <bvanassche@acm.org>, <jgg@ziepe.ca>,
        <dennis.dalessandro@cornelisnetworks.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <andriy.shevchenko@linux.intel.com>, <bart.vanassche@wdc.com>,
        <easwar.hariharan@intel.com>
References: <1669470654-45828-1-git-send-email-wangyufen@huawei.com>
 <Y4SiPfXbMoSc1E6M@unreal>
From:   wangyufen <wangyufen@huawei.com>
In-Reply-To: <Y4SiPfXbMoSc1E6M@unreal>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/11/28 19:57, Leon Romanovsky 写道:
> On Sat, Nov 26, 2022 at 09:50:53PM +0800, Wang Yufen wrote:
>> In the previous while loop, "ret" may be assigned zero, so the error
>> return code may be incorrectly set to 0 instead of -EINVAL.
>> Add bail_with_einval goto label and covert all "goto bail;" to "goto
>> bail_with_einval:" where it's appropriate. Add dropping some duplicative
>> "ret = -EINVAL;" lines, as Andy suggessted.
>>
>> Fixes: 97167e813415 ("staging/rdma/hfi1: Tune for unknown channel if configuration file is absent")
>> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>>   drivers/infiniband/hw/hfi1/firmware.c | 20 +++++++++++---------
>>   1 file changed, 11 insertions(+), 9 deletions(-)
> 
> <...>
> 
> 
>> +bail_with_einval:
>> +	ret = -EINVAL;
> 
> Sorry for being late, but no. It can be seen as anti-pattern as it
> causes to the situations where unrelated code changes can potentially
> overwrite return value. Please set valid return code before calling to
> goto.

OK, will change in v4.
Thanks
> 
> Thanks
> 
>>   bail:
>>   	memset(pcfgcache, 0, sizeof(struct platform_config_cache));
>>   	return ret;
>> -- 
>> 1.8.3.1
>>