Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp116947rwb; Mon, 28 Nov 2022 17:53:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf5riEOBd23oF45p0l+GnhYYoudYXcuC4AArz3ECEGibpmsPHNFA948D/mcQKTlwCkWrcvRW X-Received: by 2002:aa7:8c54:0:b0:574:2f5a:18d0 with SMTP id e20-20020aa78c54000000b005742f5a18d0mr30968535pfd.23.1669686823196; Mon, 28 Nov 2022 17:53:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669686823; cv=none; d=google.com; s=arc-20160816; b=NLqZTxPTpbKSyZpwzAK/1hHN8p0ULhmWgSpoJIuu2vyBFfLd3nVnqzmMucff1/N+qP JjNKW4YGEYG4wEzJaQHFtbNKLmcmZptilEECnpkxChjtSMRWHx3zzzvS60a12sUhJyoI /eTjot65QzT0GyA5O4QayzPpuHF+mc8WXOViMV7/DebMK6D4fJUScpOz8r0ezeQOiO5o 90KLjyF4zxyWYX3YmdUpRCT7hN4Mj95DDfJUNXQ+GMAxVAPRR1smVRuzzxoNRpPGlXbo FDo9EXaZj3n5DRHm1pNGa2S3WvUJGmjK1v1OlGod0v/fmkQUrnN/GhjlA3QaSUBtGj7s BenA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=8nOlW7y1bi8iypYgiSbt5B5gbL/0fXCLpPOowd+x5Kw=; b=URNoyAG6J6MwQKXY97PX3+If5RcsoE9K5phGPai9No8dl4HqbZvSVwTanBDwXgFnYg 8yT9AeAyCVEsNwHvNqj5f6aEjSwXzFfyLOcdxNJfYV71zOy22k4qgNkptu9UeKlyTdc+ FXxjym+SQkesIarG69CoEBVAlZjREIbq4J/loMWCLC8zlY4A5MQOD8+RI7rkQA8WYjqx bKny/OYlDJViF688TYBnoV0RbzvkpGOMAff5LV4++EZuL773sQcFxamjxtmSnRpLCGGa cPG3sq7TeSEbwbCs5tT9XsAc3GVWAW15WBu0T3Nw4jxbczze8zd3/AmPM5RTc0t6TF9O 2/Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w62-20020a638241000000b0047702d15bcesi292126pgd.42.2022.11.28.17.53.32; Mon, 28 Nov 2022 17:53:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235072AbiK2Bml (ORCPT + 82 others); Mon, 28 Nov 2022 20:42:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235017AbiK2Bmj (ORCPT ); Mon, 28 Nov 2022 20:42:39 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320D9DF2; Mon, 28 Nov 2022 17:42:35 -0800 (PST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NLlSC132dzHwGb; Tue, 29 Nov 2022 09:41:47 +0800 (CST) Received: from kwepemm600001.china.huawei.com (7.193.23.3) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 09:42:28 +0800 Received: from [10.67.111.113] (10.67.111.113) by kwepemm600001.china.huawei.com (7.193.23.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 29 Nov 2022 09:42:27 +0800 Message-ID: <7379a5fd-5593-c6ce-40fd-c543dcf70d2b@huawei.com> Date: Tue, 29 Nov 2022 09:42:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH -next] selftests/landlock: Fix selftest ptrace_test run fail Content-Language: en-US To: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , , , , CC: , , , , , , References: <20221128020409.1545717-1-limin100@huawei.com> <1232e4f3-e4b8-ff23-61e8-5465c8406f6e@digikod.net> From: limin In-Reply-To: <1232e4f3-e4b8-ff23-61e8-5465c8406f6e@digikod.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.111.113] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600001.china.huawei.com (7.193.23.3) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I run test on Linux ubuntu2204 6.1.0-next-20221116 I did't use yama. you can reproduce by this step: cd kernel_src cd tools/testing/selftests/landlock/ make ./ptrace_test On 2022/11/29 3:44, Mickaël Salaün wrote: > This patch changes the test semantic and then cannot work on my test > environment. On which kernel did you run test? Do you use Yama or > something similar? > > On 28/11/2022 03:04, limin wrote: >> Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent, >> trace parent return -1 when child== 0 >> How to reproduce warning: >> $ make -C tools/testing/selftests TARGETS=landlock run_tests >> >> Signed-off-by: limin >> --- >>   tools/testing/selftests/landlock/ptrace_test.c | 5 ++--- >>   1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git a/tools/testing/selftests/landlock/ptrace_test.c >> b/tools/testing/selftests/landlock/ptrace_test.c >> index c28ef98ff3ac..88c4dc63eea0 100644 >> --- a/tools/testing/selftests/landlock/ptrace_test.c >> +++ b/tools/testing/selftests/landlock/ptrace_test.c >> @@ -267,12 +267,11 @@ TEST_F(hierarchy, trace) >>           /* Tests PTRACE_ATTACH and PTRACE_MODE_READ on the parent. */ >>           err_proc_read = test_ptrace_read(parent); >>           ret = ptrace(PTRACE_ATTACH, parent, NULL, 0); >> +        EXPECT_EQ(-1, ret); >> +        EXPECT_EQ(EPERM, errno); >>           if (variant->domain_child) { >> -            EXPECT_EQ(-1, ret); >> -            EXPECT_EQ(EPERM, errno); >>               EXPECT_EQ(EACCES, err_proc_read); >>           } else { >> -            EXPECT_EQ(0, ret); >>               EXPECT_EQ(0, err_proc_read); >>           } >>           if (ret == 0) {