Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <96a53991-3bca-2c0f-84d8-54e2f64d29b3@intel.com>
Date:   Tue, 29 Nov 2022 09:58:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH v2 0/4] KVM: selftests: AMX test fix and cleanups
Content-Language: en-US
To:     Sean Christopherson <seanjc@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20221128225735.3291648-1-seanjc@google.com>
From:   "Wang, Lei" <lei4.wang@intel.com>
In-Reply-To: <20221128225735.3291648-1-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/29/2022 6:57 AM, Sean Christopherson wrote:
> Fix a bug in the AMX test introduced by moving to kvm_cpu_has() for
> X86_FEATURE_XFD, and clean up the related code.  The fix and cleanups
> all revolve around ARCH_REQ_XCOMP_GUEST_PERM impacting the output of
> KVM_GET_SUPPORTED_CPUID, and thus causing problems for selftest's
> caching of KVM's supported CPUID.
> 
> Lei Wang, I adjusted your Author and SOB tags to drop the comma, which I
> think? violates that "use your real name" rule, and use formatting from
> patches you've sent in the past[*].  Let me know if that's ok (or not).

That's OK, thanks!

> [*] https://lore.kernel.org/all/20220424101557.134102-9-lei4.wang@intel.com
> 
> Lei Wang (1):
>   KVM: selftests: Move XFD CPUID checking out of
>     __vm_xsave_require_permission()
> 
> Sean Christopherson (3):
>   KVM: selftests: Move __vm_xsave_require_permission() below CPUID
>     helpers
>   KVM: selftests: Disallow "get supported CPUID" before
>     REQ_XCOMP_GUEST_PERM
>   KVM: selftests: Do kvm_cpu_has() checks before creating VM+vCPU
> 
>  .../selftests/kvm/lib/x86_64/processor.c      | 84 ++++++++++---------
>  tools/testing/selftests/kvm/x86_64/amx_test.c | 11 ++-
>  2 files changed, 52 insertions(+), 43 deletions(-)
> 
> 
> base-commit: 519c2002cd92bdc37c8412ca22cb9c7e7bc48c48