Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 29 Nov 2022 01:34:52 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-renesas-soc@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        John Crispin <john@phrozen.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        George McCollister <george.mccollister@gmail.com>
Subject: Re: [PATCH v3 net-next 03/10] dt-bindings: net: dsa: utilize base
 definitions for standard dsa switches
Message-ID: <Y4XSPMMDgiFipdIW@COLIN-DESKTOP1.localdomain>
References: <20221127224734.885526-1-colin.foster@in-advantage.com>
 <20221127224734.885526-4-colin.foster@in-advantage.com>
 <20221128232337.GA1513198-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221128232337.GA1513198-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?R9Hx9EKAt+nCE19UqSuzSZdIjkfKwUIuV6uUxMVomFfn/QZ/QxxPOyyTWhB9?=
 =?us-ascii?Q?NQKnVgX/WEbRsXRg+nEBJDvO0Nhi62zefWIm2SCrTgKxb6BflmTgGzk7VFkI?=
 =?us-ascii?Q?vhJTkGpIa8S+Aq4fLFOSUhgIYpViRBnwDQKBNwEAqKq8ummtJvNdH23E4bGV?=
 =?us-ascii?Q?BdmxXEf8j7p/NLD/hIT91tYN43L2A1INKkApA9bAv+NUyc6wgrlgm1GXqw/5?=
 =?us-ascii?Q?2EbpF62UPEVavfybDoygQLT8fhbt9vm9yMnmU4uBxNSO/XOygNy5dLqK6L3U?=
 =?us-ascii?Q?lr2JF8TPHPImBewNIAwoiEw8PhOQLjZU1/FCRkLv/XxedO7cZLpfPYA1o/lp?=
 =?us-ascii?Q?YbxMiQUd5MR3jauHDUK8dHjA7MyNW1Juv2/42g74AZAtSgRdwmwh4aG1uN/j?=
 =?us-ascii?Q?yy3ENegWrhWWHW0hKGcX7pLgX4xyk1mpd7d5puZ4/BsMlowrJVnCA5vw/gz5?=
 =?us-ascii?Q?9AM/tB1bRsBwj0HrvbTDDgyWHaRvdjqEUY7fi7WPnytQ7RFxDQloCHEboLxz?=
 =?us-ascii?Q?i+jJNdRVIuRG4eT6GJhbBKHByieXiFvDLlpMokaVD3f26PCYcSkY8nk4Z+Si?=
 =?us-ascii?Q?9UE3TorQxwxqCSudUdJYkYUKpHQj/u5PJ2eR0UNGqrZJHEFb5/g5qwSfQbUo?=
 =?us-ascii?Q?Z3s7zYrXr7dtx4bfQ8ONWiqBZ7ajsoXO5WXVOchhs3ukFBjO7bGFVq5pVncH?=
 =?us-ascii?Q?1PSOgftUjnXm+v8IMDCrc9HnKFhU0/7gpoYoKlo6LkbS+AGoF5cWRpFFv0CF?=
 =?us-ascii?Q?RYRY4OPnV396kjdX5DYcJ5Gozf4ItTCqOXd6IAv+FZRoy5/uKsvoG115YRiL?=
 =?us-ascii?Q?/6tfKpuqipm1+N7qtTC2DgMU3JETeViCIqXth80ir6EjCmpgQg89E+jqK2RK?=
 =?us-ascii?Q?x2t7KPa4oJV/drgIsUwDzxepNK8WyWO+rtWtlO7fFwSbAuetn7jlP303laHc?=
 =?us-ascii?Q?6joURLl/BRsphQFH6itRyL0E7C8xvTSObyhy0wqH6soJPgqI0Kd95WPkwWbw?=
 =?us-ascii?Q?/9WkLsLulODwRab1UN2ZMVpr9qSgDQ9vQZH1TA/WoS3N7AHmBtPUGS2GDs1M?=
 =?us-ascii?Q?lOn5WuWmgMT06O+wh2kqDJPxcVJEN4vFteD9AmkSCGepu76OYrWae4vY3F8o?=
 =?us-ascii?Q?hOCBMsMFxJUgDov93DwjJx3AiqRVWS8iuzj65pk4Bb8ZGect1FO1A4HWsycn?=
 =?us-ascii?Q?CIIijhgE5wLkvzVpqLkGohdh3AkC1HGfVaAFX37DL+30eTRrl8O+0GXhoE7D?=
 =?us-ascii?Q?Bj3aYzKFJJduvEF2qQlneyZ1dGFCWLyLAgALXmQTvi3Rz+ZXSHs7lVr3Uc0O?=
 =?us-ascii?Q?W9qcZsOJhUhhfQky+4DxfdBajTEgp/tAUTzguu1UxrJQDJbwRNhBP9D2Hpmb?=
 =?us-ascii?Q?krHWlj/lYCPNzt3ptMJ2VYBtRkJhNEGeL0sr9sqyYTgDew5CbuPCL+YR5dWC?=
 =?us-ascii?Q?6Yezb9rWCqKfwB7J41gfoK1oxteID3XEmpflnm9FLckf/EtvL7GC04xzROYf?=
 =?us-ascii?Q?p0qCa2nm3o14wQ7tNcO1nGNUJftlspycKH5uRF9qNiLUnHqHMQdzIAOTa854?=
 =?us-ascii?Q?EUf/xcJoNaZ00Prmb2i1/6deXVax3AoC9aFyDLMWQ/4HHmMwG5b3sC/R+3mc?=
 =?us-ascii?Q?WLLrQ3ONH//9dmqz0ohPGBU=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 698dfc62-9a53-4bc7-3558-08dad1b24d85
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 02:34:56.3493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oY3YZJTJEpC/FeXaGlz34yaCdqgLlFVWF08ifyEDVHCt8ps57gRZ1k/RAcEYx39jL3hkujESKtSH/LU6DBiRt2jK6PMrGABvCdCA6KWH14s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6617
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12,
        DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

On Mon, Nov 28, 2022 at 05:23:37PM -0600, Rob Herring wrote:
> On Sun, Nov 27, 2022 at 02:47:27PM -0800, Colin Foster wrote:
> > DSA switches can fall into one of two categories: switches where all ports
> > follow standard '(ethernet-)?port' properties, and switches that have
> > additional properties for the ports.
> > 
> > The scenario where DSA ports are all standardized can be handled by
> > swtiches with a reference to 'dsa.yaml#'.
> > 
> > The scenario where DSA ports require additional properties can reference
> > the new '$dsa.yaml#/$defs/base'. This will allow switches to reference
> > these base defitions of the DSA switch, but add additional properties under
> > the port nodes.
> 
> You have this backwards. '$dsa.yaml#/$defs/base' can't be extended. 
> Perhaps '$defs/ethernet-ports' would be a better name.

Oops. I'll fix this up for next set.

> 
> > 
> > Suggested-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> > ---
> > 
> > v3
> >   * New patch
> > 
> > ---
> >  .../bindings/net/dsa/arrow,xrs700x.yaml       |  2 +-
> >  .../devicetree/bindings/net/dsa/brcm,b53.yaml |  2 +-
> >  .../devicetree/bindings/net/dsa/dsa.yaml      | 19 ++++++++++++++++---
> >  .../net/dsa/hirschmann,hellcreek.yaml         |  2 +-
> >  .../bindings/net/dsa/mediatek,mt7530.yaml     |  2 +-
> >  .../bindings/net/dsa/microchip,ksz.yaml       |  2 +-
> >  .../bindings/net/dsa/microchip,lan937x.yaml   |  2 +-
> >  .../bindings/net/dsa/mscc,ocelot.yaml         |  2 +-
> >  .../bindings/net/dsa/nxp,sja1105.yaml         |  2 +-
> >  .../devicetree/bindings/net/dsa/realtek.yaml  |  2 +-
> >  .../bindings/net/dsa/renesas,rzn1-a5psw.yaml  |  2 +-
> >  11 files changed, 26 insertions(+), 13 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> > index 259a0c6547f3..8d5abb05abdf 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/arrow,xrs700x.yaml
> > @@ -7,7 +7,7 @@ $schema: http://devicetree.org/meta-schemas/core.yaml#
> >  title: Arrow SpeedChips XRS7000 Series Switch Device Tree Bindings
> >  
> >  allOf:
> > -  - $ref: dsa.yaml#
> > +  - $ref: dsa.yaml#/$defs/base
> >  
> >  maintainers:
> >    - George McCollister <george.mccollister@gmail.com>
> > diff --git a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> > index 1219b830b1a4..f323fc01b224 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
> > @@ -66,7 +66,7 @@ required:
> >    - reg
> >  
> >  allOf:
> > -  - $ref: dsa.yaml#
> > +  - $ref: dsa.yaml#/$defs/base
> >    - if:
> >        properties:
> >          compatible:
> > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > index b9d48e357e77..bd1f0f7c14a8 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > @@ -19,9 +19,6 @@ description:
> >  select: false
> >  
> >  properties:
> > -  $nodename:
> > -    pattern: "^(ethernet-)?switch(@.*)?$"
> > -
> >    dsa,member:
> >      minItems: 2
> >      maxItems: 2
> > @@ -58,4 +55,20 @@ oneOf:
> >  
> >  additionalProperties: true
> >  
> > +$defs:
> > +  base:
> > +    description: A DSA switch without any extra port properties
> > +    $ref: '#/'
> > +
> > +    patternProperties:
> > +      "^(ethernet-)?ports$":
> 
> This node at the top level needs 'additionalProperties: false' assuming 
> we don't allow extra properties in 'ports' nodes. If we do, then we'll 
> need to be able to reference the 'ports' schema to extend it like is 
> done with dsa-ports.yaml.

I'll double check if there's anything that adds any properties. If there
is, would that be a separate file pair: "dsa-ports.yaml" and
"ethernet-switch-ports.yaml"? Or do you think that could be contained in
the existing dsa.yaml, ethernet-switch.yaml?

> 
> > +        type: object
> > +
> > +        patternProperties:
> > +          "^(ethernet-)?ports@[0-9]+$":
> > +            description: Ethernet switch ports
> > +            $ref: dsa-port.yaml#
> > +            unevaluatedProperties: false
> > +
> > +
> 
> One blank line.

Oops again. Thanks for spotting this and for all your help on this!

> 
> >  ...