Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp215900rwb; Mon, 28 Nov 2022 19:34:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf7ti2jFxw1hIQQZEHXq4Cn+oHPk9hO6ZpJiAtzRS4o9v8ey/bFV/MEzlmlSs7MahzVpbU4P X-Received: by 2002:a17:903:1314:b0:189:86b4:c4a with SMTP id iy20-20020a170903131400b0018986b40c4amr9284437plb.30.1669692877321; Mon, 28 Nov 2022 19:34:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669692877; cv=none; d=google.com; s=arc-20160816; b=PkbJ9qWYLSJdNZa1NyC60hBD7XZ6kNhbASri7R6EOkGTwJI7a+oen1e1uhfk2hG3Eb GADqZ+ej1XgtN0cilQ7eySRfCdg2yp46/NQ8+3Lx/2WxV1ngqnoQlKSX6nnUHoM02rdI AGGT2eMAqSADJ/zK0GSCPh28QYRAoAbjntXJGoBj3egqbSteRXXikobX8SJKwbofdasQ ytwLedNsiPS7MpaEltTxJR5xelzewfYdGwUY/R4h1ee3t6BeJAXY3pPJEMl/u+xV84JS vVcswSdmlosn/mARIQD/aC9dpCDirNG7l3QYkI3+P4tmxtWXdUNFJqeihi3YEJswkGB/ v0Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=NW5719qPnz6Qk9YxgWOThpqRx83q0d62O3HsiLv5jNs=; b=t9b47O/g/zFUOLSz74pBjSbcnlqxqZyYFnaZbVuPzWGAk3CeGua43NN9UHYSEHW35o OE+IOSqUmDJeKF4RhdwaWRyOo4SDojO9DyR2UI+FdrfwnuDEQG+eQy4yyUQh4dQedQ+X Jps0b/oyhxEI8+dFOWRpjWHzWMZSJaiIF+rxywjdTindReGGZtB2UkAufE/o60WdFLsJ tfWN926VAex9OEhMiHsTeQA1dUyQbXbENwz+wya/64WmLmrsMBZ1MtNJVobHA8NtzfS6 ebq7HEWyOUTg05V8WPP3b7yVc8aJdzjLwpfI6Z2ZVNURtub/lnCOq6P2NAeYkxPpwJP0 9tBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a62ee0d000000b005748c08eca6si12053726pfi.76.2022.11.28.19.34.26; Mon, 28 Nov 2022 19:34:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235433AbiK2DR3 (ORCPT + 82 others); Mon, 28 Nov 2022 22:17:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230298AbiK2DR0 (ORCPT ); Mon, 28 Nov 2022 22:17:26 -0500 Received: from out30-133.freemail.mail.aliyun.com (out30-133.freemail.mail.aliyun.com [115.124.30.133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B574733F; Mon, 28 Nov 2022 19:17:25 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VVym2Ua_1669691835; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VVym2Ua_1669691835) by smtp.aliyun-inc.com; Tue, 29 Nov 2022 11:17:23 +0800 From: Jiapeng Chong To: mchehab@kernel.org Cc: p.zabel@pengutronix.de, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] media: platform: Fix missing error code in rzg2l_cru_start_streaming_vq() Date: Tue, 29 Nov 2022 11:17:12 +0800 Message-Id: <20221129031712.115354-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Failed to allocate scratch buffer, add the error code '-ENOMEM' to the return value 'ret'. drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c:676 rzg2l_cru_start_streaming_vq() warn: missing error code 'ret'. Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3275 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c index 9533e4069ecd..91b57c7c2e56 100644 --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c @@ -673,6 +673,7 @@ static int rzg2l_cru_start_streaming_vq(struct vb2_queue *vq, unsigned int count if (!cru->scratch) { return_unused_buffers(cru, VB2_BUF_STATE_QUEUED); dev_err(cru->dev, "Failed to allocate scratch buffer\n"); + ret = -ENOMEM; goto free_image_conv_irq; } -- 2.20.1.7.g153144c