Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: LrpajiKr8JP9U0cjIvIqYqDXnMMlAKiOGZD+G3jxDlOe/OZux4F9bWL6gqH6dA2FFzC2VttygZ
 +tSpOsXMHa9NUibwGIfMdh8Hn6aZT6VYrzzVFC3PIz3CbuPqGABHBqI5F4urb7XRDM72OWhVEE
 aXHvmh0K41OigDWdoWOvjG0l/Y0LA2dFHf7XoT7MjGcBaPYqdINlRi4KawR+qeRuvJrIYmoIbQ
 iq+kpqlOuUxxDlPa8XuanLC/xUYEC6AyPqGsTkuMRJCs8v3MQXD9wtE/36PYtCv2cYKR8XXfBo
 +r0=
IronPort-SDR: COTz8K7qqyJJc4YyxrKDWenU5tlxYudDLM/WT3lAl1NDSE2Ung0uNtiIH6ME0HgCwXC5kftnrj
 4+zqFNM9skO/rr8GTO/0zCmEXBXVG7k7Wks20t8j8CRYuJXMzWcaYSCgJEPQbKrChvlgcm2zTs
 E1MF4FbG3WIFSgXZwFnm8HriRvFKFWj9Pdp47Gqez4lmXwh1rvuVLEPcTlPg3VZLL1j/DJMwPO
 5V+XCqRmX6cORto4/eUtNwDz1hVVGyjE+hpLRJ0E0WvFt+oQzo/vznMatDZJuVjuGWHYOEPhJp
 tHc=
WDCIronportException: Internal
Message-ID: <89f5e3a2-1cf7-8b9e-f3b9-af0fe4f72c60@opensource.wdc.com>
Date:   Tue, 29 Nov 2022 11:50:51 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: linux-next: Fixes tag needs some work in the block tree
Content-Language: en-US
To:     Jens Axboe <axboe@kernel.dk>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20221129082715.78e44566@canb.auug.org.au>
 <ab5368d2-5f65-68cb-9703-23d6e451b775@opensource.wdc.com>
 <c03be0eb-1c4c-b8c9-8325-c7769b966ddf@kernel.dk>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <c03be0eb-1c4c-b8c9-8325-c7769b966ddf@kernel.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/29/22 11:30, Jens Axboe wrote:
> On 11/28/22 4:39?PM, Damien Le Moal wrote:
>> On 11/29/22 06:27, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>>   4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")
>>>
>>> Fixes tag
>>>
>>>   Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")
>>>
>>> has these problem(s):
>>>
>>>   - SHA1 should be at least 12 digits long
>>>     This can be fixed for the future by setting core.abbrev to 12 (or
>>>     more) or (for git v2.11 or later) just making sure it is not set
>>>     (or set to "auto").
>>
>> Oops. Sorry about that. It seems I cannot count up to 12 anymore :)
>> It should be:
>>
>> Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write
>> streams to zoned HDDs")
>>
>> Jens, can you fix this ?
> 
> Sure, it's not that important though as it's just missing one digit. For
> the record, this is what I have in my .gitconfig :
> 
> [alias]
> fixes = log -1 --format=fixes
> 
> [pretty]
> fixes = Fixes: %h (\"%s\")
> 
> [core]
> abbrev = 12
> 
> and then you just do 'git fixes <sha>' and it spits out the line for the
> commit without needing to count anything and eliminates this error.

Thanks for the info. Will try this !

-- 
Damien Le Moal
Western Digital Research