Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 28 Nov 2022 19:58:56 -0800
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-renesas-soc@vger.kernel.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        John Crispin <john@phrozen.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Marek Vasut <marex@denx.de>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        =?utf-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= <clement.leger@bootlin.com>,
        Alvin =?utf-8?Q?=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        UNGLinuxDriver@microchip.com,
        Woojung Huh <woojung.huh@microchip.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        George McCollister <george.mccollister@gmail.com>
Subject: Re: [PATCH v3 net-next 03/10] dt-bindings: net: dsa: utilize base
 definitions for standard dsa switches
Message-ID: <Y4WDgL8k9uDsVx4X@euler>
References: <20221127224734.885526-1-colin.foster@in-advantage.com>
 <20221127224734.885526-4-colin.foster@in-advantage.com>
 <20221128232337.GA1513198-robh@kernel.org>
 <Y4XSPMMDgiFipdIW@COLIN-DESKTOP1.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y4XSPMMDgiFipdIW@COLIN-DESKTOP1.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?OXKNlaykjjV1wN3mUyWxm4EOBor4FSM55bTW3g+JQdAnSg+s4HBQ2NoaxdfM?=
 =?us-ascii?Q?Cd6kDbYvt8lDisl53dbX5Ps1ZQKC2vu4YK9bmbazNnoNb6fmSj8qRsV3QoYN?=
 =?us-ascii?Q?3qeyLN7qFmBrm9RIVek8Aqr/O5bttzc/J7UZG6QfM6FcxRDZa3MWyVGDp56p?=
 =?us-ascii?Q?1/BJrgL3tHjKHQ/85i1o8+SAVzqZpr9LiRSABsDg22FUF+84IrXzXrcCPE1M?=
 =?us-ascii?Q?R4M/pFscEOeeNZhbWsHfwFfItv0FDJLhAlj4fE0wH5S6jPJYAyBh3XoDyMoL?=
 =?us-ascii?Q?MiuPylHPYKGTEuvl42VOv3bseGL9Ih0QUWHNw5e6E5UkKeVGPm7dUPgcS8WV?=
 =?us-ascii?Q?K156cH/rLLc6OyRb9EgL17slwu/eMVCzn6CvlzobrYdQybaQmwNyc4oBq8Vp?=
 =?us-ascii?Q?VuK/JWu0Mb3+WPsph4iEZCkIVAvfAG5I43mMsfZ5tYIANEcMz89bpsniW77Z?=
 =?us-ascii?Q?EKbfk+c/uqyztLNKhBrh4+aqZ96OpDbJk0l7WWwRAxP54H2ct5u0xcDPiuXv?=
 =?us-ascii?Q?dTtuQ+DJarLmrwm/7JRY8nmbby1/1ZYmPVaQgMGCTl+bup2FDcIC1anLk+JU?=
 =?us-ascii?Q?osAkDK7GCtyMgI1YyGXYCZ6H2k1jAecj2ao3yzhcolWzGJQJcujWtxjW/dmQ?=
 =?us-ascii?Q?REpsnjYmcujagPFJ35cMx8jWxGbN516p0PC8AeBBe59+BXidZUmOwKRGp9ko?=
 =?us-ascii?Q?cTIL/hFEeIfUsyOmdFSA/6Xxl7/zj7PCX84eVaO5RhH8V/EgwKhFvuuTBgjh?=
 =?us-ascii?Q?yAcJV5qREjf0ZyG2b273RA+Z73LZ+U6brgecGH9kwhbji+pfuekte84//ugT?=
 =?us-ascii?Q?vphy+tD1VlHUrgo5UVmrqQrMVXcMjY0v1gIHAcHzTWgcOdPPLFLRU66l9NdM?=
 =?us-ascii?Q?alae7zlOTMQnB1oXlpwN4u7KIQz1GG0mcLxwGL6qZj9lpRU8nGV83Uxp8gxL?=
 =?us-ascii?Q?AMgfg1zP+p3hD37Rx9tPKBnyrRO3kBIgd6XGA/Sx6I99S33LxLhZ/QRfLPTv?=
 =?us-ascii?Q?GteMHI+lfHIQK9iYcF6RbvDgViy/FwQBf0OJHRwCUp8h7xveGYxne5oVxgQF?=
 =?us-ascii?Q?IjxhVIpYkBkLose9mtP72wDt4Xh8QismaXCbyKFOZ+Jm8PtCUuJildt7y2xv?=
 =?us-ascii?Q?7QiTOYsLnvrbwCxdqMk5alo+96/g2egSyodsj3PX6+jlRuMOC1woLjw/eC2w?=
 =?us-ascii?Q?eopFX1jR6ZyYH6bNXhVMAjJCeOTMkxzjM/f3x4XZJUu8ZK6+FeynLl8ImciU?=
 =?us-ascii?Q?0IUR5I/IyMHQN10uiE4yu/FCT1ba3LWbpEAzICQmPRZ2Jwptmc868y+ImeXT?=
 =?us-ascii?Q?sb9C/5oiYclZKhGRl2hvv3f4hXKDguyjcVpc8Kktnlbew82qj3SuDYp8XWOK?=
 =?us-ascii?Q?Wzh/vTTyFicX3euUCpOBM3r+bxjn/LZofN9vlYxP+lBf0k4EvpsceTEfEEm2?=
 =?us-ascii?Q?mXXeYqV7Aq3yenxTnhkIUllBqZgtCJmWmUidTFXqnlgm82h/l6dDyk9wYrBq?=
 =?us-ascii?Q?0JS/Cn6ulf1RkC1fOPrhWjDIYErcqKC76DXbg5f+EwO5Yo11KBvo6JWPZMzE?=
 =?us-ascii?Q?MhQEjPGgn+s7mkfJ/DPCpSBjCeC62stzVA35JkGnd4H9K9B3AB2WoIWE9iP4?=
 =?us-ascii?Q?G+EaRscee5y6C0qguiqEPq0=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a278b17e-4647-468a-9d2d-08dad1be0c8c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 03:59:01.4317
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qrr8YeSle6iW9skuIdyQMXq/tEVOq+aPvoONMaH6WASKUzefy5U4Iy0/4IzBczRwpfwGwUe7MMMM9i/lQIiTNAXkjT3wuQfx7E/vKi+Lfds=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4565
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 29, 2022 at 01:34:52AM -0800, Colin Foster wrote:
> Hi Rob,
> 
> On Mon, Nov 28, 2022 at 05:23:37PM -0600, Rob Herring wrote:
> > On Sun, Nov 27, 2022 at 02:47:27PM -0800, Colin Foster wrote:
> > > diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > > index b9d48e357e77..bd1f0f7c14a8 100644
> > > --- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > > +++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
> > > @@ -19,9 +19,6 @@ description:
> > >  select: false
> > >  
> > >  properties:
> > > -  $nodename:
> > > -    pattern: "^(ethernet-)?switch(@.*)?$"
> > > -
> > >    dsa,member:
> > >      minItems: 2
> > >      maxItems: 2
> > > @@ -58,4 +55,20 @@ oneOf:
> > >  
> > >  additionalProperties: true
> > >  
> > > +$defs:
> > > +  base:
> > > +    description: A DSA switch without any extra port properties
> > > +    $ref: '#/'
> > > +
> > > +    patternProperties:
> > > +      "^(ethernet-)?ports$":
> > 
> > This node at the top level needs 'additionalProperties: false' assuming 
> > we don't allow extra properties in 'ports' nodes. If we do, then we'll 
> > need to be able to reference the 'ports' schema to extend it like is 
> > done with dsa-ports.yaml.
> 
> I'll double check if there's anything that adds any properties. If there
> is, would that be a separate file pair: "dsa-ports.yaml" and
> "ethernet-switch-ports.yaml"? Or do you think that could be contained in
> the existing dsa.yaml, ethernet-switch.yaml?

I came up with this change. It also fixes my accidental 's' affix to
^(ethernet-)port@[0-9]+.

diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.yaml b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
index 616753ba85a2..c1900363a6ab 100644
--- a/Documentation/devicetree/bindings/net/dsa/dsa.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/dsa.yaml
@@ -41,12 +41,18 @@ $defs:
     patternProperties:
       "^(ethernet-)?ports$":
         type: object
+        additionalProperties: false
+
+        properties:
+          '#address-cells':
+            const: 1
+          '#size-cells':
+            const: 0

         patternProperties:
-          "^(ethernet-)?ports@[0-9]+$":
+          "^(ethernet-)?port@[0-9]+$":
             description: Ethernet switch ports
             $ref: dsa-port.yaml#
             unevaluatedProperties: false

-
 ...