Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1669692810-26744-1-git-send-email-wangyufen@huawei.com>
In-Reply-To: <1669692810-26744-1-git-send-email-wangyufen@huawei.com>
From:   Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date:   Tue, 29 Nov 2022 13:11:15 +0900
Message-ID: <CAMZ6Rq+Y=7Cr8n68UMQ9FyfcZdNnHwaW5dabVf4CnaMadW90DQ@mail.gmail.com>
Subject: Re: [PATCH] USB: FHCI: fix error return code in of_fhci_probe()
To:     Wang Yufen <wangyufen@huawei.com>
Cc:     gregkh@linuxfoundation.org, linus.walleij@linaro.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue. 29 nov. 2022 à 12:33, Wang Yufen <wangyufen@huawei.com> wrote:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>  drivers/usb/host/fhci-hcd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..afef72a 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,6 +639,7 @@ static int of_fhci_probe(struct platform_device *ofdev)
>                                         NULL, i, GPIOD_OUT_LOW);
>
>                 if (IS_ERR(fhci->gpiods[i])) {
> +                       ret = PTR_ERR(fhci->gpiods[i])
>                         dev_err(dev, "incorrect GPIO%d: %ld\n",
>                                 i, PTR_ERR(fhci->gpiods[i]));

Can you add some extra clean-up and reuse ret in the dev_err()?

                         dev_err(dev, "incorrect GPIO%d: %ld\n", i, ret);

Alternatively you can also consider %pe to print the mnemotechnic
instead of the value:

                         dev_err(dev, "incorrect GPIO%d: %pe\n",
                                 i, fhci->gpiods[i]);


Yours sincerely,
Vincent Mailhol