Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89cac4d9-ed8a-1498-7e30-4a3c87720043@amd.com>
Date:   Mon, 28 Nov 2022 23:13:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] drm/amdkfd: Fix memory leakage
Content-Language: en-US
To:     Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Cc:     alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
        sumit.semwal@linaro.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, yusongping@huawei.com,
        hukeping@huawei.com, artem.kuzin@huawei.com
References: <20221129034734.2141562-1-konstantin.meskhidze@huawei.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20221129034734.2141562-1-konstantin.meskhidze@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWowbElZeTVEdFdSUUlRcWJCZGxmZVVWVjNuZU5heW1zayttUGRrT2RvN01l?=
 =?utf-8?B?aVhPeVc1RnIzYkVHZVNUbGVUUmJSOXMxdVRrMUdNNWtIYjM3eFBOR0JGU0gw?=
 =?utf-8?B?NnFTclIvZWtKZ1plZnVPM1I3eEM1TkFjMVRHT0Yxc2U1c0x3V2h1czFVVStP?=
 =?utf-8?B?ZjYzNXptSXJSbGliVFJsMThySGJaRXNNUERPNVVraS9kMklCMGtMTWRDMzVn?=
 =?utf-8?B?UEdhY0MwTFpLYW1rK3Q2RHphQlovOS8vbm0rV0hsUjdQb3A5Tyt5WTFlMVFv?=
 =?utf-8?B?ajRURGZEajU3ckQ4TmhnVjJrb29VT25iU25RNElIa0V6bE4zYjh0S2dqZlcv?=
 =?utf-8?B?MHpUK0U4TU4waUdZRElUcGZhR3NrNUZUWWo2bnV4d2xOOW1GNG5qQ2kzT2th?=
 =?utf-8?B?UUlqNVlJUzZRdytUd2JkV3RsK3Avdklnc2w3NEgyamEybFgzOGNoM0RqYlpG?=
 =?utf-8?B?NmNRSU95R3U4V2gwRHNSTzlWSTN6em15b1lMdTYvYjYwRHRqL2dyQXI1Ymtw?=
 =?utf-8?B?amZ6cjMxV2Y4Ykl0M0NvRGV5eVZyUlZhb3BzTU80UzRoWXZFSXR1UWFDcFAx?=
 =?utf-8?B?cnVXcWhFYU9JSm03TU4yZ1Zza0UrdW84R00xRkVpZU5vQ0tRcGhEOHdvVTUy?=
 =?utf-8?B?VDJwRkcyQVhrS1pITUZKVUozSlVlSHNnNjZ3dXh4QnE5WUtPMndjUEFQWThE?=
 =?utf-8?B?c3lUeU5hMk9yOGF6ckhSelo2L2QyandRNHhadWxoRi9PUGpzeFFmNEh5M0xB?=
 =?utf-8?B?b2szamVHUVdkcDA2UkNwOWxwL3VRY3llc3o4SzZ1ajNjMWhoU2o5NVBMS1dm?=
 =?utf-8?B?YzNFMWdBZzliSW9aMkxsbnVaVVNzM2hlZ1IxL0NSNkw4cHdkR3NSTnc0azIw?=
 =?utf-8?B?VTVRVHpxK25RTEF2eitwQlZsRnBrSUM4cG9QUzN4VTJuS1ZsVGlGMVZSRk1t?=
 =?utf-8?B?WldYRThPNE1jTFpYSElLdThrRDdWZGw0a1ltVzhOOGprcUtKbkJxVkp4aE91?=
 =?utf-8?B?bDYrK2hSSnNKTWNmRlpETVpCR0JMeFF2S09uS1FxVXdwSWNQZjVpeHAyTjZC?=
 =?utf-8?B?K2NjVi9mN2hGdHY3aWJyaVN6QnNLYkZjbzZzSUVOVE1yZWthaEFBMzdCeW53?=
 =?utf-8?B?ZUI4Z3d4YVBYZmh1ejd3S2lCcXpuLzhNTGk4MWx2d2VJZm1xYUxRZm5EMW14?=
 =?utf-8?B?bndOei9WWUpFTnNMLzM2MVB1NjFUSVRoZmQ5SXlBNTNjdnljeWNnTitkazhv?=
 =?utf-8?B?THFoSjZWT01CY09YRC9BSVN3bVJadVRKaVA1aXhhaG81REVRZkJsdDJFZXRU?=
 =?utf-8?B?c1pXL3RzNUh4em00MTZlbkR4bTRRcC9wS1EvdTRuekdnbWxhYjNXS1Z1WDNu?=
 =?utf-8?B?WFNZSE8rRk10K1VTSXdqVUlPNGdXWlc1eGZBZmp6eEtSU2dKajFaMlFWaE9P?=
 =?utf-8?B?SDJwcmliYXJtZE9Nb0NVTUFPT09KS0RPZ0lpRWY1SE51WXhKQndtenBETjgv?=
 =?utf-8?B?OGo1N05uZ1hqNXRnOXhTV2trNGZYcmdKcDlEMDJEUTV5U0ZhUEV0Sko3RTI3?=
 =?utf-8?B?eGh1VGlLMkdjdUZYSElkZEc5bENlYnVrcE5TV2tPV3o0NDNKdDB4VTl4dHh5?=
 =?utf-8?B?SWU0dWZFSzl4MVN6OXVvV1FleWNieGhsdjMrTW1CRndJbGtZa0FEMEZLQW94?=
 =?utf-8?B?WjF5dUNKWjJicU40Z2ZFTjJaNkxmckpRendFQTBRZWVRYXFQN0lsZ0pFcXZM?=
 =?utf-8?B?R0J2MERaYzlvTzVEQ0hDejBYWldvc3NYT3VxVXBFOEdWajNhQ1U0aFIrSXlh?=
 =?utf-8?B?eEpOWndwS2hNUHp2TWFrM2dZZ05VZlZnaTJzRnFDVGJyb2NGNnk1WWNmRkUx?=
 =?utf-8?B?RnZUN2podG5wM1BlaHJ2NjFsY0FZRU1sTjVsMHdGcGFLMlJHamZXL2hCMERu?=
 =?utf-8?B?TTc4UUZBTEpxbGJOQ0hKaXdTV2N2ZW9nbW5wTjZHM0tMUmFyb1dBSWZSWmhi?=
 =?utf-8?B?OE8zNWliRDRpWkdySXZybUpIemQreUZpWlh5S3BUUUJDQ0doS1hPNG9tcEIr?=
 =?utf-8?B?QllNb0xhT2svN3o5RnRjN1NGQTFNWVFTRE5zazdXY0pOeFZ0UEsvYi9JbE9N?=
 =?utf-8?Q?slfxA89IZz80Oxn/M4Ql3wMFH?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78e3e0e6-1b76-4e34-2237-08dad1c01f37
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 04:14:00.4959
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PT6hQ4AXzXStPzitw4dL4K/w9Gwd/nbLxnAE53x/V8eC4n+20Z+cyG8FbuWsF70OHHzy+8AgjnngttCUql6xRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4944
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 2022-11-28 um 22:47 schrieb Konstantin Meskhidze:
> This patch fixes potential memory leakage and seg fault
> in  _gpuvm_import_dmabuf() function
>
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>

Thank you for the patch. I'm adding a Fixes tag and pushing the patch to 
amd-staging-drm-next.

Fixes: d4ec4bdc0bd5 ("drm/amdkfd: Allow access for mmapping KFD BOs")
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 978d3970b5cc..e0084f712e02 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -2257,7 +2257,7 @@ int amdgpu_amdkfd_gpuvm_import_dmabuf(struct amdgpu_device *adev,
>   
>   	ret = drm_vma_node_allow(&obj->vma_node, drm_priv);
>   	if (ret) {
> -		kfree(mem);
> +		kfree(*mem);
>   		return ret;
>   	}
>