Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4cee0097-4f08-1990-112f-6e39229f59ef@intel.com>
Date:   Tue, 29 Nov 2022 12:50:57 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.0
Subject: Re: [PATCH] nvme: clear the prp2 field of the nvme command.
To:     Chaitanya Kulkarni <chaitanyak@nvidia.com>,
        "kbusch@kernel.org" <kbusch@kernel.org>,
        "axboe@fb.com" <axboe@fb.com>, "hch@lst.de" <hch@lst.de>,
        "sagi@grimberg.me" <sagi@grimberg.me>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20221129014711.91305-1-lei.rao@intel.com>
 <15de4902-03e7-0d2c-4b4c-45d713d0f1fd@nvidia.com>
Content-Language: en-US
From:   "Rao, Lei" <lei.rao@intel.com>
In-Reply-To: <15de4902-03e7-0d2c-4b4c-45d713d0f1fd@nvidia.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlVaUG1PbEx4NEh1dFBZdWtVbXhrZjEzcEpQaVI4ZGRzN0RTb2U4eVdMMTNR?=
 =?utf-8?B?OUFJMXU5OEU2Zk5VQUx3WUZyL05LaDhsQUV2Qm5JMll3K3A4VWc4VWFHbTd2?=
 =?utf-8?B?eXR1RTFMUEFHRmVJZ3V2R29DbzM2RUxyTytScm5PSmVyVDRQdnE4QktWYUxm?=
 =?utf-8?B?MS9jM2xKK3BFRkFIVzdudThJRlkyVDBzZks4UHk0VCtBTmgvN3VGWUlNMi9x?=
 =?utf-8?B?aG9WTnZlckJvRGVBMFRpYTBsV0dTUDhCbXhPSVZVbU9NQ1cvUGY3bTFlY1lJ?=
 =?utf-8?B?U1NEeDBYUjVENjcrbTRhdWNRV2d3WEhvWUtPa2luR0NYdGhkeFRJNE5vckg4?=
 =?utf-8?B?ZWRjckdiV1lKbEk5eTBNWUJrZW4rcWhKZFk4K0tCM0RnTTM3UDA4WmlRMWRy?=
 =?utf-8?B?c3NsVGt1dUNnbThsK3FscFhmYkVhbDIxRXR6VHJBS3lBZ0ZnNTJoZjh2L0hH?=
 =?utf-8?B?RDI2T3Rqd3p3RHovdjdwMVVqYnFMc2J0NUVVT2ptOGxteDdSa0xUS0tRMVk5?=
 =?utf-8?B?MGxCK0NQSGNSbGxHdkNna3k3QXJmemdMZysxdzNVUUkwenBHQTh0QzFrZDdR?=
 =?utf-8?B?NERpczc5Q05zUW1XdFVkSHpRS0oxekdvOG4zWGUwczZ0NElVcEZSazFBeXBx?=
 =?utf-8?B?YTRpeW5obGtPaTQxSW5DeGk0K0lCQmFHdEN0UWdCR1RrMmJsTWhYeHJ4TTVr?=
 =?utf-8?B?M29XdWNESVBXWWtOZytjS2Z0UWJ6d2pmd1pxNk0razRCeG96UlFmbWd5WlN4?=
 =?utf-8?B?NzRWNE5PWmVzd3VFOFJQZFg4cTFoU2pYQ3AyR2pkYitzREhOWGFCNUtzMlNR?=
 =?utf-8?B?ay9mVkdoTjFCcWJkQzBpUlloS3ZVVzFMVFNmSEtnQVJvY2sra1RUeHJBbm5T?=
 =?utf-8?B?dUZjZzRzbU5rWWtrWUNIUHlOZU5KMC9YS1ZQOUh4dCt0QjFaa1ZmZ2ZsWk9q?=
 =?utf-8?B?NFVFNkphcUNCdnlIR0QyQVhPUi9XNmNTWW55a01XeVRVdFFGck8rVWJXbDI3?=
 =?utf-8?B?RGZGV0FQOXpDRmNiMFRxaUZRN2F3c1hjQWFFTlFoaXpQR2VnZ2MzRGFvUDBW?=
 =?utf-8?B?ZHIxNnhVeGViS01SOW96bVFWZlV0dXV3QkV3THcxYmc2QXl3Nmx3OG1IZ2pi?=
 =?utf-8?B?MTVPb3JmU0dwNzd6Nmovc3R1azZ5TVQ0MjRObWM0TG1IdVFBcVM1dHU2eEdN?=
 =?utf-8?B?ZXBid2ljeW42T2RBb2VucUtCLzBwZjF5Y09PNVc3dXI1REV6M2liK2VSMzBN?=
 =?utf-8?B?Y1kwemtncTFOVVpvN0lIL21VRDRwMTdJUkFiVXB0UmdaaHJ6VE9tUUgxRlcw?=
 =?utf-8?B?enNjbXRkL2EwNHVrY3gwTEh3bVF5TzZuVHFHK2dnbGMzakdRdURMNjBqY2pn?=
 =?utf-8?B?Rko2eHJjeWRmSWJINnRhZVhhQmVXL0NuMnlkMVZRYnF1S1BQb0ljY1JQK3NH?=
 =?utf-8?B?c0NHVGN6ZGdqN0xSUTkwUVdPd0F4L3Q1ZG1MWit2YzdwcEp1c2hHV1QwY0Jz?=
 =?utf-8?B?ekFFbkxkbkdSclM2dGJhMm9OWE8rOWkySXZ2TXV6c2U3a2l6RXRJeGkzemVC?=
 =?utf-8?B?MXBYUUJqYUZVR0dYekorUUJKdEtYdjhkYUZtbmNvN0VNT3ViNUFKOTJDblB2?=
 =?utf-8?B?MlZXVWM3VmU1M0pWelBnSVc5OXhjMGZ0TUUrZFgxK2pERmdQVkFBT1VGNVpr?=
 =?utf-8?B?aTBBeTQ3a2orVkMyVWpxa2xaVkdNSmVRZDgwMFc2b2o5eHVsQmxVR25CRFZt?=
 =?utf-8?B?ZmZ4R0QzMTNzc2V0RFhxcUFad0l6M3hiV1l1WTZRUmtxWExtcGU4aGpwS2Q4?=
 =?utf-8?B?bmRYdXQzdHZLdnliU2NidFF0TEVZL3cxTWdacXAxQk1MbkYxM0Z1Smkyd29q?=
 =?utf-8?B?eHVlUStjdTcyR2xsSWx5dmlVTTY1RnA1Rit5aTNjQjhLZGM5ZHMyUVczSjdo?=
 =?utf-8?B?cFJBNnlRY29PNGh4NUZ2VCsrM09menN6TFlKMW8rQXVucmYrM1BZMHRiZUJk?=
 =?utf-8?B?NnJZK2IyckZMbVp6WkhqK3V5ZEZPZ2ZobjltMzR1MFV6c3BkNnRZRmFsd1VP?=
 =?utf-8?B?N1laVmdnbUFRREtSY1AreEcyS0dEODZwYWJwL3F0UG5FRFdBam84a0hlUkd1?=
 =?utf-8?Q?RviLNiIYqz3bZDUZaERcWnWe2?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f99e7275-c70d-46b0-67b5-08dad1c553cc
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5640.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Nov 2022 04:51:08.7898
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fXOZRCZZeYpwlpVZAnJ/zUl8dYFd+/29WF5gNzfaGHX/ecMAiTNfUS0Nu1nkYW+3Yf9AsGgynmHEibQ5o/weWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5653
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/29/2022 12:16 PM, Chaitanya Kulkarni wrote:
> On 11/28/22 17:47, Lei Rao wrote:
>> If the prp2 field is not filled in nvme_setup_prp_simple(), the prp2
>> field is garbage data. According to nvme spec, the prp2 is reserved if
>> the data transfer does not cross a memory page boundary. Writing a
>> reserved coded value into a controller property field produces undefined
>> results, so it needs to be cleared in nvme_setup_rw().
>>
>> Signed-off-by: Lei Rao <lei.rao@intel.com>
> 
> if it is reserved then controller shoule ignore this field, no ?

It's feasible for the controller to ignore this field. But our controller has
stricter checks, and if prp2 is not used but has a value, some warnings will be
printed. According to the NVMe spec, it seems to write a reserved field produces
an undefined result, so maybe clearing it is better.

Thanks,
Lei

> 
> not sure if original author wanted to avoid an extra assignment
> in the fast path with assumption that reserved fields should be
> ignored if it is then we should avoid this, if not then looks good
> 
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
> 
> -ck
>