Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c8b9e41-dabb-f6f6-04e7-778c91a6b432@huawei.com>
Date:   Tue, 29 Nov 2022 14:24:44 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2] USB: FHCI: fix error return code in of_fhci_probe()
To:     <gregkh@linuxfoundation.org>, <linus.walleij@linaro.org>,
        <mailhol.vincent@wanadoo.fr>
CC:     <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <1669704115-40011-1-git-send-email-wangyufen@huawei.com>
From:   wangyufen <wangyufen@huawei.com>
In-Reply-To: <1669704115-40011-1-git-send-email-wangyufen@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Please ignore.

Thanks.

在 2022/11/29 14:41, Wang Yufen 写道:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
> 
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>   drivers/usb/host/fhci-hcd.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..ca4b311 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>   					NULL, i, GPIOD_OUT_LOW);
>   
>   		if (IS_ERR(fhci->gpiods[i])) {
> -			dev_err(dev, "incorrect GPIO%d: %ld\n",
> -				i, PTR_ERR(fhci->gpiods[i]));
> +			ret = PTR_ERR(fhci->gpiods[i])
> +			dev_err(dev, "incorrect GPIO%d: %d\n",
> +				i, ret);
>   			goto err_gpios;
>   		}
>   		if (!fhci->gpiods[i]) {