Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp362864rwb; Mon, 28 Nov 2022 22:37:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf7b56HLBTJ8amBrZkVCHbJ+7PtjZPfe4N1uKWjfTp/2J7Vos3rYYeaFw90R3nxEEWGjbGjq X-Received: by 2002:a17:907:b689:b0:78c:f5a1:86bf with SMTP id vm9-20020a170907b68900b0078cf5a186bfmr21744614ejc.245.1669703864545; Mon, 28 Nov 2022 22:37:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669703864; cv=none; d=google.com; s=arc-20160816; b=dfj0XiKhyro/mmgOf/vfcTRbcZdRG1fnAQfjLfRmUP93xm0zQ5XPDd5oHbYxqflwQB 1qyWSyYNsaq46LSLsAtJoJKfLzo3p1pkhtPs5cHCIr+w0cZhBNAV9xvLVp/I/G3wCJFO igLxWIgUhRnPYWyEje0MobcChCa3kYdtUXTqnTRo+et4PrLCsZA16u1aUn9P19i1JFVn 7AEDYNdKu9eoCOqhYamQDkim3vGeQzxOd1Cc5VIsxP6rFkOnS4xJ5jw2fyk9BJAflDVc a6ARro7etfqrkpYMKvoFavMLbTKdZpe6MgmAOwSJLYfjhaPivxVsH/82oQMmZP5uo5WK BoCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=W2vYBMpyNjL8omVh8lTjcrj5TCpoTgdD0MfiR3B+EBE=; b=K3gvCnJA2XSFpgtqzjfVy9KEVnb7o8dLPjUNUCHuHBlp3NL+d4JrKXcBKy/e+Kq20F BkQHpiewNkL26VPTxVOM50bLH6oVyFEPOlkcwcTmdBmsPhWhYIvDJdUrwCvPaLcUUB77 rPiSuH9LGAC7Kt1QYcfR50u/qkLItePZSSFm+WPFiEeeeIuHjlrAjLFHmoTUxIuuT3JZ JDTkOQW3sylUUr+9lZWNfWjl+ixwKppQL8bCePYp4O+koG+4WYo5Ty82GIGbVX7tHaHl bhFUz+4b8NoqWXfDS9DwUIQt0n/sS5DLwavb4Lf5dlsqEO7UlDzb1tjmXQMj/RH69vkd j44A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xj14-20020a170906db0e00b0079dccbbf0c0si10722939ejb.146.2022.11.28.22.37.24; Mon, 28 Nov 2022 22:37:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235572AbiK2FgJ (ORCPT + 82 others); Tue, 29 Nov 2022 00:36:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235177AbiK2FgH (ORCPT ); Tue, 29 Nov 2022 00:36:07 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 232D127CE1 for ; Mon, 28 Nov 2022 21:36:05 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oztHT-0007aB-BQ; Tue, 29 Nov 2022 06:35:43 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oztHP-0004If-Vo; Tue, 29 Nov 2022 06:35:39 +0100 Date: Tue, 29 Nov 2022 06:35:39 +0100 From: Oleksij Rempel To: Jacob Keller Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, Arun.Ramadoss@microchip.com, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v1 00/26] net: dsa: microchip: stats64, fdb, error Message-ID: <20221129053539.GA25526@pengutronix.de> References: <20221128115958.4049431-1-o.rempel@pengutronix.de> <7f0a7acc-4b6b-8e33-7098-e5dfcb67945f@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7f0a7acc-4b6b-8e33-7098-e5dfcb67945f@intel.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 03:09:19PM -0800, Jacob Keller wrote: > > > On 11/28/2022 3:59 AM, Oleksij Rempel wrote: > > This patch series is a result of maintaining work on ksz8 part of > > microchip driver. It includes stats64 and fdb support. Error handling. > > Loopback fix and so on... > > > > Oleksij Rempel (26): > > net: dsa: microchip: add stats64 support for ksz8 series of switches > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix port validation and VID > > information > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix not complete fdb > > extraction > > net: dsa: microchip: ksz8: ksz8_fdb_dump: fix time stamp extraction > > net: dsa: microchip: ksz8: ksz8_fdb_dump: do not extract ghost entry > > from empty table > > net: dsa: microchip: ksz8863_smi: fix bulk access > > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove timestamp support > > net: dsa: microchip: make ksz8_r_dyn_mac_table() static > > net: dsa: microchip: ksz8_r_dyn_mac_table(): remove fid support > > net: dsa: microchip: ksz8: refactor ksz8_fdb_dump() > > net: dsa: microchip: ksz8: ksz8_fdb_dump: dump static MAC table > > net: dsa: microchip: ksz8: move static mac table operations to a > > separate functions > > net: dsa: microchip: ksz8: add fdb_add/del support > > net: dsa: microchip: KSZ88x3 fix loopback support > > net: dsa: microchip: ksz8_r_dyn_mac_table(): move main part of the > > code out of if statement > > net: dsa: microchip: ksz8_r_dyn_mac_table(): use ret instead of rc > > net: dsa: microchip: ksz8_r_dyn_mac_table(): ksz: do not return EAGAIN > > on timeout > > net: dsa: microchip: ksz8_r_dyn_mac_table(): return read/write error > > if we got any > > net: dsa: microchip: ksz8_r_dyn_mac_table(): use entries variable to > > signal 0 entries > > net: dsa: microchip: make ksz8_r_sta_mac_table() static > > net: dsa: microchip: ksz8_r_sta_mac_table(): do not use error code for > > empty entries > > net: dsa: microchip: ksz8_r_sta_mac_table(): make use of error values > > provided by read/write functions > > net: dsa: microchip: make ksz8_w_sta_mac_table() static > > net: dsa: microchip: ksz8_w_sta_mac_table(): make use of error values > > provided by read/write functions > > net: dsa: microchip: remove ksz_port:on variable > > net: dsa: microchip: ksz8: do not force flow control by default > > > > > My understanding is that we typically limit series to 15 patches. Do you > have some justification for why this goes over 15 and can't reasonably be > split into two series? > > At a glance it seems like a bunch of smaller cleanups. The previous patch set got request to do more clean ups: https://lore.kernel.org/all/20221124101458.3353902-1-o.rempel@pengutronix.de/ I need to show, there are already more patches in the queue. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |