Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1669704232-40228-1-git-send-email-wangyufen@huawei.com>
In-Reply-To: <1669704232-40228-1-git-send-email-wangyufen@huawei.com>
From:   Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Date:   Tue, 29 Nov 2022 16:03:50 +0900
Message-ID: <CAMZ6Rq+rTiAu3+SZ1GrE1+NoRnuoJ=g_6LA7GKZBOreQZVC3jQ@mail.gmail.com>
Subject: Re: [PATCH v3] USB: FHCI: fix error return code in of_fhci_probe()
To:     Wang Yufen <wangyufen@huawei.com>
Cc:     gregkh@linuxfoundation.org, linus.walleij@linaro.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue. 29 Nov. 2022 at 15:43, Wang Yufen <wangyufen@huawei.com> wrote:
> Fix to return a negative error code of PTR_ERR(fhci->gpiods[i])
> instead of 0.
>
> Fixes: a4efdb8a423b ("USB: FHCI: Switch to GPIO descriptors")
> Signed-off-by: Wang Yufen <wangyufen@huawei.com>
> ---
>  drivers/usb/host/fhci-hcd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/host/fhci-hcd.c b/drivers/usb/host/fhci-hcd.c
> index 95a4446..c8a1b98 100644
> --- a/drivers/usb/host/fhci-hcd.c
> +++ b/drivers/usb/host/fhci-hcd.c
> @@ -639,8 +639,9 @@ static int of_fhci_probe(struct platform_device *ofdev)
>                                         NULL, i, GPIOD_OUT_LOW);
>
>                 if (IS_ERR(fhci->gpiods[i])) {
> -                       dev_err(dev, "incorrect GPIO%d: %ld\n",
> -                               i, PTR_ERR(fhci->gpiods[i]));
> +                       ret = PTR_ERR(fhci->gpiods[i]);
> +                       dev_err(dev, "incorrect GPIO%d: %d\n",
> +                               i, ret);

Nitpick: you do not need a new line. It fits the 80 characters limit very well.

Aside of that:
Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>

>                         goto err_gpios;
>                 }
>                 if (!fhci->gpiods[i]) {
> --
> 1.8.3.1
>